|
»
»
[jira] Created: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
|
View:
New views
9 Messages
—
Rating Filter:
Alert me
|
 |
[jira] Created: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
by JIRA jira@codehaus.org
::
Rate this Message:
Exceptions thrown by expectations should be caught and available for rethrowing during verification
--------------------------------------------------------------------------------------------------- Key: JMOCK-183 URL: http://jira.codehaus.org/browse/JMOCK-183 Project: jMock Issue Type: Bug Components: Library Affects Versions: 2.4.0 Environment: all Reporter: Steve Freeman Assignee: Steve Freeman At present, Mockery.assertIsSatisfied() flushes any expectations errors that have been thrown during a test but that have not stopped it. Nat and I can't think of a case where there's a good reason to do this. The effect is that if an ExpectationError is thrown but caught and dropped by the code under test, then the test will pass. What we think /should/ happen is that such exceptions should be recorded (which they are) and rethrown if still present during verification. This would invalidate CascadedFailuresAcceptanceTests.testSuccessfulVerifyClearsFirstFailure() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Updated: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
by JIRA jira@codehaus.org
::
Rate this Message:
[ http://jira.codehaus.org/browse/JMOCK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nat Pryce updated JMOCK-183: ---------------------------- Assignee: (was: Steve Freeman) Fix Version/s: 2.7.0 > Exceptions thrown by expectations should be caught and available for rethrowing during verification > --------------------------------------------------------------------------------------------------- > > Key: JMOCK-183 > URL: http://jira.codehaus.org/browse/JMOCK-183 > Project: jMock > Issue Type: Bug > Components: Library > Affects Versions: 2.4.0 > Environment: all > Reporter: Steve Freeman > Fix For: 2.7.0 > > > At present, Mockery.assertIsSatisfied() flushes any expectations errors that have been thrown during a test but that have not stopped it. Nat and I can't think of a case where there's a good reason to do this. The effect is that if an ExpectationError is thrown but caught and dropped by the code under test, then the test will pass. What we think /should/ happen is that such exceptions should be recorded (which they are) and rethrown if still present during verification. > This would invalidate CascadedFailuresAcceptanceTests.testSuccessfulVerifyClearsFirstFailure() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
by JIRA jira@codehaus.org
::
Rate this Message:
[ http://jira.codehaus.org/browse/JMOCK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=167098#action_167098 ] Joerg Schaible commented on JMOCK-183: -------------------------------------- For JMock 1.x I provided a solution in JMOCK-59 using a monitor approach. > Exceptions thrown by expectations should be caught and available for rethrowing during verification > --------------------------------------------------------------------------------------------------- > > Key: JMOCK-183 > URL: http://jira.codehaus.org/browse/JMOCK-183 > Project: jMock > Issue Type: Bug > Components: Library > Affects Versions: 2.4.0 > Environment: all > Reporter: Steve Freeman > Fix For: 2.7.0 > > > At present, Mockery.assertIsSatisfied() flushes any expectations errors that have been thrown during a test but that have not stopped it. Nat and I can't think of a case where there's a good reason to do this. The effect is that if an ExpectationError is thrown but caught and dropped by the code under test, then the test will pass. What we think /should/ happen is that such exceptions should be recorded (which they are) and rethrown if still present during verification. > This would invalidate CascadedFailuresAcceptanceTests.testSuccessfulVerifyClearsFirstFailure() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
by JIRA jira@codehaus.org
::
Rate this Message:
[ http://jira.codehaus.org/browse/JMOCK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=167258#action_167258 ] Nat Pryce commented on JMOCK-183: --------------------------------- The code in JMOCK-59 is addressing a different issue. This issue has nothing to do with multithreading but is required for jMock to report errors correctly if it is made thread-safe (JMOCK-213). > Exceptions thrown by expectations should be caught and available for rethrowing during verification > --------------------------------------------------------------------------------------------------- > > Key: JMOCK-183 > URL: http://jira.codehaus.org/browse/JMOCK-183 > Project: jMock > Issue Type: Bug > Components: Library > Affects Versions: 2.4.0 > Environment: all > Reporter: Steve Freeman > Fix For: 2.7.0 > > > At present, Mockery.assertIsSatisfied() flushes any expectations errors that have been thrown during a test but that have not stopped it. Nat and I can't think of a case where there's a good reason to do this. The effect is that if an ExpectationError is thrown but caught and dropped by the code under test, then the test will pass. What we think /should/ happen is that such exceptions should be recorded (which they are) and rethrown if still present during verification. > This would invalidate CascadedFailuresAcceptanceTests.testSuccessfulVerifyClearsFirstFailure() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Issue Comment Edited: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
by JIRA jira@codehaus.org
::
Rate this Message:
[ http://jira.codehaus.org/browse/JMOCK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=167258#action_167258 ] Nat Pryce edited comment on JMOCK-183 at 2/26/09 8:08 PM: ---------------------------------------------------------- The code in JMOCK-59 is addressing a different issue. This issue has nothing to do with multithreading. However, it must be implemented to make jMock report errors correctly if/when it is made thread-safe (JMOCK-213). was (Author: npryce): The code in JMOCK-59 is addressing a different issue. This issue has nothing to do with multithreading but is required for jMock to report errors correctly if it is made thread-safe (JMOCK-213). > Exceptions thrown by expectations should be caught and available for rethrowing during verification > --------------------------------------------------------------------------------------------------- > > Key: JMOCK-183 > URL: http://jira.codehaus.org/browse/JMOCK-183 > Project: jMock > Issue Type: Bug > Components: Library > Affects Versions: 2.4.0 > Environment: all > Reporter: Steve Freeman > Fix For: 2.7.0 > > > At present, Mockery.assertIsSatisfied() flushes any expectations errors that have been thrown during a test but that have not stopped it. Nat and I can't think of a case where there's a good reason to do this. The effect is that if an ExpectationError is thrown but caught and dropped by the code under test, then the test will pass. What we think /should/ happen is that such exceptions should be recorded (which they are) and rethrown if still present during verification. > This would invalidate CascadedFailuresAcceptanceTests.testSuccessfulVerifyClearsFirstFailure() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Assigned: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
by JIRA jira@codehaus.org
::
Rate this Message:
[ http://jira.codehaus.org/browse/JMOCK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nat Pryce reassigned JMOCK-183: ------------------------------- Assignee: Nat Pryce > Exceptions thrown by expectations should be caught and available for rethrowing during verification > --------------------------------------------------------------------------------------------------- > > Key: JMOCK-183 > URL: http://jira.codehaus.org/browse/JMOCK-183 > Project: jMock > Issue Type: Bug > Components: Library > Affects Versions: 2.4.0 > Environment: all > Reporter: Steve Freeman > Assignee: Nat Pryce > Fix For: 2.7.0 > > > At present, Mockery.assertIsSatisfied() flushes any expectations errors that have been thrown during a test but that have not stopped it. Nat and I can't think of a case where there's a good reason to do this. The effect is that if an ExpectationError is thrown but caught and dropped by the code under test, then the test will pass. What we think /should/ happen is that such exceptions should be recorded (which they are) and rethrown if still present during verification. > This would invalidate CascadedFailuresAcceptanceTests.testSuccessfulVerifyClearsFirstFailure() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Work started: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
by JIRA jira@codehaus.org
::
Rate this Message:
[ http://jira.codehaus.org/browse/JMOCK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on JMOCK-183 started by Nat Pryce. > Exceptions thrown by expectations should be caught and available for rethrowing during verification > --------------------------------------------------------------------------------------------------- > > Key: JMOCK-183 > URL: http://jira.codehaus.org/browse/JMOCK-183 > Project: jMock > Issue Type: Bug > Components: Library > Affects Versions: 2.4.0 > Environment: all > Reporter: Steve Freeman > Assignee: Nat Pryce > Fix For: 2.7.0 > > > At present, Mockery.assertIsSatisfied() flushes any expectations errors that have been thrown during a test but that have not stopped it. Nat and I can't think of a case where there's a good reason to do this. The effect is that if an ExpectationError is thrown but caught and dropped by the code under test, then the test will pass. What we think /should/ happen is that such exceptions should be recorded (which they are) and rethrown if still present during verification. > This would invalidate CascadedFailuresAcceptanceTests.testSuccessfulVerifyClearsFirstFailure() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Resolved: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
by JIRA jira@codehaus.org
::
Rate this Message:
[ http://jira.codehaus.org/browse/JMOCK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nat Pryce resolved JMOCK-183. ----------------------------- Resolution: Fixed Implemented in SVN trunk > Exceptions thrown by expectations should be caught and available for rethrowing during verification > --------------------------------------------------------------------------------------------------- > > Key: JMOCK-183 > URL: http://jira.codehaus.org/browse/JMOCK-183 > Project: jMock > Issue Type: Bug > Components: Library > Affects Versions: 2.4.0 > Environment: all > Reporter: Steve Freeman > Assignee: Nat Pryce > Fix For: 2.7.0 > > > At present, Mockery.assertIsSatisfied() flushes any expectations errors that have been thrown during a test but that have not stopped it. Nat and I can't think of a case where there's a good reason to do this. The effect is that if an ExpectationError is thrown but caught and dropped by the code under test, then the test will pass. What we think /should/ happen is that such exceptions should be recorded (which they are) and rethrown if still present during verification. > This would invalidate CascadedFailuresAcceptanceTests.testSuccessfulVerifyClearsFirstFailure() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Updated: (JMOCK-183) Exceptions thrown by expectations should be caught and available for rethrowing during verification
by JIRA jira@codehaus.org
::
Rate this Message:
[ http://jira.codehaus.org/browse/JMOCK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nat Pryce updated JMOCK-183: ---------------------------- Fix Version/s: (was: 2.7.0) 2.6.0 > Exceptions thrown by expectations should be caught and available for rethrowing during verification > --------------------------------------------------------------------------------------------------- > > Key: JMOCK-183 > URL: http://jira.codehaus.org/browse/JMOCK-183 > Project: jMock > Issue Type: Bug > Components: Library > Affects Versions: 2.4.0 > Environment: all > Reporter: Steve Freeman > Assignee: Nat Pryce > Fix For: 2.6.0 > > > At present, Mockery.assertIsSatisfied() flushes any expectations errors that have been thrown during a test but that have not stopped it. Nat and I can't think of a case where there's a good reason to do this. The effect is that if an ExpectationError is thrown but caught and dropped by the code under test, then the test will pass. What we think /should/ happen is that such exceptions should be recorded (which they are) and rethrown if still present during verification. > This would invalidate CascadedFailuresAcceptanceTests.testSuccessfulVerifyClearsFirstFailure() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
| Free embeddable forum powered by Nabble | Forum Help |
