[jira] Created: (LUCENE-2027) Deprecate Directory.touchFile

Deprecate Directory.touchFile
-----------------------------

                 Key: LUCENE-2027
                 URL: https://issues.apache.org/jira/browse/LUCENE-2027
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Store
            Reporter: Michael McCandless
            Priority: Trivial
             Fix For: 3.1


Lucene doesn't use this method, and, FindBugs reports that FSDirectory's impl shouldn't swallow the returned result from File.setLastModified.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

    [ https://issues.apache.org/jira/browse/LUCENE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773543#action_12773543 ]

Simon Willnauer commented on LUCENE-2027:
-----------------------------------------

We talked about this yesterday night @ApacheCon. It would probably be the right thing to deprecate and introduce a new method returning a boolean. For now we where talking about throwing an IOException if setLastModified returns false. The Directory interface already has an IOException in the function signature so that would not break back compat but would yield the correct behaviour.

simon

> Deprecate Directory.touchFile
> -----------------------------
>
>                 Key: LUCENE-2027
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2027
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Michael McCandless
>            Priority: Trivial
>             Fix For: 3.1
>
>
> Lucene doesn't use this method, and, FindBugs reports that FSDirectory's impl shouldn't swallow the returned result from File.setLastModified.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

    [ https://issues.apache.org/jira/browse/LUCENE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773546#action_12773546 ]

Michael McCandless commented on LUCENE-2027:
--------------------------------------------

Why not simply deprecate and then remove the method?  Nothing in Lucene uses it.

> Deprecate Directory.touchFile
> -----------------------------
>
>                 Key: LUCENE-2027
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2027
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Michael McCandless
>            Priority: Trivial
>             Fix For: 3.1
>
>
> Lucene doesn't use this method, and, FindBugs reports that FSDirectory's impl shouldn't swallow the returned result from File.setLastModified.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

    [ https://issues.apache.org/jira/browse/LUCENE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773548#action_12773548 ]

Uwe Schindler commented on LUCENE-2027:
---------------------------------------

Missed this issue, from java-user:

We discussed about this method yesterday in the evening. The abstract base
class defines the method as throwing an IOException. So the correct
behaviour would be to throw an IOException if setLastModified returns false
(which happens according to the docs, if the date cannot be changed because
of an IO/FS prob).

> Deprecate Directory.touchFile
> -----------------------------
>
>                 Key: LUCENE-2027
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2027
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Michael McCandless
>            Priority: Trivial
>             Fix For: 3.1
>
>
> Lucene doesn't use this method, and, FindBugs reports that FSDirectory's impl shouldn't swallow the returned result from File.setLastModified.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...