[jira] Created: (LUCENE-2032) DistanceFilter not Serializable

DistanceFilter not Serializable
-------------------------------

                 Key: LUCENE-2032
                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
             Project: Lucene - Java
          Issue Type: Bug
          Components: Search
    Affects Versions: 2.9
            Reporter: Joey Surls


I am using Lucene in a distributed setup.

The DistanceFilter in the spatial project isn't Serializable even though it inherits it from Filter. Filter is a Serializable class.

DistanceFilter contains the non-Serializable class WeakHashMap.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

     [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joey Surls updated LUCENE-2032:
-------------------------------

    Description:
I am using Lucene in a distributed setup.

The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.

DistanceFilter contains the non-Serializable class WeakHashMap.
CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger


  was:
I am using Lucene in a distributed setup.

The DistanceFilter in the spatial project isn't Serializable even though it inherits it from Filter. Filter is a Serializable class.

DistanceFilter contains the non-Serializable class WeakHashMap.

        Summary: Spatial Filters not Serializable  (was: DistanceFilter not Serializable)

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

    [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773704#action_12773704 ]

Robert Muir commented on LUCENE-2032:
-------------------------------------

Hi Joey, do you have a patch by any chance?

i think you will have to write a readObject() to fix this.

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

     [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-2032:
----------------------------------

    Attachment: LUCENE-2032.patch

This patch fixes it in trunk.

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>         Attachments: LUCENE-2032.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

     [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler resolved LUCENE-2032.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0
         Assignee: Uwe Schindler

Committed revision: 832987

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

     [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joey Surls reopened LUCENE-2032:
--------------------------------


CartesianShapeFilter also uses the non-Serializable class Shape

I think all that is needed is to add Serializable to Shape

The following code can be used to verify any other embedded classes not serialized:

private static boolean isSerializable(Serializable o) throws IOException{
                try{
                        ByteArrayOutputStream bos = new ByteArrayOutputStream();
                        ObjectOutputStream oos = new ObjectOutputStream(bos);
                        oos.writeObject(o);
                        return true;
                }catch(NotSerializableException e){
                        e.printStackTrace();
                        return false;
                }
        }

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

    [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773925#action_12773925 ]

Joey Surls edited comment on LUCENE-2032 at 11/5/09 1:28 PM:
-------------------------------------------------------------

CartesianShapeFilter also uses the non-Serializable class Shape

I think all that is needed is to add Serializable to Shape

The following code can be used to verify any other embedded classes not serialized:

{code:title=Test.java|borderStyle=solid}
private static boolean isSerializable(Serializable o) throws IOException{
                try{
                        ByteArrayOutputStream bos = new ByteArrayOutputStream();
                        ObjectOutputStream oos = new ObjectOutputStream(bos);
                        oos.writeObject(o);
                        return true;
                }catch(NotSerializableException e){
                        e.printStackTrace();
                        return false;
                }
        }
{code}

      was (Author: jsurls):
    CartesianShapeFilter also uses the non-Serializable class Shape

I think all that is needed is to add Serializable to Shape

The following code can be used to verify any other embedded classes not serialized:

private static boolean isSerializable(Serializable o) throws IOException{
                try{
                        ByteArrayOutputStream bos = new ByteArrayOutputStream();
                        ObjectOutputStream oos = new ObjectOutputStream(bos);
                        oos.writeObject(o);
                        return true;
                }catch(NotSerializableException e){
                        e.printStackTrace();
                        return false;
                }
        }
 

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

     [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer reassigned LUCENE-2032:
---------------------------------------

    Assignee: Simon Willnauer  (was: Uwe Schindler)

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Simon Willnauer
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

     [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2032:
------------------------------------

    Attachment: LUCENE-2032.txt

I made Shape serializable and cleaned up the code in CartensianShapeFilter slightly. The patch removes the logging code too as we do not have logging code elsewhere. I'm not keen to write a readObject method just for the sake of creating the logging object as it is not serializable.
The patch contains a testcase for serializable too.

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Simon Willnauer
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch, LUCENE-2032.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

    [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773984#action_12773984 ]

Uwe Schindler commented on LUCENE-2032:
---------------------------------------

The trick is to make the logging object "static final", because it is not needed per instance. See my patch from yesterday.

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Simon Willnauer
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch, LUCENE-2032.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

    [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773995#action_12773995 ]

Simon Willnauer commented on LUCENE-2032:
-----------------------------------------

bq. The trick is to make the logging object "static final", because it is not needed per instance. See my patch from yesterday.

I actually remove that on purpose. There is no other logging code outside of spatial and I guess consistency should go first in that case. Especially for logging it would make sense to have it static and final even if it is not serialized.

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Simon Willnauer
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch, LUCENE-2032.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

     [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2032:
------------------------------------

    Priority: Minor  (was: Major)

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch, LUCENE-2032.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

     [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2032:
------------------------------------

    Attachment: LUCENE-2032.txt

I removed the last logging reference from CartesianPolyFilterBuilder...

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch, LUCENE-2032.txt, LUCENE-2032.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...

     [ https://issues.apache.org/jira/browse/LUCENE-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer closed LUCENE-2032.
-----------------------------------

    Resolution: Fixed

commited in revision 833122

> Spatial Filters not Serializable
> --------------------------------
>
>                 Key: LUCENE-2032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2032
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LUCENE-2032.patch, LUCENE-2032.txt, LUCENE-2032.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I am using Lucene in a distributed setup.
> The Filters in the spatial project aren't Serializable even though it inherits it from Filter. Filter is a Serializable class.
> DistanceFilter contains the non-Serializable class WeakHashMap.
> CartesianShapeFilter contains the non-Serializable class java.util.logging.Logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@...
For additional commands, e-mail: java-dev-help@...