[jira] Created: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support

View: New views
8 Messages — Rating Filter:   Alert me  

[jira] Created: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Facet Generation generates duplicate entries - breaks RAD/RSA support
---------------------------------------------------------------------

                 Key: MECLIPSE-449
                 URL: http://jira.codehaus.org/browse/MECLIPSE-449
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
          Components: WTP support
    Affects Versions: 2.5.1
         Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
            Reporter: Chris Graham


Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.

Take this section of the POM:

<additionalProjectFacets>
    <jst.java>5.0</jst.java>
    <jst.ejb>2.1</jst.ejb>
    <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
</additionalProjectFacets>

Generates this:

<faceted-project>
  <fixed facet="jst.java"/>
  <fixed facet="jst.utility"/>
  <installed facet="jst.utility" version="1.0"/>
  <installed facet="jst.java" version="5.0"/>
  <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
  <installed facet="jst.ejb" version="2.1"/>
  <installed facet="jst.java" version="5.0"/>
</faceted-project>

You'll see that the jst.java facet is in there twice.

Removing the facet from the list:

<additionalProjectFacets>
    <jst.ejb>2.1</jst.ejb>
    <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
</additionalProjectFacets>

Generates this:

<faceted-project>
  <fixed facet="jst.java"/>
  <fixed facet="jst.utility"/>
  <installed facet="jst.utility" version="1.0"/>
  <installed facet="jst.java" version="5.0"/>
  <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
  <installed facet="jst.ejb" version="2.1"/>
</faceted-project>

Which is a little more correct.

I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.

Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:

<?xml version="1.0" encoding="UTF-8"?>

Also, where does the jst.utility facet come from?

It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).

This is the complete RSA generated one, for reference:

<?xml version="1.0" encoding="UTF-8"?>
<faceted-project>
  <runtime name="WebSphere Application Server v6.1"/>
  <fixed facet="jst.ejb"/>
  <fixed facet="jst.java"/>
  <installed facet="jst.ejb" version="2.1"/>
  <installed facet="jst.java" version="5.0"/>
  <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
</faceted-project>

(Which raises another question, how do we specify the runtime items and if something is fixed or not?)

However, to get it to be correctly recognised, all we need is this:

<faceted-project>
  <fixed facet="jst.java"/>
  <installed facet="jst.java" version="5.0"/>
  <installed facet="jst.ejb" version="2.1"/>
  <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
</faceted-project>


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MECLIPSE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=134876#action_134876 ]

Chris Graham commented on MECLIPSE-449:
---------------------------------------

As a follow up, RSA V7 reports an error when editing the facets that:

EJB Module 2.1 and Utility Module 1.0 cannot both be selected.


> Facet Generation generates duplicate entries - breaks RAD/RSA support
> ---------------------------------------------------------------------
>
>                 Key: MECLIPSE-449
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-449
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
>            Reporter: Chris Graham
>
> Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.
> Take this section of the POM:
> <additionalProjectFacets>
>     <jst.java>5.0</jst.java>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
> </faceted-project>
> You'll see that the jst.java facet is in there twice.
> Removing the facet from the list:
> <additionalProjectFacets>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
> </faceted-project>
> Which is a little more correct.
> I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.
> Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:
> <?xml version="1.0" encoding="UTF-8"?>
> Also, where does the jst.utility facet come from?
> It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).
> This is the complete RSA generated one, for reference:
> <?xml version="1.0" encoding="UTF-8"?>
> <faceted-project>
>   <runtime name="WebSphere Application Server v6.1"/>
>   <fixed facet="jst.ejb"/>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
> (Which raises another question, how do we specify the runtime items and if something is fixed or not?)
> However, to get it to be correctly recognised, all we need is this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MECLIPSE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=135340#action_135340 ]

Chris Graham commented on MECLIPSE-449:
---------------------------------------

As a further follow up:

The pom of this project (which is an EJB project) had a packaging of type: JAR, not EJB.

Once that was done, the generated facet settings files was:

<faceted-project>
  <fixed facet="jst.java"/>
  <fixed facet="jst.ejb"/>
  <installed facet="jst.ejb" version="2.1"/>
  <installed facet="jst.java" version="5.0"/>
  <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
</faceted-project>

Which removes my concerns about the utility project.

This is the build section from the pom is now:

    <build>
        <plugins>
            <plugin>
                <artifactId>maven-eclipse-plugin</artifactId>
                <configuration>
                    <wtpversion>1.5</wtpversion>

                    <additionalBuildcommands>
                        <buildcommand>org.eclipse.wst.validation.validationbuilder</buildcommand>
                        <buildcommand>org.eclipse.wst.common.project.facet.core.builder</buildcommand>
                    </additionalBuildcommands>

                    <additionalProjectnatures>
                        <projectnature>org.eclipse.wst.common.project.facet.core.nature</projectnature>
                        <projectnature>org.eclipse.wst.common.modulecore.ModuleCoreNature</projectnature>
                    </additionalProjectnatures>

                    <classpathContainers>
                        <classpathContainer>org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/WebSphere v6.1 JRE</classpathContainer>
                        <classpathContainer>org.eclipse.jst.server.core.container/com.ibm.ws.ast.st.runtime.runtimeTarget.v61/was.base.v61</classpathContainer>
                        <classpathContainer>org.eclipse.jst.j2ee.internal.module.container</classpathContainer>
                    </classpathContainers>

                    <additionalProjectFacets>
                        <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
                    </additionalProjectFacets>

                </configuration>
            </plugin>
        </plugins>
    </build>



> Facet Generation generates duplicate entries - breaks RAD/RSA support
> ---------------------------------------------------------------------
>
>                 Key: MECLIPSE-449
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-449
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
>            Reporter: Chris Graham
>
> Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.
> Take this section of the POM:
> <additionalProjectFacets>
>     <jst.java>5.0</jst.java>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
> </faceted-project>
> You'll see that the jst.java facet is in there twice.
> Removing the facet from the list:
> <additionalProjectFacets>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
> </faceted-project>
> Which is a little more correct.
> I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.
> Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:
> <?xml version="1.0" encoding="UTF-8"?>
> Also, where does the jst.utility facet come from?
> It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).
> This is the complete RSA generated one, for reference:
> <?xml version="1.0" encoding="UTF-8"?>
> <faceted-project>
>   <runtime name="WebSphere Application Server v6.1"/>
>   <fixed facet="jst.ejb"/>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
> (Which raises another question, how do we specify the runtime items and if something is fixed or not?)
> However, to get it to be correctly recognised, all we need is this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MECLIPSE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=149516#action_149516 ]

Alessandro Zucchi commented on MECLIPSE-449:
--------------------------------------------

The problem is not localized only on IBM RSA V7.0.0.6.
Also  Eclipse 3.3 / 3.4 duplicate entry using  <additionalProjectFacets>.
For me:

<additionalProjectFacets>
                  <jst.web>2.3</jst.web>
 </additionalProjectFacets>

give the following result:

<faceted-project>
  <fixed facet="jst.java"/>
  <fixed facet="jst.web"/>
  <installed facet="jst.web" version="2.4"/>
  <installed facet="jst.java" version="5.0"/>
  <installed facet="jst.web" version="2.3"/>
</faceted-project>

Regards
Ale.


> Facet Generation generates duplicate entries - breaks RAD/RSA support
> ---------------------------------------------------------------------
>
>                 Key: MECLIPSE-449
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-449
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
>            Reporter: Chris Graham
>
> Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.
> Take this section of the POM:
> <additionalProjectFacets>
>     <jst.java>5.0</jst.java>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
> </faceted-project>
> You'll see that the jst.java facet is in there twice.
> Removing the facet from the list:
> <additionalProjectFacets>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
> </faceted-project>
> Which is a little more correct.
> I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.
> Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:
> <?xml version="1.0" encoding="UTF-8"?>
> Also, where does the jst.utility facet come from?
> It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).
> This is the complete RSA generated one, for reference:
> <?xml version="1.0" encoding="UTF-8"?>
> <faceted-project>
>   <runtime name="WebSphere Application Server v6.1"/>
>   <fixed facet="jst.ejb"/>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
> (Which raises another question, how do we specify the runtime items and if something is fixed or not?)
> However, to get it to be correctly recognised, all we need is this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Commented: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MECLIPSE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=185846#action_185846 ]

Florian Probst commented on MECLIPSE-449:
-----------------------------------------

I have the same issue when creating a new web module. Adding "jst.jsf" in version 1.2 automatically adds "jst.web" in version 2.4 what is not supported by Eclipse. When i include "jst.web" in correct version 2.5 it looks like:

                                <configuration>
                                        <additionalProjectFacets>
                                                <jst.jsf>1.2</jst.jsf>
                                                <jst.web>2.5</jst.web>
                                        </additionalProjectFacets>
                                        <wtpversion>2.0</wtpversion>
                                </configuration>

The result is a duplicated entry of "jst.web" in both versions 2.4 AND 2.5. It works for me, deleting the 2.4 entry out of the file.
Affects current version 2.7.

> Facet Generation generates duplicate entries - breaks RAD/RSA support
> ---------------------------------------------------------------------
>
>                 Key: MECLIPSE-449
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-449
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
>            Reporter: Chris Graham
>
> Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.
> Take this section of the POM:
> <additionalProjectFacets>
>     <jst.java>5.0</jst.java>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
> </faceted-project>
> You'll see that the jst.java facet is in there twice.
> Removing the facet from the list:
> <additionalProjectFacets>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
> </faceted-project>
> Which is a little more correct.
> I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.
> Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:
> <?xml version="1.0" encoding="UTF-8"?>
> Also, where does the jst.utility facet come from?
> It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).
> This is the complete RSA generated one, for reference:
> <?xml version="1.0" encoding="UTF-8"?>
> <faceted-project>
>   <runtime name="WebSphere Application Server v6.1"/>
>   <fixed facet="jst.ejb"/>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
> (Which raises another question, how do we specify the runtime items and if something is fixed or not?)
> However, to get it to be correctly recognised, all we need is this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Updated: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ http://jira.codehaus.org/browse/MECLIPSE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arnaud Heritier updated MECLIPSE-449:
-------------------------------------

    Fix Version/s: 2.8

> Facet Generation generates duplicate entries - breaks RAD/RSA support
> ---------------------------------------------------------------------
>
>                 Key: MECLIPSE-449
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-449
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
>            Reporter: Chris Graham
>             Fix For: 2.8
>
>
> Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.
> Take this section of the POM:
> <additionalProjectFacets>
>     <jst.java>5.0</jst.java>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
> </faceted-project>
> You'll see that the jst.java facet is in there twice.
> Removing the facet from the list:
> <additionalProjectFacets>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
> </faceted-project>
> Which is a little more correct.
> I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.
> Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:
> <?xml version="1.0" encoding="UTF-8"?>
> Also, where does the jst.utility facet come from?
> It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).
> This is the complete RSA generated one, for reference:
> <?xml version="1.0" encoding="UTF-8"?>
> <faceted-project>
>   <runtime name="WebSphere Application Server v6.1"/>
>   <fixed facet="jst.ejb"/>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
> (Which raises another question, how do we specify the runtime items and if something is fixed or not?)
> However, to get it to be correctly recognised, all we need is this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Updated: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ http://jira.codehaus.org/browse/MECLIPSE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Rohe updated MECLIPSE-449:
---------------------------------

    Attachment: MECLIPSE-449.patch

This is a patch to this bug which checks whether the additional facets overwrite any of the hard-coded installed facets. Also the patch contains a test case which should show the replacement.

> Facet Generation generates duplicate entries - breaks RAD/RSA support
> ---------------------------------------------------------------------
>
>                 Key: MECLIPSE-449
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-449
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
>            Reporter: Chris Graham
>             Fix For: 2.8
>
>         Attachments: MECLIPSE-449.patch
>
>
> Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.
> Take this section of the POM:
> <additionalProjectFacets>
>     <jst.java>5.0</jst.java>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
> </faceted-project>
> You'll see that the jst.java facet is in there twice.
> Removing the facet from the list:
> <additionalProjectFacets>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
> </faceted-project>
> Which is a little more correct.
> I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.
> Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:
> <?xml version="1.0" encoding="UTF-8"?>
> Also, where does the jst.utility facet come from?
> It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).
> This is the complete RSA generated one, for reference:
> <?xml version="1.0" encoding="UTF-8"?>
> <faceted-project>
>   <runtime name="WebSphere Application Server v6.1"/>
>   <fixed facet="jst.ejb"/>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
> (Which raises another question, how do we specify the runtime items and if something is fixed or not?)
> However, to get it to be correctly recognised, all we need is this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Commented: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MECLIPSE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196952#action_196952 ]

Daniel Rohe commented on MECLIPSE-449:
--------------------------------------

The cause of this bug is the creation of the facet file for WTP 1.5 and above. This file contains entries for fixed facets, the server runtime and installed facets of a project. The fixed facets depend on the project type and can easily be added during the creation. For the installed facets the handling currently uses the dependencies and looks for the servlet-api to determine the version of the jst.web facet. So one solution is to add the dependency javax.servlet:servlet-api:2.x to the pom and it works or e.g. use the patch and override the installed facets using the additional facets configuration element.

There is still a bug when working with RAD because the extended and coexistence facets are only added to ear-projects but also need to be added to war-projects and the handling of the server runtime is somewhat buggy.

> Facet Generation generates duplicate entries - breaks RAD/RSA support
> ---------------------------------------------------------------------
>
>                 Key: MECLIPSE-449
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-449
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
>            Reporter: Chris Graham
>             Fix For: 2.8
>
>         Attachments: MECLIPSE-449.patch
>
>
> Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.
> Take this section of the POM:
> <additionalProjectFacets>
>     <jst.java>5.0</jst.java>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
> </faceted-project>
> You'll see that the jst.java facet is in there twice.
> Removing the facet from the list:
> <additionalProjectFacets>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
> </faceted-project>
> Which is a little more correct.
> I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.
> Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:
> <?xml version="1.0" encoding="UTF-8"?>
> Also, where does the jst.utility facet come from?
> It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).
> This is the complete RSA generated one, for reference:
> <?xml version="1.0" encoding="UTF-8"?>
> <faceted-project>
>   <runtime name="WebSphere Application Server v6.1"/>
>   <fixed facet="jst.ejb"/>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
> (Which raises another question, how do we specify the runtime items and if something is fixed or not?)
> However, to get it to be correctly recognised, all we need is this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira