[jira] Created: (MGWT-133) GenerateAsync: generateDirectory not added to classpath when async files are not regenerated

GenerateAsync: generateDirectory not added to classpath when async files are not regenerated
--------------------------------------------------------------------------------------------

                 Key: MGWT-133
                 URL: http://jira.codehaus.org/browse/MGWT-133
             Project: Maven 2.x GWT Plugin
          Issue Type: Bug
    Affects Versions: 1.2
         Environment: Ubuntu Karmic 9.10 - Eclipse 3.5 - GWT 2.0.0-MS1
            Reporter: Christophe Bouthier


Use case: using "GenerateAsync" goal, without specifying generateDirectory (thus using default target/generated-sources/gwt).
- First time (or after a clean), doing a mvn package generate the async interfaces, and add 'target/generated-sources/gwt' to the classpath => no error when doing the package.
- Second time, the async interfaces are already generated (and up-to-date), thus the goal do NOT generate new async files, and thus the generateDirectory is NOT added to the classpath => build failed, the async interfaces are not found.

This is due to line 130 of file org.codehaus.mojo.gwt.GenerateAsyncMojo:
{quote}
if ( generated )     // <= HERE
{
  getLog().debug( "add compile source root " + getGenerateDirectory() );
  addCompileSourceRoot( getGenerateDirectory() );
}
{quote}

if the files are up-to-date (line 159), scanAndGenerateAsync return false, and the generateDirectory directory is NOT added to the classpath.


It would be better to ALWAYS add the generateDirectory to the classpath, so that the build would not fail even when launched a second time WITHOUT a clean (Yes, I DON'T want to do a clean each time for obvious performances reasons).

Thanks a lot.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/MGWT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197054#action_197054 ]

Christophe Bouthier commented on MGWT-133:
------------------------------------------

Maybe the bug MGWT-26 (http://jira.codehaus.org/browse/MGWT-26), which has been closed as non-reproductible, was in fact linked to a similar use-case ?

> GenerateAsync: generateDirectory not added to classpath when async files are not regenerated
> --------------------------------------------------------------------------------------------
>
>                 Key: MGWT-133
>                 URL: http://jira.codehaus.org/browse/MGWT-133
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Bug
>    Affects Versions: 1.2
>         Environment: Ubuntu Karmic 9.10 - Eclipse 3.5 - GWT 2.0.0-MS1
>            Reporter: Christophe Bouthier
>
> Use case: using "GenerateAsync" goal, without specifying generateDirectory (thus using default target/generated-sources/gwt).
> - First time (or after a clean), doing a mvn package generate the async interfaces, and add 'target/generated-sources/gwt' to the classpath => no error when doing the package.
> - Second time, the async interfaces are already generated (and up-to-date), thus the goal do NOT generate new async files, and thus the generateDirectory is NOT added to the classpath => build failed, the async interfaces are not found.
> This is due to line 130 of file org.codehaus.mojo.gwt.GenerateAsyncMojo:
> {quote}
> if ( generated )     // <= HERE
> {
>   getLog().debug( "add compile source root " + getGenerateDirectory() );
>   addCompileSourceRoot( getGenerateDirectory() );
> }
> {quote}
> if the files are up-to-date (line 159), scanAndGenerateAsync return false, and the generateDirectory directory is NOT added to the classpath.
> It would be better to ALWAYS add the generateDirectory to the classpath, so that the build would not fail even when launched a second time WITHOUT a clean (Yes, I DON'T want to do a clean each time for obvious performances reasons).
> Thanks a lot.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/MGWT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas de loof closed MGWT-133.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2
         Assignee: nicolas de loof

Committed revision 11298.

> GenerateAsync: generateDirectory not added to classpath when async files are not regenerated
> --------------------------------------------------------------------------------------------
>
>                 Key: MGWT-133
>                 URL: http://jira.codehaus.org/browse/MGWT-133
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Bug
>    Affects Versions: 1.2
>         Environment: Ubuntu Karmic 9.10 - Eclipse 3.5 - GWT 2.0.0-MS1
>            Reporter: Christophe Bouthier
>            Assignee: nicolas de loof
>             Fix For: 1.2
>
>
> Use case: using "GenerateAsync" goal, without specifying generateDirectory (thus using default target/generated-sources/gwt).
> - First time (or after a clean), doing a mvn package generate the async interfaces, and add 'target/generated-sources/gwt' to the classpath => no error when doing the package.
> - Second time, the async interfaces are already generated (and up-to-date), thus the goal do NOT generate new async files, and thus the generateDirectory is NOT added to the classpath => build failed, the async interfaces are not found.
> This is due to line 130 of file org.codehaus.mojo.gwt.GenerateAsyncMojo:
> {quote}
> if ( generated )     // <= HERE
> {
>   getLog().debug( "add compile source root " + getGenerateDirectory() );
>   addCompileSourceRoot( getGenerateDirectory() );
> }
> {quote}
> if the files are up-to-date (line 159), scanAndGenerateAsync return false, and the generateDirectory directory is NOT added to the classpath.
> It would be better to ALWAYS add the generateDirectory to the classpath, so that the build would not fail even when launched a second time WITHOUT a clean (Yes, I DON'T want to do a clean each time for obvious performances reasons).
> Thanks a lot.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email