[jira] Created: (MODELLO-222) java5 associations do not respect java.useInterface

java5 associations do not respect java.useInterface
---------------------------------------------------

                 Key: MODELLO-222
                 URL: http://jira.codehaus.org/browse/MODELLO-222
             Project: Modello
          Issue Type: Bug
          Components: modello-plugin-java
    Affects Versions: 1.1
            Reporter: Igor Fedorenko


Modello does not consistently use  java.useInterface when generating getter/setter methods for association fields, which becomes more apparent in java5 mode. For example, the following association

{code:xml}
        <field>
          <name>entries</name>
          <association java.useInterface="IEntry">
            <type>Entry</type>
            <multiplicity>*</multiplicity>
          </association>
        </field>
{code}

will result in the following method signatures in java5 mode

{code:java}
public void addEntry( IEntry entry )
public java.util.List<Entry> getEntries()
public void removeEntry( IEntry entry )
public void setEntries( java.util.List<Entry> entries )
{code}

Note incorrect type parameter {{java.util.List<Entry>}} instead of expected {{java.util.List<IEntry>}}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/MODELLO-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Fedorenko updated MODELLO-222:
-----------------------------------

    Attachment: MODELLO-222.diff

Attached patch MODELLO-222.diff addresses the problem at least partially. More specifically,

* only simple one-to-many association was tested and other associations likely still have this problem
* association default value is ignored, which may or may not be a problem
* generation of clone method was not tested and may or may not have this problem

Unfortunately, I do not know about modello enough to assess whether these are real problems and would appreciate if somebody with the knowledge reviewed the code and provided feedback. Thank you in advance.

> java5 associations do not respect java.useInterface
> ---------------------------------------------------
>
>                 Key: MODELLO-222
>                 URL: http://jira.codehaus.org/browse/MODELLO-222
>             Project: Modello
>          Issue Type: Bug
>          Components: modello-plugin-java
>    Affects Versions: 1.1
>            Reporter: Igor Fedorenko
>         Attachments: MODELLO-222.diff
>
>
> Modello does not consistently use  java.useInterface when generating getter/setter methods for association fields, which becomes more apparent in java5 mode. For example, the following association
> {code:xml}
>         <field>
>           <name>entries</name>
>           <association java.useInterface="IEntry">
>             <type>Entry</type>
>             <multiplicity>*</multiplicity>
>           </association>
>         </field>
> {code}
> will result in the following method signatures in java5 mode
> {code:java}
> public void addEntry( IEntry entry )
> public java.util.List<Entry> getEntries()
> public void removeEntry( IEntry entry )
> public void setEntries( java.util.List<Entry> entries )
> {code}
> Note incorrect type parameter {{java.util.List<Entry>}} instead of expected {{java.util.List<IEntry>}}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/MODELLO-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194101#action_194101 ]

Igor Fedorenko commented on MODELLO-222:
----------------------------------------

I committed the patch. Let me know if there are any concerns.

> java5 associations do not respect java.useInterface
> ---------------------------------------------------
>
>                 Key: MODELLO-222
>                 URL: http://jira.codehaus.org/browse/MODELLO-222
>             Project: Modello
>          Issue Type: Bug
>          Components: modello-plugin-java
>    Affects Versions: 1.1
>            Reporter: Igor Fedorenko
>         Attachments: MODELLO-222.diff
>
>
> Modello does not consistently use  java.useInterface when generating getter/setter methods for association fields, which becomes more apparent in java5 mode. For example, the following association
> {code:xml}
>         <field>
>           <name>entries</name>
>           <association java.useInterface="IEntry">
>             <type>Entry</type>
>             <multiplicity>*</multiplicity>
>           </association>
>         </field>
> {code}
> will result in the following method signatures in java5 mode
> {code:java}
> public void addEntry( IEntry entry )
> public java.util.List<Entry> getEntries()
> public void removeEntry( IEntry entry )
> public void setEntries( java.util.List<Entry> entries )
> {code}
> Note incorrect type parameter {{java.util.List<Entry>}} instead of expected {{java.util.List<IEntry>}}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/MODELLO-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Herve Boutemy closed MODELLO-222.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2
         Assignee: Igor Fedorenko

> java5 associations do not respect java.useInterface
> ---------------------------------------------------
>
>                 Key: MODELLO-222
>                 URL: http://jira.codehaus.org/browse/MODELLO-222
>             Project: Modello
>          Issue Type: Bug
>          Components: modello-plugin-java
>    Affects Versions: 1.1
>            Reporter: Igor Fedorenko
>            Assignee: Igor Fedorenko
>             Fix For: 1.2
>
>         Attachments: MODELLO-222.diff
>
>
> Modello does not consistently use  java.useInterface when generating getter/setter methods for association fields, which becomes more apparent in java5 mode. For example, the following association
> {code:xml}
>         <field>
>           <name>entries</name>
>           <association java.useInterface="IEntry">
>             <type>Entry</type>
>             <multiplicity>*</multiplicity>
>           </association>
>         </field>
> {code}
> will result in the following method signatures in java5 mode
> {code:java}
> public void addEntry( IEntry entry )
> public java.util.List<Entry> getEntries()
> public void removeEntry( IEntry entry )
> public void setEntries( java.util.List<Entry> entries )
> {code}
> Note incorrect type parameter {{java.util.List<Entry>}} instead of expected {{java.util.List<IEntry>}}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/MODELLO-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194959#action_194959 ]

Herve Boutemy commented on MODELLO-222:
---------------------------------------

just added a test to confirm that one multiplicity association fails
didn't try clone method

I'm still closing this issue since the actual behaviour is better than before, even if not completely feature complete: work on other will be done later when somebody needs it

thank you Igor

> java5 associations do not respect java.useInterface
> ---------------------------------------------------
>
>                 Key: MODELLO-222
>                 URL: http://jira.codehaus.org/browse/MODELLO-222
>             Project: Modello
>          Issue Type: Bug
>          Components: modello-plugin-java
>    Affects Versions: 1.1
>            Reporter: Igor Fedorenko
>            Assignee: Igor Fedorenko
>             Fix For: 1.2
>
>         Attachments: MODELLO-222.diff
>
>
> Modello does not consistently use  java.useInterface when generating getter/setter methods for association fields, which becomes more apparent in java5 mode. For example, the following association
> {code:xml}
>         <field>
>           <name>entries</name>
>           <association java.useInterface="IEntry">
>             <type>Entry</type>
>             <multiplicity>*</multiplicity>
>           </association>
>         </field>
> {code}
> will result in the following method signatures in java5 mode
> {code:java}
> public void addEntry( IEntry entry )
> public java.util.List<Entry> getEntries()
> public void removeEntry( IEntry entry )
> public void setEntries( java.util.List<Entry> entries )
> {code}
> Note incorrect type parameter {{java.util.List<Entry>}} instead of expected {{java.util.List<IEntry>}}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/MODELLO-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194960#action_194960 ]

Herve Boutemy commented on MODELLO-222:
---------------------------------------

while thinking at it, one other part that is not tested: createTypeAssociation() and breakTypeAssociation() (see java.bidi)
not so frequently used, os like my previous comment "work will be done later when somebody needs it"

> java5 associations do not respect java.useInterface
> ---------------------------------------------------
>
>                 Key: MODELLO-222
>                 URL: http://jira.codehaus.org/browse/MODELLO-222
>             Project: Modello
>          Issue Type: Bug
>          Components: modello-plugin-java
>    Affects Versions: 1.1
>            Reporter: Igor Fedorenko
>            Assignee: Igor Fedorenko
>             Fix For: 1.2
>
>         Attachments: MODELLO-222.diff
>
>
> Modello does not consistently use  java.useInterface when generating getter/setter methods for association fields, which becomes more apparent in java5 mode. For example, the following association
> {code:xml}
>         <field>
>           <name>entries</name>
>           <association java.useInterface="IEntry">
>             <type>Entry</type>
>             <multiplicity>*</multiplicity>
>           </association>
>         </field>
> {code}
> will result in the following method signatures in java5 mode
> {code:java}
> public void addEntry( IEntry entry )
> public java.util.List<Entry> getEntries()
> public void removeEntry( IEntry entry )
> public void setEntries( java.util.List<Entry> entries )
> {code}
> Note incorrect type parameter {{java.util.List<Entry>}} instead of expected {{java.util.List<IEntry>}}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email