|
View:
New views
15 Messages
—
Rating Filter:
Alert me
|
|
|
[jira] Created: (MOJO-1383) Clear buildroot before copying files into folderClear buildroot before copying files into folder
------------------------------------------------ Key: MOJO-1383 URL: http://jira.codehaus.org/browse/MOJO-1383 Project: Mojo Issue Type: Bug Components: rpm Reporter: Josh McFarlane When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Updated: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McFarlane updated MOJO-1383: --------------------------------- Attachment: MOJO-1383.patch Attached a patch to fix this issue. > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Assigned: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Okken reassigned MOJO-1383: --------------------------------- Assignee: Brett Okken > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180286#action_180286 ] Brett Okken commented on MOJO-1383: ----------------------------------- Are you doing multiple executions by using the attached-rpm goal with different classifiers? > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180324#action_180324 ] Josh McFarlane commented on MOJO-1383: -------------------------------------- Yes, just the rpm goal (to produce rpms as a side effect) I was trying to do it like: <executions> <execution> <id>one</id> <goals> <goal>rpm</goal> </goals> <configuration>...</configuration> </execution> <execution> <id>two</id> <goals> <goal>rpm</goal> </goals> <configuration>...</configuration> </execution> <executions> But, the second would fail due to having the artifact from the first's (in a different installation location) still in the buildroot. > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180326#action_180326 ] Brett Okken commented on MOJO-1383: ----------------------------------- Unless I am missing something, simply deleting the build root will not allow this usage to work. Won't the rpm be overlayed? > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180364#action_180364 ] Josh McFarlane commented on MOJO-1383: -------------------------------------- Ok, for a quick reproduction, use the sample maven project: mvn archetype:create \ -DarchetypeGroupId=org.apache.maven.archetypes \ -DgroupId=com.mycompany.app \ -DartifactId=my-app Then modify the pom.xml to include the following in the build section: <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>rpm-maven-plugin</artifactId> <executions> <execution> <id>one</id> <goals> <goal>rpm</goal> </goals> <configuration> <name>my-app-a</name> <release>1</release> <group>foo</group> <copyright>foo</copyright> <prefix>/a</prefix> <mappings> <mapping> <directory>/a</directory> <artifact/> </mapping> </mappings> </configuration> </execution> <execution> <id>two</id> <goals> <goal>rpm</goal> </goals> <configuration> <name>my-app-b</name> <release>1</release> <group>foo</group> <copyright>foo</copyright> <prefix>/b</prefix> <mappings> <mapping> <directory>/b</directory> <artifact/> </mapping> </mappings> </configuration> </execution> </executions> </plugin> This should produce two separate RPMs. Is there something I'm overlooking? > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180401#action_180401 ] Brett Okken commented on MOJO-1383: ----------------------------------- You are correct, the usage of the <name> configuration will create 2 different rpms. What if, instead of deleting the buildroot, each execution had its own workarea? This would support both your use case and the case of having multiple executions using the attached-rpm goal. In this case simply deleting the buildroot may not be an option as multiple rpms with the same "name" (but different classifiers) could be created. In your example, the workarea would have 1 folder for each execution: my-app-a my-app-b The buildroot, SPECS and RPMS and other folders would be created below those folders. > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180463#action_180463 ] Josh McFarlane commented on MOJO-1383: -------------------------------------- The only downside to this solution is if you have an external process (such as Hudson) picking up the RPMs. Then, you have to modify the job based on the pom name's rather than just a single static output folder. Would it be possible to land the RPMs under a single output folder structure by keeping old rpm/RPMS folder? So, you'd have separate ares for my-app-a and my-app-b, but once my-app-a finished, it'd copy the contents of RPMS to the target/rpm/RPMS, and then my-app-b would do the same once it finished? Then you'd have separate build processes for each execution, but still one static path to get the side-effect generated rpms. > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180467#action_180467 ] Brett Okken commented on MOJO-1383: ----------------------------------- True. However, that could be mitigated by using the attached-rpm goal and telling your external process to pull the secondary artifacts (the rpms) from your maven repository. My concern is that I would like to have consistent behavior for all executions, regardless of goal (rpm vs. attached-rpm). While copying stuff around would be possible for different names, when using the attached-rpm goal, different names are not be required, and copying will not work. > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (MOJO-1383) Clear buildroot before copying files into folder[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180470#action_180470 ] Josh McFarlane commented on MOJO-1383: -------------------------------------- Ok, it looks like separate execution folders would be the way to go then. > Clear buildroot before copying files into folder > ------------------------------------------------ > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Updated: (MOJO-1383) Support multiple executions.[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Okken updated MOJO-1383: ------------------------------ Summary: Support multiple executions. (was: Clear buildroot before copying files into folder) > Support multiple executions. > ---------------------------- > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Commented: (MOJO-1383) Support multiple executions.[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180472#action_180472 ] Brett Okken commented on MOJO-1383: ----------------------------------- I have updated the summary of the defect to indicate that we need general support for multiple executions. > Support multiple executions. > ---------------------------- > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Closed: (MOJO-1383) Support multiple executions.[ http://jira.codehaus.org/browse/MOJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Okken closed MOJO-1383. ----------------------------- Resolution: Fixed resolved with 2.0-beta-3 > Support multiple executions. > ---------------------------- > > Key: MOJO-1383 > URL: http://jira.codehaus.org/browse/MOJO-1383 > Project: Mojo > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
|
[jira] Moved: (MRPM-2) Support multiple executions.[ http://jira.codehaus.org/browse/MRPM-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Okken moved MOJO-1383 to MRPM-2: -------------------------------------- Component/s: (was: rpm) rpm Complexity: (was: Intermediate) Key: MRPM-2 (was: MOJO-1383) Project: Mojo RPM Plugin (was: Mojo) > Support multiple executions. > ---------------------------- > > Key: MRPM-2 > URL: http://jira.codehaus.org/browse/MRPM-2 > Project: Mojo RPM Plugin > Issue Type: Bug > Components: rpm > Reporter: Josh McFarlane > Assignee: Brett Okken > Attachments: MOJO-1383.patch > > > When you have multiple executions, the plugin does not clean out the buildroot folder prior to copying anything in for executions. This means the first execution will run fine, but any executions after that will fail due to files that are in buildroot but not consumed by the current rpm spec. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
| Free embeddable forum powered by Nabble | Forum Help |