[jira] Created: (MRM-1246) MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.

MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
----------------------------------------------------------------------------------------------------

                 Key: MRM-1246
                 URL: http://jira.codehaus.org/browse/MRM-1246
             Project: Archiva
          Issue Type: Bug
    Affects Versions: 1.2.2
            Reporter: Gwen Harold Autencio


Steps to replicate

1. Deploy several test snapshots with
mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).

2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.

3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.

4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository

5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish

6. View the metadata file again.

Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file

Actual result: the metadata file still contains version 1.1-SNAPSHOT



--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=189848#action_189848 ]

Wendy Smoak commented on MRM-1246:
----------------------------------

When this happens, I notice that the deleted artifacts are still visible in search/browse, meaning they are still in the database.

I think it's less that the metadata update consumer didn't run, and more that Archiva didn't "see" the deletion at all, so there were no events for the various consumers to process.

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gwen Harold Autencio updated MRM-1246:
--------------------------------------

    Attachment: MRM-1246.patch

Hi, attaching patch.
Is this ok if it compares the lastModified of the file being scanned and the directory of the artifact containing.
Consumer will be run when directory of the artifact has the latest modification than the basefile.
Thanks.

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>         Attachments: MRM-1246.patch
>
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gwen Harold Autencio updated MRM-1246:
--------------------------------------

    Attachment: updated-MRM-1246.patch

Sorry, attaching an updated patch for issue. Thanks.

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>         Attachments: MRM-1246.patch, updated-MRM-1246.patch
>
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MRM-1246:
------------------------------

      Fix Version/s: 1.2.3
    Patch Submitted: [Yes]

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>             Fix For: 1.2.3
>
>         Attachments: MRM-1246.patch, updated-MRM-1246.patch
>
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jevica Arianne B. Zurbano reassigned MRM-1246:
----------------------------------------------

    Assignee: Jevica Arianne B. Zurbano

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>            Assignee: Jevica Arianne B. Zurbano
>             Fix For: 1.2.3
>
>         Attachments: MRM-1246.patch, updated-MRM-1246.patch
>
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jevica Arianne B. Zurbano closed MRM-1246.
------------------------------------------

    Resolution: Fixed

Fixed in r824220.
- added unit test for updating metadata      
- added unit test sample artifacts
- applied the patch

Thanks Gwen! :)

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>            Assignee: Jevica Arianne B. Zurbano
>             Fix For: 1.2.3
>
>         Attachments: MRM-1246.patch, updated-MRM-1246.patch
>
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter reopened MRM-1246:
-------------------------------

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>            Assignee: Jevica Arianne B. Zurbano
>             Fix For: 1.2.3
>
>         Attachments: MRM-1246.patch, updated-MRM-1246.patch
>
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194818#action_194818 ]

Brett Porter commented on MRM-1246:
-----------------------------------

this was reverted as about 30% of the artifacts were being processed on every scan.

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>            Assignee: Jevica Arianne B. Zurbano
>             Fix For: 1.2.3
>
>         Attachments: MRM-1246.patch, updated-MRM-1246.patch
>
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196225#action_196225 ]

Yanke commented on MRM-1246:
----------------------------

in case somebody searches for a workaround:

we had the same problem but with Archiva 1.2.2 we have been able to remove it using the "Delete Artifact" menu.

Not as efficient as automatic updating the DB, but at least the wrong version was gone.

I haven't tested if "Delete Artifact" would delete an artifact from DB also if it does not exist on the repository (I have manually added it before deleting)

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>            Assignee: Jevica Arianne B. Zurbano
>             Fix For: 1.2.3
>
>         Attachments: MRM-1246.patch, updated-MRM-1246.patch
>
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ http://jira.codehaus.org/browse/MRM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jevica Arianne B. Zurbano closed MRM-1246.
------------------------------------------

    Resolution: Fixed

Thanks Yanke for the workaround. :)

The fix for MRM-1056 (Option to force scanning of an artifact/repository regardless of file dates) also fixes this issue.

> MetadataUpdaterConsumer didn't run during a repository scan after deleting a version of an artifact.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MRM-1246
>                 URL: http://jira.codehaus.org/browse/MRM-1246
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gwen Harold Autencio
>            Assignee: Jevica Arianne B. Zurbano
>             Fix For: 1.2.3
>
>         Attachments: MRM-1246.patch, updated-MRM-1246.patch
>
>
> Steps to replicate
> 1. Deploy several test snapshots with
> mvn deploy:deploy-file -Dfile=test.jar -DgroupId=com.example.test -DartifactId=test -Dversion=2.0-SNAPSHOT -Durl=file:///home/gwen/repository/snapshots -Dpackaging=jar
> and repeat several times for version 1.0, 1.1 (results in timestamped snapshots).
> 2. Open /home/gwen/repository/snapshots/com/example/test/test/maven-metadata.xml. All version can be seen.
> 3. Scan the repository and update the database. Confirm that the artifacts are all visible through the browse url.
> 4. Delete the com/example/test/test/1.1-SNAPSHOT directory from the repository
> 5. Click "Scan repository now" for the Snapshots repository and wait for the scan to finish
> 6. View the metadata file again.
> Expected result: version 1.1-SNAPSHOT is not in the maven-metadata.xml file
> Actual result: the metadata file still contains version 1.1-SNAPSHOT

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira