[jira] Created: (MRPM-51) Add support for the -f option in the %files section of the rpm spec

Add support for the -f option in the %files section of the rpm spec
-------------------------------------------------------------------

                 Key: MRPM-51
                 URL: http://jira.codehaus.org/browse/MRPM-51
             Project: Mojo RPM Plugin
          Issue Type: New Feature
          Components: rpm
         Environment: Red hat Linux
            Reporter: Dudley Fox
            Assignee: Brett Okken


We have a.rpm and b.rpm. And we have user_a and user_b.
We install a.rpm as user_a, and then b.rpm as user_b. The installation
of b.rpm fails, because it does not have permission to overwrite the
file Sha1header (part of the rpm database), which is created when you
have files under your %files section.
 
We know we can fix this if we use something like: %files -f $PWD/$Name.list

At this point, it looks as if we will need to add this functionality ourselves, as soon
as we have the patch (or more details) I will add them to this issue.


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/MRPM-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=198269#action_198269 ]

Dudley Fox commented on MRPM-51:
--------------------------------

Here is the diff of the changes needed to support this:
This is for the file AbstractRPMMojo.java

687a696,699
>     private boolean separateFileList;
>    
>     // // // Mojo methods
>
1495a1508
>         File listf = separateFileList ? new File( f, name + ".list" ) : specf;
1499a1513
>             PrintWriter list = ( listf == specf ) ? spec : new PrintWriter( new FileWriter( listf ) );
1683,1684c1697,1699
<             spec.println( "%files" );
<             spec.println( getDefAttrString() );            
---
>             String opening = ( list == spec ) ? "%files" : ( "%files -f " + listf.getAbsolutePath() );
>             spec.println( opening );
>             list.println( getDefAttrString() );            
1702,1704c1717,1719
<                     spec.print( attributes );
<                     spec.print( ' ' );
<                     spec.println( destination );
---
>                     list.print( attributes );
>                     list.print( ' ' );
>                     list.println( destination );
1726c1741
<                     spec.println( attrString + " " + destination );
---
>                     list.println( attrString + " " + destination );
1738,1739c1753,1754
<                         spec.print( baseFileString );
<                         spec.println( files[i] );
---
>                         list.print( baseFileString );
>                         list.println( files[i] );
1747,1748c1762,1763
<                         spec.print( baseFileString );
<                         spec.println( link );
---
>                         list.print( baseFileString );
>                         list.println( link );
1765a1781,1783
>             if ( list != spec ) {
>                 list.close();
>             }
1768a1787
>             if ( listf == specf ) {
1769a1789,1791
>             } else {
>                 throw new MojoExecutionException( "Unable to write " + specf.getAbsolutePath() + " or " +  listf.getAbsolutePath(), t );
>             }

> Add support for the -f option in the %files section of the rpm spec
> -------------------------------------------------------------------
>
>                 Key: MRPM-51
>                 URL: http://jira.codehaus.org/browse/MRPM-51
>             Project: Mojo RPM Plugin
>          Issue Type: New Feature
>          Components: rpm
>         Environment: Red hat Linux
>            Reporter: Dudley Fox
>            Assignee: Brett Okken
>         Attachments: rpm-4.zip
>
>
> We have a.rpm and b.rpm. And we have user_a and user_b.
> We install a.rpm as user_a, and then b.rpm as user_b. The installation
> of b.rpm fails, because it does not have permission to overwrite the
> file Sha1header (part of the rpm database), which is created when you
> have files under your %files section.
>  
> We know we can fix this if we use something like: %files -f $PWD/$Name.list
> At this point, it looks as if we will need to add this functionality ourselves, as soon
> as we have the patch (or more details) I will add them to this issue.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/MRPM-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dudley Fox updated MRPM-51:
---------------------------

    Attachment: rpm-4.zip

This is to test the patch for support of the "%files -f" option.

> Add support for the -f option in the %files section of the rpm spec
> -------------------------------------------------------------------
>
>                 Key: MRPM-51
>                 URL: http://jira.codehaus.org/browse/MRPM-51
>             Project: Mojo RPM Plugin
>          Issue Type: New Feature
>          Components: rpm
>         Environment: Red hat Linux
>            Reporter: Dudley Fox
>            Assignee: Brett Okken
>         Attachments: rpm-4.zip
>
>
> We have a.rpm and b.rpm. And we have user_a and user_b.
> We install a.rpm as user_a, and then b.rpm as user_b. The installation
> of b.rpm fails, because it does not have permission to overwrite the
> file Sha1header (part of the rpm database), which is created when you
> have files under your %files section.
>  
> We know we can fix this if we use something like: %files -f $PWD/$Name.list
> At this point, it looks as if we will need to add this functionality ourselves, as soon
> as we have the patch (or more details) I will add them to this issue.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/MRPM-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=198276#action_198276 ]

Brett Okken commented on MRPM-51:
---------------------------------

Can you create a patch and attach as a file?

> Add support for the -f option in the %files section of the rpm spec
> -------------------------------------------------------------------
>
>                 Key: MRPM-51
>                 URL: http://jira.codehaus.org/browse/MRPM-51
>             Project: Mojo RPM Plugin
>          Issue Type: New Feature
>          Components: rpm
>         Environment: Red hat Linux
>            Reporter: Dudley Fox
>            Assignee: Brett Okken
>         Attachments: rpm-4.zip
>
>
> We have a.rpm and b.rpm. And we have user_a and user_b.
> We install a.rpm as user_a, and then b.rpm as user_b. The installation
> of b.rpm fails, because it does not have permission to overwrite the
> file Sha1header (part of the rpm database), which is created when you
> have files under your %files section.
>  
> We know we can fix this if we use something like: %files -f $PWD/$Name.list
> At this point, it looks as if we will need to add this functionality ourselves, as soon
> as we have the patch (or more details) I will add them to this issue.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/MRPM-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dudley Fox updated MRPM-51:
---------------------------

    Attachment: patch.tgz

Attaching patch.tgz which is a patch for the changes we made.

> Add support for the -f option in the %files section of the rpm spec
> -------------------------------------------------------------------
>
>                 Key: MRPM-51
>                 URL: http://jira.codehaus.org/browse/MRPM-51
>             Project: Mojo RPM Plugin
>          Issue Type: New Feature
>          Components: rpm
>         Environment: Red hat Linux
>            Reporter: Dudley Fox
>            Assignee: Brett Okken
>         Attachments: patch.tgz, rpm-4.zip
>
>
> We have a.rpm and b.rpm. And we have user_a and user_b.
> We install a.rpm as user_a, and then b.rpm as user_b. The installation
> of b.rpm fails, because it does not have permission to overwrite the
> file Sha1header (part of the rpm database), which is created when you
> have files under your %files section.
>  
> We know we can fix this if we use something like: %files -f $PWD/$Name.list
> At this point, it looks as if we will need to add this functionality ourselves, as soon
> as we have the patch (or more details) I will add them to this issue.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email