[jira] Created: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

View: New views
13 Messages — Rating Filter:   Alert me  

[jira] Created: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Overlaying breaks configuration of webXml with a fatal error
------------------------------------------------------------

                 Key: MWAR-158
                 URL: http://jira.codehaus.org/browse/MWAR-158
             Project: Maven 2.x War Plugin
          Issue Type: Bug
    Affects Versions: 2.1-alpha-1
         Environment: Maven 2.0.9
SuSE Linux 10.3
java version "1.5.0_09"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)

            Reporter: Michael Heß
            Priority: Blocker
         Attachments: webXmlBug.tar.gz

When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:

[INFO] [war:war]
[INFO] Packaging webapp
[INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
[INFO] Processing war project
OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
[INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
[INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
[INFO] ------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
[INFO] ------------------------------------------------------------------------
[INFO] Trace
java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
        at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
        at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
        at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
[...]


I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".

(I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



[jira] Updated: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephane Nicoll updated MWAR-158:
---------------------------------

    Priority: Critical  (was: Blocker)

> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Priority: Critical
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



[jira] Commented: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=150171#action_150171 ]

Michael Heß commented on MWAR-158:
----------------------------------

Why is this bug supposed to affect 2.1-alpha-1 ?
As I posted, it affects the current version 2.0.9.

@Stephane: Why did you demote it from blocker to critical? It clearly breaks the build. IMHO it therefore is a blocker. Could you please elaborate on this change?

> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Priority: Critical
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



[jira] Commented: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=150173#action_150173 ]

Stephane Nicoll commented on MWAR-158:
--------------------------------------

This is the plugin version, not the maven version (i.e. versions specified here are the war plugin version since we are in the war plugin jira project).

It make no sense to have blocking issues here since nobody will have a look to it *right now* (there is no SLA, this is open source and community based). I agree it is cirticial and must be fixed for the next release though.

> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Priority: Critical
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



[jira] Commented: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=150198#action_150198 ]

Miles Thomason commented on MWAR-158:
-------------------------------------

Quick workaround for those affected... you can easily downgrade to the 2.0 version of the war-plugin by adding this to the plugins section of the POM:

<plugin>
          <artifactId>maven-war-plugin</artifactId>
          <version>2.0</version>
</plugin>


> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Priority: Critical
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



[jira] Commented: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160339#action_160339 ]

David Bernard commented on MWAR-158:
------------------------------------

The following seems to work as a workaround.  
The "overlay" is laid down first excluding web.xml and the web app is then overlayed on top.


          <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-war-plugin</artifactId>
                <configuration>
                    <webXml>${project.build.directory}/jspweb.xml</webXml>
                    <warName>${project.build.finalName}</warName>
                    <overlays>
                        <overlay>
                            <groupId>com.xxxx.core</groupId>
                            <artifactId>xxx-user</artifactId>
                            <type>war</type>
                            <excludes>
                                <exclude>WEB/web.xml</exclude>
                            </excludes>
                        </overlay>
                        <overlay>

                        </overlay>
                    </overlays>
                </configuration>
            </plugin>


> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Priority: Critical
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



[jira] Commented: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174110#action_174110 ]

Simone Pierazzini commented on MWAR-158:
----------------------------------------

I think that the exception occurs because WarProjectPackagingTask registers the path in the FullStructure only.
If one modifies the class as shown in the following the build doesn't fail anymore.

I don't know if it's correct to use WarProjectPackagingTask.id to identify the war project as the owner.

Index: src/main/java/org/apache/maven/plugin/war/packaging/WarProjectPackagingTask.java
===================================================================
--- src/main/java/org/apache/maven/plugin/war/packaging/WarProjectPackagingTask.java    (revisione 768245)
+++ src/main/java/org/apache/maven/plugin/war/packaging/WarProjectPackagingTask.java    (copia locale)
@@ -230,6 +230,7 @@
                 }
 
                 context.getWebappStructure().getFullStructure().add( WEB_INF_PATH + "/web.xml" );
+                context.getWebappStructure().getStructure(id).add( WEB_INF_PATH + "/web.xml" );
             }
             else
             {
@@ -241,6 +242,7 @@
                     context.getMavenFileFilter().copyFile( defaultWebXml, new File( webinfDir, "web.xml" ), true,
                                                            context.getFilterWrappers(), getEncoding( defaultWebXml ) );
                     context.getWebappStructure().getFullStructure().add( WEB_INF_PATH + "/web.xml" );
+                    context.getWebappStructure().getStructure(id).add( WEB_INF_PATH + "/web.xml" );
                 }
             }
 
@@ -259,6 +261,7 @@
                               "META-INF/" + xmlFileName, true );
                 }
                 context.getWebappStructure().getFullStructure().add( META_INF_PATH + "/" + xmlFileName );
+                context.getWebappStructure().getStructure(id).add( META_INF_PATH + "/" + xmlFileName );
             }
         }
         catch ( IOException e )


> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Priority: Critical
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



[jira] Updated: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephane Nicoll updated MWAR-158:
---------------------------------

    Fix Version/s: 2.1

> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Priority: Critical
>             Fix For: 2.1
>
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



Commented: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182642#action_182642 ]

Stephane Nicoll commented on MWAR-158:
--------------------------------------

I am having a look to this one right now and I cant' reproduce the issue. I tried the test case but any combination of mvn clean install or mvn install several times did not fail.

It does not fail either with the trunk.

> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Priority: Critical
>             Fix For: 2.1
>
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



Updated: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephane Nicoll updated MWAR-158:
---------------------------------

    Comment: was deleted

(was: I am having a look to this one right now and I cant' reproduce the issue. I tried the test case but any combination of mvn clean install or mvn install several times did not fail.

It does not fail either with the trunk.)

> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Priority: Critical
>             Fix For: 2.1
>
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



Commented: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182645#action_182645 ]

Stephane Nicoll commented on MWAR-158:
--------------------------------------

Simone is right. I have extended WebappStructure to allow to "force" register a path with a new owner if necessary.

> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Assignee: Stephane Nicoll
>            Priority: Critical
>             Fix For: 2.1
>
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



Work started: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on MWAR-158 started by Stephane Nicoll.

> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Assignee: Stephane Nicoll
>            Priority: Critical
>             Fix For: 2.1
>
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



Closed: (MWAR-158) Overlaying breaks configuration of webXml with a fatal error

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ http://jira.codehaus.org/browse/MWAR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephane Nicoll closed MWAR-158.
--------------------------------

    Resolution: Fixed

> Overlaying breaks configuration of webXml with a fatal error
> ------------------------------------------------------------
>
>                 Key: MWAR-158
>                 URL: http://jira.codehaus.org/browse/MWAR-158
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>         Environment: Maven 2.0.9
> SuSE Linux 10.3
> java version "1.5.0_09"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_09-b03)
> Java HotSpot(TM) Server VM (build 1.5.0_09-b03, mixed mode)
>            Reporter: Michael Heß
>            Assignee: Stephane Nicoll
>            Priority: Critical
>             Fix For: 2.1
>
>         Attachments: webXmlBug.tar.gz
>
>
> When using overlays, it is no longer possible to use the webXml configuration value. The following exception is thrown:
> [INFO] [war:war]
> [INFO] Packaging webapp
> [INFO] Assembling webapp[webXmlBug] in [/home/mhe/workspace_spielwiese/webXmlBug/target/webXmlBug]
> [INFO] Processing war project
> OverlayPackagingTask performPackaging overlay.getTargetPath() null[INFO] Processing overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Unpacking overlay[ id de.ordix.webXmlBug:overlay]
> [INFO] Expanding: /home/mhe/.m2/repository/de/ordix/webXmlBug/overlay/1.0-SNAPSHOT/overlay-1.0-SNAPSHOT.war into /home/mhe/workspace_spielwiese/webXmlBug/target/war/work/de.ordix.webXmlBug/overlay
> [INFO] ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
> [INFO] ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.IllegalStateException: Should not happen, path[WEB-INF/web.xml] is flagged as being registered but was not found.
>         at org.apache.maven.plugin.war.util.WebappStructure.getOwner(WebappStructure.java:157)
>         at org.apache.maven.plugin.war.util.WebappStructure.registerFile(WebappStructure.java:105)
>         at org.apache.maven.plugin.war.packaging.AbstractWarPackagingTask.copyFile(AbstractWarPackagingTask.java:140)
> [...]
> I have attached a testcase, which reproduces the problem. Just build overlay and webXmlBug with "mvn clean install".
> (I know the testcase is synthetic. If you want a "real world" scenario, just replace the resources-copy step with e.g. jsp-precompiling.)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira