[jira] Created: (MWAR-164) suporting spesification of encoding to use when filtering resources

suporting spesification of encoding to use when filtering resources
-------------------------------------------------------------------

                 Key: MWAR-164
                 URL: http://jira.codehaus.org/browse/MWAR-164
             Project: Maven 2.x War Plugin
          Issue Type: Improvement
    Affects Versions: 2.1-alpha-1
            Reporter: kai lilleby


Howdy,


You can create the issue in the WAR plugin (see below).




Thanks,
Stéphane


---------- Forwarded message ----------
From: Hervé BOUTEMY <herve.boutemy@...>
Date: Tue, Aug 5, 2008 at 10:45 PM
Subject: Re: Fwd: regarding encoding and filtering in maven war plugin
To: Maven Developers List <dev@...>


Hi,

Maven filtering provides an encoding parameter to set encoding used when
reading/writing files. But war plugin uses null value, which means platform
encoding... Sorry, encoding support won't be totally "free" ;)

I added TODOs in the code.

For web.xml and container config XML file, I set encoding to UTF-8, which is a
better default value than platform encoding.

For other filtered resources, you'll need to add an encoding attribute to
o.a.m.model.Resource class, to let the user define which encoding he wants to
use when filtering. Perhaps using project.build.sourceEncoding as a default
value is a good idea.
Seems like this is worth a Jira issue to track this new feature.


Regards,

Hervé

Le mardi 05 août 2008, Stephane Nicoll a écrit :

> Howdy,
>
> Hervé, could you please give us a status of the work needed to upgrade war
> to support filtered encoding? We are using maven filtering so will it come
> "for free" in the next release?
>
> Best,
> Stéphane
>
> ---------- Forwarded message ----------
> From: Kai Lilleby <kai@...>
> Date: Tue, Aug 5, 2008 at 8:57 AM
> Subject: regarding encoding and filtering in maven war plugin
> To: stephane.nicoll@...
>
>
>  Greetings from norway:)
> any idea on when spesification of encoding to use when filtering war
> resources will be supported?
> seems that current version uses the system default encoding..
>
> kai

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...





--
Large Systems Suck: This rule is 100% transitive. If you build one, you suck" -- S.Yegge


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephane Nicoll updated MWAR-164:
---------------------------------

    Description:
Quoting Hervé:

{quote}
Maven filtering provides an encoding parameter to set encoding used when
reading/writing files. But war plugin uses null value, which means platform
encoding... Sorry, encoding support won't be totally "free" ;)

I added TODOs in the code.

For web.xml and container config XML file, I set encoding to UTF-8, which is a
better default value than platform encoding.

For other filtered resources, you'll need to add an encoding attribute to
o.a.m.model.Resource class, to let the user define which encoding he wants to
use when filtering. Perhaps using project.build.sourceEncoding as a default
value is a good idea.
Seems like this is worth a Jira issue to track this new feature.
{quote}

  was:
Howdy,


You can create the issue in the WAR plugin (see below).




Thanks,
Stéphane


---------- Forwarded message ----------
From: Hervé BOUTEMY <herve.boutemy@...>
Date: Tue, Aug 5, 2008 at 10:45 PM
Subject: Re: Fwd: regarding encoding and filtering in maven war plugin
To: Maven Developers List <dev@...>


Hi,

Maven filtering provides an encoding parameter to set encoding used when
reading/writing files. But war plugin uses null value, which means platform
encoding... Sorry, encoding support won't be totally "free" ;)

I added TODOs in the code.

For web.xml and container config XML file, I set encoding to UTF-8, which is a
better default value than platform encoding.

For other filtered resources, you'll need to add an encoding attribute to
o.a.m.model.Resource class, to let the user define which encoding he wants to
use when filtering. Perhaps using project.build.sourceEncoding as a default
value is a good idea.
Seems like this is worth a Jira issue to track this new feature.


Regards,

Hervé

Le mardi 05 août 2008, Stephane Nicoll a écrit :

> Howdy,
>
> Hervé, could you please give us a status of the work needed to upgrade war
> to support filtered encoding? We are using maven filtering so will it come
> "for free" in the next release?
>
> Best,
> Stéphane
>
> ---------- Forwarded message ----------
> From: Kai Lilleby <kai@...>
> Date: Tue, Aug 5, 2008 at 8:57 AM
> Subject: regarding encoding and filtering in maven war plugin
> To: stephane.nicoll@...
>
>
>  Greetings from norway:)
> any idea on when spesification of encoding to use when filtering war
> resources will be supported?
> seems that current version uses the system default encoding..
>
> kai

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...





--
Large Systems Suck: This rule is 100% transitive. If you build one, you suck" -- S.Yegge

> suporting spesification of encoding to use when filtering resources
> -------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x War Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy updated MWAR-164:
------------------------------

    Fix Version/s: 2.1

> suporting spesification of encoding to use when filtering resources
> -------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x War Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=164763#action_164763 ]

Dennis Lundberg commented on MWAR-164:
--------------------------------------

I stumbled upon this issue today when using filteringDeploymentDescriptors.

Filtering the web.xml file should be able to use the encoding specified in the web.xml file itself. We specify ISO-8859-1 as the encoding in our web.xml, but it ends up scrambled into UTF-8 after being filtered.


This is our configuration:

{noformat}
       <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-war-plugin</artifactId>
          <version>2.1-alpha-2</version>
          <configuration>
            <archive>
              <manifest>
                <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
              </manifest>
            </archive>
            <archiveClasses>true</archiveClasses>
            <filteringDeploymentDescriptors>true</filteringDeploymentDescriptors>
          </configuration>
        </plugin>
{noformat}

> suporting spesification of encoding to use when filtering resources
> -------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x War Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=164923#action_164923 ]

Dennis Lundberg commented on MWAR-164:
--------------------------------------

Bug fix for filteringDeploymentDescriptors coming up.

> suporting spesification of encoding to use when filtering resources
> -------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x War Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MWAR-164:
---------------------------------

    Summary: Support for specifying which encoding to use when filtering resources  (was: suporting spesification of encoding to use when filtering resources)

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x War Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=164926#action_164926 ]

Dennis Lundberg commented on MWAR-164:
--------------------------------------

Created MWAR-183 specifically for filteringDeploymentDescriptors.

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x War Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MWAR-164:
---------------------------------

    Fix Version/s:     (was: 2.1-beta-1)
                   2.1

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x War Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182650#action_182650 ]

Stephane Nicoll commented on MWAR-164:
--------------------------------------

Hey Dennis, are we sure we want to do this?

Why do we have two strategies here (enconding specified in the xml and a parameter for filtered resources). The resources plugin does not offer such feature AFAIK ...

I'd go with something similar to the resources plugin and that would be enough,right?

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182859#action_182859 ]

Benjamin Bentmann commented on MWAR-164:
----------------------------------------

bq. Why do we have two strategies here (enconding specified in the xml and a parameter for filtered resources).
XML files come with the luxus of an embedded encoding declaration and this declaration has to be obeyed or interpolation fails, leaving the input either unaltered or corrupted (it's a [fatal error|http://www.w3.org/TR/REC-xml/#NT-EncodingDecl] if the encoding does not match the file's byte stream). Most other resources files (i.e. non-XML documents), are not equipped with an embedded encoding declaration so the user has to provide the encoding in form of a parameter.

The Resources Plugin or better the filtering component should ideally be enhanced to detect XML files and respect their encoding.

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=183097#action_183097 ]

Dennis Lundberg commented on MWAR-164:
--------------------------------------

I agree with Stephane and Benjamin. We should simply use any encoding specified in the files to be filtered. This will at least work for xml files, since they have the ability for the author to specify the encoding being used. Ideally this should be handled by the shared filtering component.

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=184895#action_184895 ]

Olivier Lamy commented on MWAR-164:
-----------------------------------

So we need to detect *.xml files (in a harcoded way ?).
This need some changes in DefaultMavenFileFilter#copyFile.
Something like
pseudo code without any formating :P
{code}
if ( file.endWith (*.xml) )
encoding = ReaderFactory.newXmlReader( from ).getEncoding();
{code}
WDYT ?

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=184895#action_184895 ]

Olivier Lamy edited comment on MWAR-164 at 7/26/09 3:11 AM:
------------------------------------------------------------

So we need to detect *.xml files (in a harcoded way ?).
This need some changes in DefaultMavenFileFilter#copyFile.
Something like
pseudo code without any formating :P
{code}
if ( file.endWith (*.xml) )
encoding = ReaderFactory.newXmlReader( from ).getEncoding();
{code}
BTW this new way of filtering should be off by default (and configurable).
As this can break some builds.
WDYT ?

      was (Author: olamy):
    So we need to detect *.xml files (in a harcoded way ?).
This need some changes in DefaultMavenFileFilter#copyFile.
Something like
pseudo code without any formating :P
{code}
if ( file.endWith (*.xml) )
encoding = ReaderFactory.newXmlReader( from ).getEncoding();
{code}
WDYT ?
 

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=186839#action_186839 ]

Ognjen Blagojevic commented on MWAR-164:
----------------------------------------

Herve is right. "Perhaps using project.build.sourceEncoding as a default value is a good idea."

Plus a Boolean parameter (searchEncodingInFiles) which will specify to open XML/JSP/HTML... files to look for specified encoding. This is of course harder to implement and less valuable, so maybe could be separate bug?

project.build.sourceEncoding covers most use cases, I think.

Regards,
Ognjen

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira