[jira] Created: (MYFACES-2388) Link to download FILE on a Dialog fails of FF

[My Faces - Dev mailing list]

Link to download FILE on a Dialog fails of FF
---------------------------------------------

                 Key: MYFACES-2388
                 URL: https://issues.apache.org/jira/browse/MYFACES-2388
             Project: MyFaces Core
          Issue Type: Bug
    Affects Versions: 1.2.6
         Environment: Windows XP, Firefox 3.5.3
            Reporter: Paskal Sanil


On placing a link on a Dialog to download a file, gives javascript error "Form undefined".
Find Sample generated Js below:

oamSubmitForm('downloadDialog-f','downloadDialog-f:downloadBulkData',null,[['Uri','ExportedData.zip']]);

On analyzing further, in methods, oamSubmitForm() and oamSetHiddenInput() it can't find the form.
I modified "Get form logic" from:

var form = document.forms[formName];

   to

var form = document.getElementById(formName);

and it now works. We are currently using this workaround. But a neat solution in the jar would be more preferable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/MYFACES-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773208#action_12773208 ]

Leonardo Uribe commented on MYFACES-2388:
-----------------------------------------

It seems to be something related to put the link on the Dialog, because the base case works without problem.

Anyway, it seem reasonable replace this:

                var form = document.forms[formName];

with this:

                var form = document.forms[formName];
                if (typeof form == 'undefined')
                {
                        form = document.getElementById(formName);
                }

So, if the form is not available under document.forms, there is a chance to lookup it using document.getElementById.

> Link to download FILE on a Dialog fails of FF
> ---------------------------------------------
>
>                 Key: MYFACES-2388
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2388
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 1.2.6
>         Environment: Windows XP, Firefox 3.5.3
>            Reporter: Paskal Sanil
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> On placing a link on a Dialog to download a file, gives javascript error "Form undefined".
> Find Sample generated Js below:
> oamSubmitForm('downloadDialog-f','downloadDialog-f:downloadBulkData',null,[['Uri','ExportedData.zip']]);
> On analyzing further, in methods, oamSubmitForm() and oamSetHiddenInput() it can't find the form.
> I modified "Get form logic" from:
> var form = document.forms[formName];
>    to
> var form = document.getElementById(formName);
> and it now works. We are currently using this workaround. But a neat solution in the jar would be more preferable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

     [ https://issues.apache.org/jira/browse/MYFACES-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-2388.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.8-SNAPSHOT
         Assignee: Leonardo Uribe

> Link to download FILE on a Dialog fails of FF
> ---------------------------------------------
>
>                 Key: MYFACES-2388
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2388
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 1.2.6
>         Environment: Windows XP, Firefox 3.5.3
>            Reporter: Paskal Sanil
>            Assignee: Leonardo Uribe
>             Fix For: 1.2.8-SNAPSHOT
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> On placing a link on a Dialog to download a file, gives javascript error "Form undefined".
> Find Sample generated Js below:
> oamSubmitForm('downloadDialog-f','downloadDialog-f:downloadBulkData',null,[['Uri','ExportedData.zip']]);
> On analyzing further, in methods, oamSubmitForm() and oamSetHiddenInput() it can't find the form.
> I modified "Get form logic" from:
> var form = document.forms[formName];
>    to
> var form = document.getElementById(formName);
> and it now works. We are currently using this workaround. But a neat solution in the jar would be more preferable.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.