[jira] Created: (MYFACES-2393) graphicImage tag does not handle resource EL expressions properly

View: New views
2 Messages — Rating Filter:   Alert me  

[jira] Created: (MYFACES-2393) graphicImage tag does not handle resource EL expressions properly

by My Faces - Dev mailing list :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

graphicImage tag does not handle resource EL expressions properly
-----------------------------------------------------------------

                 Key: MYFACES-2393
                 URL: https://issues.apache.org/jira/browse/MYFACES-2393
             Project: MyFaces Core
          Issue Type: Bug
          Components: JSR-314
    Affects Versions: 2.0.0-alpha
            Reporter: Michael Concini
            Assignee: Michael Concini
            Priority: Minor


two problems that need to be resolved.  

FIrst is that ResourceResolver when handling resource['library:resourceName'], was passing the parsed arguments in backwards to ResourceHandler.createResource.  It should have been name, library, but we were passing library,name.

Second problem is that we were prepending the context root twice due to multiple calls to getResource when the value attribute was a resource EL expression.  First during the createResource call from ResourceResolver, and then again in the image renderer.  Added a check for ResourceHandler.RESOURCE_IDENTIFIER constant prior to calling getResourceURL so we don't add it twice in the EL case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-2393) graphicImage tag does not handle resource EL expressions properly

by My Faces - Dev mailing list :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/MYFACES-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Concini resolved MYFACES-2393.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-alpha

> graphicImage tag does not handle resource EL expressions properly
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2393
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2393
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Michael Concini
>            Assignee: Michael Concini
>            Priority: Minor
>             Fix For: 2.0.0-alpha
>
>
> two problems that need to be resolved.  
> FIrst is that ResourceResolver when handling resource['library:resourceName'], was passing the parsed arguments in backwards to ResourceHandler.createResource.  It should have been name, library, but we were passing library,name.
> Second problem is that we were prepending the context root twice due to multiple calls to getResource when the value attribute was a resource EL expression.  First during the createResource call from ResourceResolver, and then again in the image renderer.  Added a check for ResourceHandler.RESOURCE_IDENTIFIER constant prior to calling getResourceURL so we don't add it twice in the EL case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.