[jira] Created: (NUTCH-757) RequestUtils getBooleanParameter() always returns false

RequestUtils getBooleanParameter() always returns false
-------------------------------------------------------

                 Key: NUTCH-757
                 URL: https://issues.apache.org/jira/browse/NUTCH-757
             Project: Nutch
          Issue Type: Bug
          Components: searcher
    Affects Versions: 1.0.0
            Reporter: Niall Pemberton
            Priority: Minor


RequestUtils getBooleanParameter() always returns false because it tests the name of the parameter rather than the value!

You can see this problem with the Nutch webapp, if you try adding a "summary" parameter the summary is never included, whatever value you specify (either "1", "true" or "yes"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/NUTCH-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton updated NUTCH-757:
----------------------------------

    Attachment: NUTCH-757-RequestUtils-boolean.patch

> RequestUtils getBooleanParameter() always returns false
> -------------------------------------------------------
>
>                 Key: NUTCH-757
>                 URL: https://issues.apache.org/jira/browse/NUTCH-757
>             Project: Nutch
>          Issue Type: Bug
>          Components: searcher
>    Affects Versions: 1.0.0
>            Reporter: Niall Pemberton
>            Priority: Minor
>         Attachments: NUTCH-757-RequestUtils-boolean.patch
>
>
> RequestUtils getBooleanParameter() always returns false because it tests the name of the parameter rather than the value!
> You can see this problem with the Nutch webapp, if you try adding a "summary" parameter the summary is never included, whatever value you specify (either "1", "true" or "yes"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/NUTCH-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrzej Bialecki  closed NUTCH-757.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1
         Assignee: Andrzej Bialecki

> RequestUtils getBooleanParameter() always returns false
> -------------------------------------------------------
>
>                 Key: NUTCH-757
>                 URL: https://issues.apache.org/jira/browse/NUTCH-757
>             Project: Nutch
>          Issue Type: Bug
>          Components: searcher
>    Affects Versions: 1.0.0
>            Reporter: Niall Pemberton
>            Assignee: Andrzej Bialecki
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: NUTCH-757-RequestUtils-boolean.patch
>
>
> RequestUtils getBooleanParameter() always returns false because it tests the name of the parameter rather than the value!
> You can see this problem with the Nutch webapp, if you try adding a "summary" parameter the summary is never included, whatever value you specify (either "1", "true" or "yes"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/NUTCH-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764019#action_12764019 ]

Andrzej Bialecki  commented on NUTCH-757:
-----------------------------------------

Fixed in rev. 823547 - special thanks for the comprehensive unit test!

> RequestUtils getBooleanParameter() always returns false
> -------------------------------------------------------
>
>                 Key: NUTCH-757
>                 URL: https://issues.apache.org/jira/browse/NUTCH-757
>             Project: Nutch
>          Issue Type: Bug
>          Components: searcher
>    Affects Versions: 1.0.0
>            Reporter: Niall Pemberton
>            Assignee: Andrzej Bialecki
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: NUTCH-757-RequestUtils-boolean.patch
>
>
> RequestUtils getBooleanParameter() always returns false because it tests the name of the parameter rather than the value!
> You can see this problem with the Nutch webapp, if you try adding a "summary" parameter the summary is never included, whatever value you specify (either "1", "true" or "yes"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/NUTCH-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764299#action_12764299 ]

Hudson commented on NUTCH-757:
------------------------------

Integrated in Nutch-trunk #959 (See [http://hudson.zones.apache.org/hudson/job/Nutch-trunk/959/])
     RequestUtils getBooleanParameter() always returns false.

> RequestUtils getBooleanParameter() always returns false
> -------------------------------------------------------
>
>                 Key: NUTCH-757
>                 URL: https://issues.apache.org/jira/browse/NUTCH-757
>             Project: Nutch
>          Issue Type: Bug
>          Components: searcher
>    Affects Versions: 1.0.0
>            Reporter: Niall Pemberton
>            Assignee: Andrzej Bialecki
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: NUTCH-757-RequestUtils-boolean.patch
>
>
> RequestUtils getBooleanParameter() always returns false because it tests the name of the parameter rather than the value!
> You can see this problem with the Nutch webapp, if you try adding a "summary" parameter the summary is never included, whatever value you specify (either "1", "true" or "yes"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.