[jira] Created: (ODE-634) Event Handles not working

Event Handles not working
-------------------------

                 Key: ODE-634
                 URL: https://issues.apache.org/jira/browse/ODE-634
             Project: ODE
          Issue Type: Bug
          Components: BPEL Runtime
    Affects Versions: 1.3.2, 1.3.3, 2.0
            Reporter: William McCusker


When attempting to send a message to an event handler one of two possibilities occur:

1.) Event Handler fails to receive message.

2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728819#action_12728819 ]

William McCusker commented on ODE-634:
--------------------------------------

1.) This was caused by the message route not being persisted to the back end. Explicitly calling persist of the message route being created by org.apache.ode.dao.jpa.CorrelatorDAOImpl addRoute fixed this problem.

2.) The conflicting receive fault was trigger by a race condition between processing the event handler's associated scope and the select runnable. If the scope completes first the is no problem however often times the select runnable would be processed first and attempt to register a receiver for the same partner link, operation and message exchange resulting in a conflicting receive. By having event handlers wait runnable move it's out standing request to a "waiting to reply" state the select runnable can register that it waiting for a new request.

I will attach the patch I have for the 1.x branch and then will look into porting the patch to 2.x

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William McCusker updated ODE-634:
---------------------------------

    Attachment: event_handler_1x.patch

patch for 1.x branch

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: event_handler_1x.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729439#action_12729439 ]

Matthieu Riou commented on ODE-634:
-----------------------------------

I remember fixing something along the lines of you 2) some time ago although I can't remember if it was something in the same area of the code or really the same problem. Did you also try with a fresh checkout of the 1.X branch?

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: event_handler_1x.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729653#action_12729653 ]

William McCusker commented on ODE-634:
--------------------------------------

It had been about a week since I last sync'd so I sync'd up today and tested. I am still seeing the same problems without the patch I provided applied. I'll attach the test artifacts I used.

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William McCusker updated ODE-634:
---------------------------------

    Attachment: account-soapui-project.xml
                account-sa.zip

JBI service assembly and soapUI test

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William McCusker updated ODE-634:
---------------------------------

    Attachment: event_handler_trunk.patch

Patch for trunk

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739199#action_12739199 ]

Matthieu Riou commented on ODE-634:
-----------------------------------

I understand your 1) but not the 2). I do have processes now with working events, be it on Hibernate.

Why do you need to add this reply map in OutstandingRequestManager ?

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739210#action_12739210 ]

Daniel Dominguez commented on ODE-634:
--------------------------------------

I will be out of the office from August 5th 2009 until August 10th 2009.

If you have questions regarding BPEL Maestro, please send an email to bpelsupport@....

Otherwise, I will answer your email upon my return.

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739219#action_12739219 ]

William McCusker commented on ODE-634:
--------------------------------------

Short version:

   Race condition between the child scope finishing and a new EH_EVENT SELECT

Long Version:

   When the event handler processes a message it submits a new SCOPE activity and then submits a new SELECT runnable. As part of the SELECT runnable the process checks if selectors for a given operation, port and partnerLink are registered to detect the standard bpel fault conflictingReceive.

   This causes a race condition between the SCOPE and SELECT. If the SCOPE activity completes first there is no problem, however if the SELECT runnable runs before the SCOPE (and all its children) finish it will find that it someone has already registered the selectors and throws a conflicitingReceive fault. In this case EH_EVENT is detecting a  conflict with itself.

To get around this I have the EH_EVENT move the current outstanding receive into the reply map so that it will not detect a conflicting receive with itself.

As I look at another solution might be to delay creating the new SELECT till the SCOPE finishes. Would a termination channel listener do work?

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739220#action_12739220 ]

Daniel Dominguez commented on ODE-634:
--------------------------------------

I will be out of the office from August 5th 2009 until August 10th 2009.

If you have questions regarding BPEL Maestro, please send an email to bpelsupport@....

Otherwise, I will answer your email upon my return.

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739221#action_12739221 ]

Daniel Dominguez commented on ODE-634:
--------------------------------------

I will be out of the office from August 5th 2009 until August 10th 2009.

If you have questions regarding BPEL Maestro, please send an email to bpelsupport@....

Otherwise, I will answer your email upon my return.

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739227#action_12739227 ]

Daniel Dominguez commented on ODE-634:
--------------------------------------

I will be out of the office from August 5th 2009 until August 10th 2009.

If you have questions regarding BPEL Maestro, please send an email to bpelsupport@....

Otherwise, I will answer your email upon my return.

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739228#action_12739228 ]

Daniel Dominguez commented on ODE-634:
--------------------------------------

I will be out of the office from August 5th 2009 until August 10th 2009.

If you have questions regarding BPEL Maestro, please send an email to bpelsupport@....

Otherwise, I will answer your email upon my return.

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739231#action_12739231 ]

Daniel Dominguez commented on ODE-634:
--------------------------------------

I will be out of the office from August 5th 2009 until August 10th 2009.

If you have questions regarding BPEL Maestro, please send an email to bpelsupport@....

Otherwise, I will answer your email upon my return.

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Alex Boisvert-3]

For those concerned about this out-of-office spam, I removed Daniel from the
watch list.

alex


On Tue, Aug 4, 2009 at 4:06 PM, Daniel Dominguez (JIRA) <jira@...>wrote:

>
>    [
> https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739231#action_12739231]
>
> Daniel Dominguez commented on ODE-634:
> --------------------------------------
>
> I will be out of the office from August 5th 2009 until August 10th 2009.
>
> If you have questions regarding BPEL Maestro, please send an email to
> bpelsupport@....
>
> Otherwise, I will answer your email upon my return.
>
>
> > Event Handles not working
> > -------------------------
> >
> >                 Key: ODE-634
> >                 URL: https://issues.apache.org/jira/browse/ODE-634
> >             Project: ODE
> >          Issue Type: Bug
> >          Components: BPEL Runtime
> >    Affects Versions: 1.3.2, 1.3.3, 2.0
> >            Reporter: William McCusker
> >         Attachments: account-sa.zip, account-soapui-project.xml,
> event_handler_1x.patch, event_handler_trunk.patch
> >
> >
> > When attempting to send a message to an event handler one of two
> possibilities occur:
> > 1.) Event Handler fails to receive message.
> > 2.) message is receive but conflicting receive fault triggered.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739300#action_12739300 ]

Rafal Rusin commented on ODE-634:
---------------------------------

I believe OutstandingRequestManager needs improvements. But I think we should focus more on doing it right, like WS-BPEL says about IMAs and also related faults: conflictingReceive and conflictingRequest.
I think it would be better to do a bigger patch at once, or at least work on trunk and then migrate, because OutstandingRequestManager is serializable and needs special handling in 1.X for backward compatibility.

There is a couple of issues here:
-as I understand, BPEL Engine should trigger conflictingRequest when partnerLink+operation+correlationSet becomes non unique during instance execution. Now OutstandingRequestManager validates only In-Outs.
-handling Open IMAs separately from IMAs, which William's patch does, adds possibility of implementing conflictingRequest semantics, which isn't now in ODE, but could be added here.
-opening IMA ("associate" method) actually needs selectorIndex, because in case of pick with branches, we want to associate only one selector to handle conflictingRequests well. Also for example, we want to do in-out receive inside one branch in pick on the same plink+op+correlationSet as the other brach of pick has. I believe current OutstandingRequestManager will cause conflictingReceive fault in such case.
-now OutstandingRequestManager validates selectors by RID tuple. It includes mex as well, which is not what Spec says.
-the last thing less important, but cool is to have implemented are messageExchanges declarations in scopes. They could for example throw faults for in-out operations on scope completion instead of process completion only way (releaseAll method). Now mex'es are global and not resolved like variables.

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739499#action_12739499 ]

William McCusker commented on ODE-634:
--------------------------------------

That all makes sense. Especially implementing conflictingRequest semantics.

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Bill McCusker]

Thanks Alex,

    He has turned off his auto-reply. Sorry about that.

Bill McCusker

Alex Boisvert wrote:
> For those concerned about this out-of-office spam, I removed Daniel from the
> watch list.
>
> alex
>
>
> On Tue, Aug 4, 2009 at 4:06 PM, Daniel Dominguez (JIRA) <jira@...>wrote:
>
>  

     [ https://issues.apache.org/jira/browse/ODE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert updated ODE-634:
------------------------------

    Comment: was deleted

(was: I will be out of the office from August 5th 2009 until August 10th 2009.

If you have questions regarding BPEL Maestro, please send an email to bpelsupport@....

Otherwise, I will answer your email upon my return.
)

> Event Handles not working
> -------------------------
>
>                 Key: ODE-634
>                 URL: https://issues.apache.org/jira/browse/ODE-634
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>    Affects Versions: 1.3.2, 1.3.3, 2.0
>            Reporter: William McCusker
>         Attachments: account-sa.zip, account-soapui-project.xml, event_handler_1x.patch, event_handler_trunk.patch
>
>
> When attempting to send a message to an event handler one of two possibilities occur:
> 1.) Event Handler fails to receive message.
> 2.) message is receive but conflicting receive fault triggered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.