[jira] Created: (PLXCOMP-107) Fail to unzip archive, which contains file with name 'How_can_I_annotate_a_part_in_the_AAM%3F.Help' .

Fail to unzip archive, which contains file with name  'How_can_I_annotate_a_part_in_the_AAM%3F.Help' .
-------------------------------------------------------------------------------------------------------

                 Key: PLXCOMP-107
                 URL: http://jira.codehaus.org/browse/PLXCOMP-107
             Project: Plexus Components
          Issue Type: Bug
          Components: plexus-archiver
         Environment: xp windows, jdk 1.6
            Reporter: Egor


Stack trace:

Caused by: java.io.FileNotFoundException: JAR entry extensions/SMWHalo/libs/pred
ef_pages/How_can_I_annotate_a_part_in_the_AAM?.Help not found in E:\Documents an
d Settings\Egr\.m2\repository\org\mediawiki\smwhalo\1.0\smwhalo-1.0.zip
        at sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.ja
va:122)
        at sun.net.www.protocol.jar.JarURLConnection.getInputStream(JarURLConnec
tion.java:132)
        at java.net.URL.openStream(URL.java:1009)
        at org.codehaus.plexus.components.io.resources.PlexusIoURLResource.getCo
ntents(PlexusIoURLResource.java:14)
        at org.codehaus.plexus.components.io.resources.PlexusIoProxyResourceColl
ection$1.getContents(PlexusIoProxyResourceCollection.java:80)
        at org.codehaus.plexus.archiver.ArchiveEntry.getInputStream(ArchiveEntry
.java:89)
        at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(Abstract

Ant can unzip this file. Looks like that problem in org.codehaus.plexus.components.io.resources.PlexusIoZipFileResourceCollection, which is used java.util.zip.ZipEntry classes to work with zip files.Can't handle some characters correctly...
I.e. org.apache.tools.zip.ZipFile class should be used from plexus-archiver...


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/PLXCOMP-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127391 ]

Egor commented on PLXCOMP-107:
------------------------------

Really,  new URL(new URL( "jar:" + f.toURI().toURL() + "!/"), "<path>AAM%3F.Help").openStream() throw FileNotFoundException. So problem may be not in ZipFile classes, but in the way, how plexus try to get zip entry stream...

> Fail to unzip archive, which contains file with name  'How_can_I_annotate_a_part_in_the_AAM%3F.Help' .
> -------------------------------------------------------------------------------------------------------
>
>                 Key: PLXCOMP-107
>                 URL: http://jira.codehaus.org/browse/PLXCOMP-107
>             Project: Plexus Components
>          Issue Type: Bug
>          Components: plexus-archiver
>         Environment: xp windows, jdk 1.6
>            Reporter: Egor
>
> Stack trace:
> Caused by: java.io.FileNotFoundException: JAR entry extensions/SMWHalo/libs/pred
> ef_pages/How_can_I_annotate_a_part_in_the_AAM?.Help not found in E:\Documents an
> d Settings\Egr\.m2\repository\org\mediawiki\smwhalo\1.0\smwhalo-1.0.zip
>         at sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.ja
> va:122)
>         at sun.net.www.protocol.jar.JarURLConnection.getInputStream(JarURLConnec
> tion.java:132)
>         at java.net.URL.openStream(URL.java:1009)
>         at org.codehaus.plexus.components.io.resources.PlexusIoURLResource.getCo
> ntents(PlexusIoURLResource.java:14)
>         at org.codehaus.plexus.components.io.resources.PlexusIoProxyResourceColl
> ection$1.getContents(PlexusIoProxyResourceCollection.java:80)
>         at org.codehaus.plexus.archiver.ArchiveEntry.getInputStream(ArchiveEntry
> .java:89)
>         at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(Abstract
> Ant can unzip this file. Looks like that problem in org.codehaus.plexus.components.io.resources.PlexusIoZipFileResourceCollection, which is used java.util.zip.ZipEntry classes to work with zip files.Can't handle some characters correctly...
> I.e. org.apache.tools.zip.ZipFile class should be used from plexus-archiver...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/PLXCOMP-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127392 ]

Egor commented on PLXCOMP-107:
------------------------------

And finally:
Problem in org.codehaus.plexus.components.io.resources.PlexusIoZipFileResourceCollection:  45 line.

41                   final ZipEntry entry = (ZipEntry) en.nextElement();
42                final PlexusIoURLResource res = new PlexusIoURLResource(){
43                    public URL getURL() throws IOException
44                    {
45                        return new URL( url, entry.getName() );
46                    }
47                };

Such url creation is wrong. E.g. URLClassLoader to load resources use code. new URL(url, sun.net.www.ParseUtil.encodePath(entry.getName(), false)); Where ParseUtil.encodePath contains encoding logic(not simple, really)

> Fail to unzip archive, which contains file with name  'How_can_I_annotate_a_part_in_the_AAM%3F.Help' .
> -------------------------------------------------------------------------------------------------------
>
>                 Key: PLXCOMP-107
>                 URL: http://jira.codehaus.org/browse/PLXCOMP-107
>             Project: Plexus Components
>          Issue Type: Bug
>          Components: plexus-archiver
>         Environment: xp windows, jdk 1.6
>            Reporter: Egor
>
> Stack trace:
> Caused by: java.io.FileNotFoundException: JAR entry extensions/SMWHalo/libs/pred
> ef_pages/How_can_I_annotate_a_part_in_the_AAM?.Help not found in E:\Documents an
> d Settings\Egr\.m2\repository\org\mediawiki\smwhalo\1.0\smwhalo-1.0.zip
>         at sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.ja
> va:122)
>         at sun.net.www.protocol.jar.JarURLConnection.getInputStream(JarURLConnec
> tion.java:132)
>         at java.net.URL.openStream(URL.java:1009)
>         at org.codehaus.plexus.components.io.resources.PlexusIoURLResource.getCo
> ntents(PlexusIoURLResource.java:14)
>         at org.codehaus.plexus.components.io.resources.PlexusIoProxyResourceColl
> ection$1.getContents(PlexusIoProxyResourceCollection.java:80)
>         at org.codehaus.plexus.archiver.ArchiveEntry.getInputStream(ArchiveEntry
> .java:89)
>         at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(Abstract
> Ant can unzip this file. Looks like that problem in org.codehaus.plexus.components.io.resources.PlexusIoZipFileResourceCollection, which is used java.util.zip.ZipEntry classes to work with zip files.Can't handle some characters correctly...
> I.e. org.apache.tools.zip.ZipFile class should be used from plexus-archiver...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/PLXCOMP-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Egor updated PLXCOMP-107:
-------------------------

    Attachment: PlexusIoZipFileResourceCollection.java

Fix for the issue: Use URLClassLoader to create url object for zip entires.

> Fail to unzip archive, which contains file with name  'How_can_I_annotate_a_part_in_the_AAM%3F.Help' .
> -------------------------------------------------------------------------------------------------------
>
>                 Key: PLXCOMP-107
>                 URL: http://jira.codehaus.org/browse/PLXCOMP-107
>             Project: Plexus Components
>          Issue Type: Bug
>          Components: plexus-archiver
>         Environment: xp windows, jdk 1.6
>            Reporter: Egor
>         Attachments: PlexusIoZipFileResourceCollection.java
>
>
> Stack trace:
> Caused by: java.io.FileNotFoundException: JAR entry extensions/SMWHalo/libs/pred
> ef_pages/How_can_I_annotate_a_part_in_the_AAM?.Help not found in E:\Documents an
> d Settings\Egr\.m2\repository\org\mediawiki\smwhalo\1.0\smwhalo-1.0.zip
>         at sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.ja
> va:122)
>         at sun.net.www.protocol.jar.JarURLConnection.getInputStream(JarURLConnec
> tion.java:132)
>         at java.net.URL.openStream(URL.java:1009)
>         at org.codehaus.plexus.components.io.resources.PlexusIoURLResource.getCo
> ntents(PlexusIoURLResource.java:14)
>         at org.codehaus.plexus.components.io.resources.PlexusIoProxyResourceColl
> ection$1.getContents(PlexusIoProxyResourceCollection.java:80)
>         at org.codehaus.plexus.archiver.ArchiveEntry.getInputStream(ArchiveEntry
> .java:89)
>         at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(Abstract
> Ant can unzip this file. Looks like that problem in org.codehaus.plexus.components.io.resources.PlexusIoZipFileResourceCollection, which is used java.util.zip.ZipEntry classes to work with zip files.Can't handle some characters correctly...
> I.e. org.apache.tools.zip.ZipFile class should be used from plexus-archiver...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email