[jira] Created: (QDOX-166) qdox generates invalid java for nested class references

qdox generates invalid java for nested class references
-------------------------------------------------------

                 Key: QDOX-166
                 URL: http://jira.codehaus.org/browse/QDOX-166
             Project: QDox
          Issue Type: Bug
          Components: Parser
    Affects Versions: 1.9
         Environment: Apache Maven 2.1.0 (r755702; 2009-03-18 15:10:27-0400)
Java version: 1.6.0_11
Java home: F:\devtools\jdk1.6.0_11\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"

            Reporter: David Boon


Using the gwt-maven-plugin with qdox version 1.9.  Qdox generates invalid references to nested classes:

Example:


Original class:
   import com.google.gwt.gen2.table.client.TableModelHelper;
   public SerializableResponse<Result> doSomething(Long id, TableModelHelper.Request request);

Generated class:
    void doSomething( java.lang.Long id  com.google.gwt.gen2.table.client.TableModelHelper$Request request, AsyncCallback<com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<Result>> callback );

The dollar sign in the generated class seems incorrect since that will not compile.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Robert Scholte-2]

Some parts of this message have been removed. Learn more about Nabble's security policy.

At first hand I would say this is a gwt-maven-plugin issue, which isn't using the right methods.
But after another look I think we have to do some little work too. It seems like we don't offer a method which offers the classname as it should be. The getFullyQualifiedName represents the toString() of the class, so it'll have the dollar-sign.
By supporting getCanonicalName() (and/or getSimpleName) we should be able to cover the mentioned problem.
 
 
some extra info
http://java.sun.com/docs/books/jls/third_edition/html/names.html#25430
http://java.sun.com/javase/6/docs/api/java/lang/Class.html#getCanonicalName()
http://java.sun.com/javase/6/docs/api/java/lang/Class.html#getSimpleName()

- Regards
 
Robert 
 
 

> Date: Wed, 27 May 2009 13:48:42 -0500
> From: jira@...
> To: dev@...
> Subject: [qdox-dev] [jira] Created: (QDOX-166) qdox generates invalid java for nested class references
>
> qdox generates invalid java for nested class references
> -------------------------------------------------------
>
> Key: QDOX-166
> URL: http://jira.codehaus.org/browse/QDOX-166
> Project: QDox
> Issue Type: Bug
> Components: Parser
> Affects Versions: 1.9
> Environment: Apache Maven 2.1.0 (r755702; 2009-03-18 15:10:27-0400)
> Java version: 1.6.0_11
> Java home: F:\devtools\jdk1.6.0_11\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
>
> Reporter: David Boon
>
>
> Using the gwt-maven-plugin with qdox version 1.9. Qdox generates invalid references to nested classes:
>
> Example:
>
>
> Original class:
> import com.google.gwt.gen2.table.client.TableModelHelper;
> public SerializableResponse<Result> doSomething(Long id, TableModelHelper.Request request);
>
> Generated class:
> void doSomething( java.lang.Long id com.google.gwt.gen2.table.client.TableModelHelper$Request request, AsyncCallback<com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<Result>> callback );
>
> The dollar sign in the generated class seems incorrect since that will not compile.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
> http://xircles.codehaus.org/manage_email
>
>

---

See all the ways you can stay connected to friends and family

     [ http://jira.codehaus.org/browse/QDOX-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte resolved QDOX-166.
---------------------------------

         Assignee: Robert Scholte
       Resolution: Fixed
    Fix Version/s: 1.10

Type.getValue() should return the representation of the class for code-usage. Added Type.getFullyQualifedName() for the FQN

> qdox generates invalid java for nested class references
> -------------------------------------------------------
>
>                 Key: QDOX-166
>                 URL: http://jira.codehaus.org/browse/QDOX-166
>             Project: QDox
>          Issue Type: Bug
>          Components: Parser
>    Affects Versions: 1.9
>         Environment: Apache Maven 2.1.0 (r755702; 2009-03-18 15:10:27-0400)
> Java version: 1.6.0_11
> Java home: F:\devtools\jdk1.6.0_11\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
>            Reporter: David Boon
>            Assignee: Robert Scholte
>             Fix For: 1.10
>
>
> Using the gwt-maven-plugin with qdox version 1.9.  Qdox generates invalid references to nested classes:
> Example:
> Original class:
>    import com.google.gwt.gen2.table.client.TableModelHelper;
>    public SerializableResponse<Result> doSomething(Long id, TableModelHelper.Request request);
> Generated class:
>     void doSomething( java.lang.Long id  com.google.gwt.gen2.table.client.TableModelHelper$Request request, AsyncCallback<com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<Result>> callback );
> The dollar sign in the generated class seems incorrect since that will not compile.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/QDOX-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Hammant updated QDOX-166:
------------------------------

    Fix Version/s:     (was: 1.10)
                   1.9.2

> qdox generates invalid java for nested class references
> -------------------------------------------------------
>
>                 Key: QDOX-166
>                 URL: http://jira.codehaus.org/browse/QDOX-166
>             Project: QDox
>          Issue Type: Bug
>          Components: Parser
>    Affects Versions: 1.9
>         Environment: Apache Maven 2.1.0 (r755702; 2009-03-18 15:10:27-0400)
> Java version: 1.6.0_11
> Java home: F:\devtools\jdk1.6.0_11\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
>            Reporter: David Boon
>            Assignee: Robert Scholte
>             Fix For: 1.9.2
>
>
> Using the gwt-maven-plugin with qdox version 1.9.  Qdox generates invalid references to nested classes:
> Example:
> Original class:
>    import com.google.gwt.gen2.table.client.TableModelHelper;
>    public SerializableResponse<Result> doSomething(Long id, TableModelHelper.Request request);
> Generated class:
>     void doSomething( java.lang.Long id  com.google.gwt.gen2.table.client.TableModelHelper$Request request, AsyncCallback<com.google.gwt.gen2.table.client.TableModelHelper$SerializableResponse<Result>> callback );
> The dollar sign in the generated class seems incorrect since that will not compile.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email