[jira] Created: (RVM-862) 2 static fields using an identic slot

View: New views
2 Messages — Rating Filter:   Alert me  

[jira] Created: (RVM-862) 2 static fields using an identic slot

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

2 static fields using an identic slot
-------------------------------------

                 Key: RVM-862
                 URL: http://jira.codehaus.org/browse/RVM-862
             Project: RVM
          Issue Type: Bug
          Components: Runtime: Object Model
    Affects Versions: 3.1.0
            Reporter: Thomas Preud'homme
            Priority: Minor
         Attachments: static_field_with_same_slot.patch

It seems to me that 2 static fields could use a same slot if a 4 bytes static field is allocated after an 16 bytes static field if nextNumericSlot isn't 8 bytes aligned before the 16 bytes static field is allocated. See lines 324 to 332 of rvm/src/org/jikesrvm/runtime/Statics.java

It looks like a copy paste of the else code path (request for a 8 bytes static field allocation at line 346) occurs for commit 15244, which is perfectly correct in the else block as nextNumericSlot + 2 gives the slot with the higher id of the 3 slots reserved and leave the 2 slots with lower id .for use by the 8 bytes static field.

For me line 331 should be replaced by numericSlotHole = nextNumericSlot + 4;

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Jikesrvm-issues mailing list
Jikesrvm-issues@...
https://lists.sourceforge.net/lists/listinfo/jikesrvm-issues

[jira] Commented: (RVM-862) 2 static fields using an identic slot

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ http://jira.codehaus.org/browse/RVM-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194421#action_194421 ]

Ian Rogers commented on RVM-862:
--------------------------------

Agreed.

> 2 static fields using an identic slot
> -------------------------------------
>
>                 Key: RVM-862
>                 URL: http://jira.codehaus.org/browse/RVM-862
>             Project: RVM
>          Issue Type: Bug
>          Components: Runtime: Object Model
>    Affects Versions: 3.1.0
>            Reporter: Thomas Preud'homme
>            Priority: Minor
>         Attachments: static_field_with_same_slot.patch
>
>   Original Estimate: 5 minutes
>  Remaining Estimate: 5 minutes
>
> It seems to me that 2 static fields could use a same slot if a 4 bytes static field is allocated after an 16 bytes static field if nextNumericSlot isn't 8 bytes aligned before the 16 bytes static field is allocated. See lines 324 to 332 of rvm/src/org/jikesrvm/runtime/Statics.java
> It looks like a copy paste of the else code path (request for a 8 bytes static field allocation at line 346) occurs for commit 15244, which is perfectly correct in the else block as nextNumericSlot + 2 gives the slot with the higher id of the 3 slots reserved and leave the 2 slots with lower id .for use by the 8 bytes static field.
> For me line 331 should be replaced by numericSlotHole = nextNumericSlot + 4;

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Jikesrvm-issues mailing list
Jikesrvm-issues@...
https://lists.sourceforge.net/lists/listinfo/jikesrvm-issues