[jira] Created: (SOLR-1498) RegexTransformer: sourceColName version not handling multiValued fields correctly

RegexTransformer: sourceColName version not handling multiValued fields correctly
---------------------------------------------------------------------------------

                 Key: SOLR-1498
                 URL: https://issues.apache.org/jira/browse/SOLR-1498
             Project: Solr
          Issue Type: Bug
          Components: contrib - DataImportHandler
    Affects Versions: 1.4
         Environment: Windows XP, JDK 6, Tomcat 6
Linux (RedHat), JDK, Tomcat 5
            Reporter: Chantal Ackermann


Versions in use/compared:
Solr 1.3
(Nightly 5th August)
Nightly 22nd September

As RegexTransformer is not different between the two nightlies, the
issue probably appeared before.

ISSUE:
Using RegexTransformer with the 'sourceColName' notation will not populate
multiValued (actually containing multiple values) fields with a list but
instead add only one value per document.

The version with 'groupNames' does.

worked for 1.3 (regression):
<field column="participant" sourceColName="person" regex="([^\|]+)\|.*" />
<field column="role" sourceColName="person"
regex="[^\|]+\|\d+,\d+,\d+,(.*)" />


works for nightly 22nd Sept:
<field column="person" groupNames="participant,role"
regex="([^\|]+)\|\d+,\d+,\d+,(.*)" />

(Both fields are of type solr.StrField and multiValued.)


Comparing the source code of RegexTransformer 1.3 vs. 22nd Sept, I found:

for (Object result : results)
         row.put(col, result);

(lines 106-107 of transformRow() 22nd of Sept)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/SOLR-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-1498:
----------------------------------------

    Fix Version/s: 1.4
         Assignee: Shalin Shekhar Mangar

This seems to be a regression therefore I'm marking it for 1.4

> RegexTransformer: sourceColName version not handling multiValued fields correctly
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-1498
>                 URL: https://issues.apache.org/jira/browse/SOLR-1498
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Windows XP, JDK 6, Tomcat 6
> Linux (RedHat), JDK, Tomcat 5
>            Reporter: Chantal Ackermann
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>
> Versions in use/compared:
> Solr 1.3
> (Nightly 5th August)
> Nightly 22nd September
> As RegexTransformer is not different between the two nightlies, the
> issue probably appeared before.
> ISSUE:
> Using RegexTransformer with the 'sourceColName' notation will not populate
> multiValued (actually containing multiple values) fields with a list but
> instead add only one value per document.
> The version with 'groupNames' does.
> worked for 1.3 (regression):
> <field column="participant" sourceColName="person" regex="([^\|]+)\|.*" />
> <field column="role" sourceColName="person"
> regex="[^\|]+\|\d+,\d+,\d+,(.*)" />
> works for nightly 22nd Sept:
> <field column="person" groupNames="participant,role"
> regex="([^\|]+)\|\d+,\d+,\d+,(.*)" />
> (Both fields are of type solr.StrField and multiValued.)
> Comparing the source code of RegexTransformer 1.3 vs. 22nd Sept, I found:
> for (Object result : results)
>          row.put(col, result);
> (lines 106-107 of transformRow() 22nd of Sept)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/SOLR-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1498:
-----------------------------

    Attachment: SOLR-1498.patch

> RegexTransformer: sourceColName version not handling multiValued fields correctly
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-1498
>                 URL: https://issues.apache.org/jira/browse/SOLR-1498
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Windows XP, JDK 6, Tomcat 6
> Linux (RedHat), JDK, Tomcat 5
>            Reporter: Chantal Ackermann
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-1498.patch
>
>
> Versions in use/compared:
> Solr 1.3
> (Nightly 5th August)
> Nightly 22nd September
> As RegexTransformer is not different between the two nightlies, the
> issue probably appeared before.
> ISSUE:
> Using RegexTransformer with the 'sourceColName' notation will not populate
> multiValued (actually containing multiple values) fields with a list but
> instead add only one value per document.
> The version with 'groupNames' does.
> worked for 1.3 (regression):
> <field column="participant" sourceColName="person" regex="([^\|]+)\|.*" />
> <field column="role" sourceColName="person"
> regex="[^\|]+\|\d+,\d+,\d+,(.*)" />
> works for nightly 22nd Sept:
> <field column="person" groupNames="participant,role"
> regex="([^\|]+)\|\d+,\d+,\d+,(.*)" />
> (Both fields are of type solr.StrField and multiValued.)
> Comparing the source code of RegexTransformer 1.3 vs. 22nd Sept, I found:
> for (Object result : results)
>          row.put(col, result);
> (lines 106-107 of transformRow() 22nd of Sept)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/SOLR-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul resolved SOLR-1498.
------------------------------

    Resolution: Fixed

committed r823798
Thanks Chantal Ackerman

> RegexTransformer: sourceColName version not handling multiValued fields correctly
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-1498
>                 URL: https://issues.apache.org/jira/browse/SOLR-1498
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Windows XP, JDK 6, Tomcat 6
> Linux (RedHat), JDK, Tomcat 5
>            Reporter: Chantal Ackermann
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1498.patch
>
>
> Versions in use/compared:
> Solr 1.3
> (Nightly 5th August)
> Nightly 22nd September
> As RegexTransformer is not different between the two nightlies, the
> issue probably appeared before.
> ISSUE:
> Using RegexTransformer with the 'sourceColName' notation will not populate
> multiValued (actually containing multiple values) fields with a list but
> instead add only one value per document.
> The version with 'groupNames' does.
> worked for 1.3 (regression):
> <field column="participant" sourceColName="person" regex="([^\|]+)\|.*" />
> <field column="role" sourceColName="person"
> regex="[^\|]+\|\d+,\d+,\d+,(.*)" />
> works for nightly 22nd Sept:
> <field column="person" groupNames="participant,role"
> regex="([^\|]+)\|\d+,\d+,\d+,(.*)" />
> (Both fields are of type solr.StrField and multiValued.)
> Comparing the source code of RegexTransformer 1.3 vs. 22nd Sept, I found:
> for (Object result : results)
>          row.put(col, result);
> (lines 106-107 of transformRow() 22nd of Sept)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/SOLR-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul reassigned SOLR-1498:
--------------------------------

    Assignee: Noble Paul  (was: Shalin Shekhar Mangar)

> RegexTransformer: sourceColName version not handling multiValued fields correctly
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-1498
>                 URL: https://issues.apache.org/jira/browse/SOLR-1498
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Windows XP, JDK 6, Tomcat 6
> Linux (RedHat), JDK, Tomcat 5
>            Reporter: Chantal Ackermann
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1498.patch
>
>
> Versions in use/compared:
> Solr 1.3
> (Nightly 5th August)
> Nightly 22nd September
> As RegexTransformer is not different between the two nightlies, the
> issue probably appeared before.
> ISSUE:
> Using RegexTransformer with the 'sourceColName' notation will not populate
> multiValued (actually containing multiple values) fields with a list but
> instead add only one value per document.
> The version with 'groupNames' does.
> worked for 1.3 (regression):
> <field column="participant" sourceColName="person" regex="([^\|]+)\|.*" />
> <field column="role" sourceColName="person"
> regex="[^\|]+\|\d+,\d+,\d+,(.*)" />
> works for nightly 22nd Sept:
> <field column="person" groupNames="participant,role"
> regex="([^\|]+)\|\d+,\d+,\d+,(.*)" />
> (Both fields are of type solr.StrField and multiValued.)
> Comparing the source code of RegexTransformer 1.3 vs. 22nd Sept, I found:
> for (Object result : results)
>          row.put(col, result);
> (lines 106-107 of transformRow() 22nd of Sept)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/SOLR-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773075#action_12773075 ]

Chantal Ackermann commented on SOLR-1498:
-----------------------------------------

Tested with the current RC 1.4.0. Works fine!

> RegexTransformer: sourceColName version not handling multiValued fields correctly
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-1498
>                 URL: https://issues.apache.org/jira/browse/SOLR-1498
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Windows XP, JDK 6, Tomcat 6
> Linux (RedHat), JDK, Tomcat 5
>            Reporter: Chantal Ackermann
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1498.patch
>
>
> Versions in use/compared:
> Solr 1.3
> (Nightly 5th August)
> Nightly 22nd September
> As RegexTransformer is not different between the two nightlies, the
> issue probably appeared before.
> ISSUE:
> Using RegexTransformer with the 'sourceColName' notation will not populate
> multiValued (actually containing multiple values) fields with a list but
> instead add only one value per document.
> The version with 'groupNames' does.
> worked for 1.3 (regression):
> <field column="participant" sourceColName="person" regex="([^\|]+)\|.*" />
> <field column="role" sourceColName="person"
> regex="[^\|]+\|\d+,\d+,\d+,(.*)" />
> works for nightly 22nd Sept:
> <field column="person" groupNames="participant,role"
> regex="([^\|]+)\|\d+,\d+,\d+,(.*)" />
> (Both fields are of type solr.StrField and multiValued.)
> Comparing the source code of RegexTransformer 1.3 vs. 22nd Sept, I found:
> for (Object result : results)
>          row.put(col, result);
> (lines 106-107 of transformRow() 22nd of Sept)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.