[jira] Created: (SOLR-797) Construct EmbeddedSolrServer response without serializing/parsing

Construct EmbeddedSolrServer response without serializing/parsing
-----------------------------------------------------------------

                 Key: SOLR-797
                 URL: https://issues.apache.org/jira/browse/SOLR-797
             Project: Solr
          Issue Type: Improvement
          Components: clients - java
    Affects Versions: 1.3
            Reporter: Jonathan Lee


Currently, the EmbeddedSolrServer serializes the response and reparses in order to create the final NamedList response.  From the comment in EmbeddedSolrServer.java, the goal is to:
* convert the response directly into a named list

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/SOLR-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Lee updated SOLR-797:
------------------------------

    Priority: Minor  (was: Major)

> Construct EmbeddedSolrServer response without serializing/parsing
> -----------------------------------------------------------------
>
>                 Key: SOLR-797
>                 URL: https://issues.apache.org/jira/browse/SOLR-797
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Jonathan Lee
>            Priority: Minor
>
> Currently, the EmbeddedSolrServer serializes the response and reparses in order to create the final NamedList response.  From the comment in EmbeddedSolrServer.java, the goal is to:
> * convert the response directly into a named list

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/SOLR-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Lee updated SOLR-797:
------------------------------

    Attachment: SOLR-797.patch

This patch contains a first stab at transforming the NamedList without serializing it then parsing it from the serialized form.

From what I can tell, all the fields (headers, facets, spelling, etc) returned from the handler in the response is valid for output except that references to actual documents need to be resolved.  This patch borrows code from NamedListCodec.java and BinaryResponseWriter.java to resolve the documents.

> Construct EmbeddedSolrServer response without serializing/parsing
> -----------------------------------------------------------------
>
>                 Key: SOLR-797
>                 URL: https://issues.apache.org/jira/browse/SOLR-797
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Jonathan Lee
>            Priority: Minor
>         Attachments: SOLR-797.patch
>
>
> Currently, the EmbeddedSolrServer serializes the response and reparses in order to create the final NamedList response.  From the comment in EmbeddedSolrServer.java, the goal is to:
> * convert the response directly into a named list

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/SOLR-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-797:
---------------------------------------

    Fix Version/s: 1.5

Marking for 1.5

> Construct EmbeddedSolrServer response without serializing/parsing
> -----------------------------------------------------------------
>
>                 Key: SOLR-797
>                 URL: https://issues.apache.org/jira/browse/SOLR-797
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Jonathan Lee
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: SOLR-797.patch
>
>
> Currently, the EmbeddedSolrServer serializes the response and reparses in order to create the final NamedList response.  From the comment in EmbeddedSolrServer.java, the goal is to:
> * convert the response directly into a named list

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/SOLR-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Klochkov updated SOLR-797:
---------------------------------

    Attachment: SOLR-797.patch

Sometime ago I made such an improvement  and now decided to share it. Looks like this is the right issue. Attaching my patch, please use it if it looks better. We use our patched version without problems for several months, so it's tested in at some level.

> Construct EmbeddedSolrServer response without serializing/parsing
> -----------------------------------------------------------------
>
>                 Key: SOLR-797
>                 URL: https://issues.apache.org/jira/browse/SOLR-797
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Jonathan Lee
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: SOLR-797.patch, SOLR-797.patch
>
>
> Currently, the EmbeddedSolrServer serializes the response and reparses in order to create the final NamedList response.  From the comment in EmbeddedSolrServer.java, the goal is to:
> * convert the response directly into a named list

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.