[jira] Created: (TAP5-760) The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice

The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice
-------------------------------------------------------------------------------------------

                 Key: TAP5-760
                 URL: https://issues.apache.org/jira/browse/TAP5-760
             Project: Tapestry 5
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.1.0.5
            Reporter: Howard M. Lewis Ship
            Priority: Minor


You end up with methods like onValidateFormFromLogin() which is just asking for trouble.

onFormValidateFromLogin() is a bit better.

Obviously, we keep the old name as well ... have to fire two events at the validate form stage.

What would be a better name?  Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725821#action_12725821 ]

Massimo Lusetti commented on TAP5-760:
--------------------------------------

I really don't see a problem with the just-"validate" name.

> The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice
> -------------------------------------------------------------------------------------------
>
>                 Key: TAP5-760
>                 URL: https://issues.apache.org/jira/browse/TAP5-760
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name?  Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.