[jira] Created: (TOMAHAWK-1436) t:checkbox disregards disabled property

View: New views
3 Messages — Rating Filter:   Alert me  

[jira] Created: (TOMAHAWK-1436) t:checkbox disregards disabled property

by My Faces - Dev mailing list :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

t:checkbox disregards disabled property
---------------------------------------

                 Key: TOMAHAWK-1436
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1436
             Project: MyFaces Tomahawk
          Issue Type: Bug
    Affects Versions: 1.1.9
         Environment: Windows XP SP2, Tomcat 6.0.18
            Reporter: Bozhidar Bozhanov


The title says it all - when I use <t:selectManyCheckBox> with layout="spread", the checkboxes rendered by <t:checkbox are never disabled, even if the corresponding selectItem is set to disabled. The problem doesn't occur when <t:selectManyCheckBox> is used with other layouts (and hence without <t:checkbox>)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-1436) t:checkbox disregards disabled property

by My Faces - Dev mailing list :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/TOMAHAWK-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729966#action_12729966 ]

Bozhidar Bozhanov commented on TOMAHAWK-1436:
---------------------------------------------

Well, I'm going to work-around the issue by extending the Renderer, and adding this:

boolean disabled = isDisabled(facesContext, uiSelectMany);
if (!disabled) {
        disabled = selectItem.isDisabled();
}

Meaning - if the whole checkbox-group is disabled - disable the checkbox, and if not - see whether the current selectItem should be disabled.

I will see if it works as expected, and if it does, and I get no reply here, I will apply for committer and add it there myself ;)

Greetings

> t:checkbox disregards disabled property
> ---------------------------------------
>
>                 Key: TOMAHAWK-1436
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1436
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.9
>         Environment: Windows XP SP2, Tomcat 6.0.18
>            Reporter: Bozhidar Bozhanov
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The title says it all - when I use <t:selectManyCheckBox> with layout="spread", the checkboxes rendered by <t:checkbox are never disabled, even if the corresponding selectItem is set to disabled. The problem doesn't occur when <t:selectManyCheckBox> is used with other layouts (and hence without <t:checkbox>)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-1436) t:checkbox disregards disabled property

by My Faces - Dev mailing list :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/TOMAHAWK-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729968#action_12729968 ]

Bozhidar Bozhanov commented on TOMAHAWK-1436:
---------------------------------------------

I saw that the selectItem.isDisabled is taken into account in the repository (and probably in the Snapshot build).
However, I think that it is better to check both the parent component (the uiSelectMany), and if it is disabled, to disable all checkboxes.

> t:checkbox disregards disabled property
> ---------------------------------------
>
>                 Key: TOMAHAWK-1436
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1436
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.9
>         Environment: Windows XP SP2, Tomcat 6.0.18
>            Reporter: Bozhidar Bozhanov
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The title says it all - when I use <t:selectManyCheckBox> with layout="spread", the checkboxes rendered by <t:checkbox are never disabled, even if the corresponding selectItem is set to disabled. The problem doesn't occur when <t:selectManyCheckBox> is used with other layouts (and hence without <t:checkbox>)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.