[jira] Created: (TQL-16) Geronimo pool doesn't remove closed connections when using TranQL vendor Oracle XAMCF SQL connection

Geronimo pool doesn't remove closed connections when using TranQL vendor Oracle XAMCF SQL connection
----------------------------------------------------------------------------------------------------

                 Key: TQL-16
                 URL: http://jira.codehaus.org/browse/TQL-16
             Project: TranQL
          Issue Type: Bug
         Environment: Apache ServiceMix 3.3, geronimo-connector-2.1.2.jar
            Reporter: Rafal Rusin
         Attachments: tranql-vendor-oracle-closed-connections.patch

This exception:

Caused by: java.sql.SQLException: Connection Closed
        at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:112)
        at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:146)
        at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:208)
        at oracle.jdbc.driver.PhysicalConnection.prepareStatement(PhysicalConnection.java:840)
        at oracle.jdbc.driver.PhysicalConnection.prepareStatement(PhysicalConnection.java:759)
        at oracle.jdbc.OracleConnectionWrapper.prepareStatement(OracleConnectionWrapper.java:92)
        at org.tranql.connector.jdbc.ConnectionHandle.prepareStatement(ConnectionHandle.java:231)
        at org.apache.ode.scheduler.simple.JdbcDelegate.dequeueImmediate(JdbcDelegate.java:172)
        ... 8 more

shows endlessly after oracle database restart while server is running.
Related discussion was here:
http://markmail.org/thread/nsrnmwo5yoorphhs

The problem is that OracleExceptionSorter doesn't recognize Closed Connection as fatal exception and therefore it's not removed from Geronimo's connection pool.
So I added oracle code 17008 (http://www.dbmotive.com/oracle_error_codes.php?errcode=17008) as a fatal exception and it resolved this problem.
Attached is a patch.


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/TQL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks reassigned TQL-16:
-------------------------------

    Assignee: David Jencks

> Geronimo pool doesn't remove closed connections when using TranQL vendor Oracle XAMCF SQL connection
> ----------------------------------------------------------------------------------------------------
>
>                 Key: TQL-16
>                 URL: http://jira.codehaus.org/browse/TQL-16
>             Project: TranQL
>          Issue Type: Bug
>         Environment: Apache ServiceMix 3.3, geronimo-connector-2.1.2.jar
>            Reporter: Rafal Rusin
>            Assignee: David Jencks
>         Attachments: tranql-vendor-oracle-closed-connections.patch
>
>
> This exception:
> Caused by: java.sql.SQLException: Connection Closed
>         at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:112)
>         at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:146)
>         at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:208)
>         at oracle.jdbc.driver.PhysicalConnection.prepareStatement(PhysicalConnection.java:840)
>         at oracle.jdbc.driver.PhysicalConnection.prepareStatement(PhysicalConnection.java:759)
>         at oracle.jdbc.OracleConnectionWrapper.prepareStatement(OracleConnectionWrapper.java:92)
>         at org.tranql.connector.jdbc.ConnectionHandle.prepareStatement(ConnectionHandle.java:231)
>         at org.apache.ode.scheduler.simple.JdbcDelegate.dequeueImmediate(JdbcDelegate.java:172)
>         ... 8 more
> shows endlessly after oracle database restart while server is running.
> Related discussion was here:
> http://markmail.org/thread/nsrnmwo5yoorphhs
> The problem is that OracleExceptionSorter doesn't recognize Closed Connection as fatal exception and therefore it's not removed from Geronimo's connection pool.
> So I added oracle code 17008 (http://www.dbmotive.com/oracle_error_codes.php?errcode=17008) as a fatal exception and it resolved this problem.
> Attached is a patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/TQL-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=192194#action_192194 ]

David Jencks commented on TQL-16:
---------------------------------

I applied the patch in rev 664 but really wonder if you are actually using the tranql-oracle-xa wrapper?  If the xa wrapper doesn't close the connection without needing the OracleExceptionSorter to tell it to something is very wrong with the oracle xa datasource.

If you know enough about the oracle drivers to identify an oracle ConnectionPoolDataSource we should be able to improve the local wrapper so it doesn't need the OracleExceptionSorter either.

> Geronimo pool doesn't remove closed connections when using TranQL vendor Oracle XAMCF SQL connection
> ----------------------------------------------------------------------------------------------------
>
>                 Key: TQL-16
>                 URL: http://jira.codehaus.org/browse/TQL-16
>             Project: TranQL
>          Issue Type: Bug
>         Environment: Apache ServiceMix 3.3, geronimo-connector-2.1.2.jar
>            Reporter: Rafal Rusin
>            Assignee: David Jencks
>         Attachments: tranql-vendor-oracle-closed-connections.patch
>
>
> This exception:
> Caused by: java.sql.SQLException: Connection Closed
>         at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:112)
>         at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:146)
>         at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:208)
>         at oracle.jdbc.driver.PhysicalConnection.prepareStatement(PhysicalConnection.java:840)
>         at oracle.jdbc.driver.PhysicalConnection.prepareStatement(PhysicalConnection.java:759)
>         at oracle.jdbc.OracleConnectionWrapper.prepareStatement(OracleConnectionWrapper.java:92)
>         at org.tranql.connector.jdbc.ConnectionHandle.prepareStatement(ConnectionHandle.java:231)
>         at org.apache.ode.scheduler.simple.JdbcDelegate.dequeueImmediate(JdbcDelegate.java:172)
>         ... 8 more
> shows endlessly after oracle database restart while server is running.
> Related discussion was here:
> http://markmail.org/thread/nsrnmwo5yoorphhs
> The problem is that OracleExceptionSorter doesn't recognize Closed Connection as fatal exception and therefore it's not removed from Geronimo's connection pool.
> So I added oracle code 17008 (http://www.dbmotive.com/oracle_error_codes.php?errcode=17008) as a fatal exception and it resolved this problem.
> Attached is a patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email