[jira] Created: (TRINIDAD-1598) Trinidad2 - Make dialog compatible with JSF 2.0

[My Faces - Dev mailing list]

Trinidad2  -  Make dialog compatible with JSF 2.0
-------------------------------------------------

                 Key: TRINIDAD-1598
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1598
             Project: MyFaces Trinidad
          Issue Type: Bug
    Affects Versions: 2.0.0-core
         Environment: trinidad 2 branch, RI 2.0.0RC2
            Reporter: Martin Koci


The dialog framework does not work with JSF 2.0: opening new window shows "___ADF___ cannot be found".
Problem can be reproduced with trinidad-demo, dialog example (launchDialog.jspx)

Causation: with JSF 2.0 exactly two types of VDL are supported: JSP and Facelets,
but dialog framework uses java code for component tree creation (there is no real resource ___ADF___)

Possible solution: rewrite dialog to javax.faces.view.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

     [ https://issues.apache.org/jira/browse/TRINIDAD-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Koci updated TRINIDAD-1598:
----------------------------------

    Status: Patch Available  (was: Open)

> Trinidad2  -  Make dialog compatible with JSF 2.0
> -------------------------------------------------
>
>                 Key: TRINIDAD-1598
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1598
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 2.0.0-core
>         Environment: trinidad 2 branch, RI 2.0.0RC2
>            Reporter: Martin Koci
>
> The dialog framework does not work with JSF 2.0: opening new window shows "___ADF___ cannot be found".
> Problem can be reproduced with trinidad-demo, dialog example (launchDialog.jspx)
> Causation: with JSF 2.0 exactly two types of VDL are supported: JSP and Facelets,
> but dialog framework uses java code for component tree creation (there is no real resource ___ADF___)
> Possible solution: rewrite dialog to javax.faces.view.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768794#action_12768794 ]

Max Starets commented on TRINIDAD-1598:
---------------------------------------

Martin,

InternalView is a part of Trinidad's public API, and we cannot just get rid of it (there are many customers already using it).
So the InternalView is here to stay... We may be able to adapt InternalView instances to the instances of VDL in the future, but
the most expedient and simple fix for the dialog problem is overriding  getViewDeclarationLanguage:

public ViewDeclarationLanguage getViewDeclarationLanguage(FacesContext context,
                                                            String viewId)
  {
    // InternalViews will not use ViewDeclarationLanguage processors,
    // since they do essentially the same job themselves.
    InternalView internal = _getInternalView(context, viewId);
    if (internal != null)
    {
      return null;
    }
    return _delegate.getViewDeclarationLanguage(context, viewId);
  }

> Trinidad2  -  Make dialog compatible with JSF 2.0
> -------------------------------------------------
>
>                 Key: TRINIDAD-1598
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1598
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 2.0.0-core
>         Environment: trinidad 2 branch, RI 2.0.0RC2
>            Reporter: Martin Koci
>         Attachments: patch.txt, ViewHandlerImpl.diff
>
>
> The dialog framework does not work with JSF 2.0: opening new window shows "___ADF___ cannot be found".
> Problem can be reproduced with trinidad-demo, dialog example (launchDialog.jspx)
> Causation: with JSF 2.0 exactly two types of VDL are supported: JSP and Facelets,
> but dialog framework uses java code for component tree creation (there is no real resource ___ADF___)
> Possible solution: rewrite dialog to javax.faces.view.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

     [ https://issues.apache.org/jira/browse/TRINIDAD-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated TRINIDAD-1598:
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-core
         Assignee: Matthias Weßendorf
           Status: Resolved  (was: Patch Available)

> Trinidad2  -  Make dialog compatible with JSF 2.0
> -------------------------------------------------
>
>                 Key: TRINIDAD-1598
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1598
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 2.0.0-core
>         Environment: trinidad 2 branch, RI 2.0.0RC2
>            Reporter: Martin Koci
>            Assignee: Matthias Weßendorf
>             Fix For: 2.0.0-core
>
>         Attachments: patch.txt, ViewHandlerImpl.diff
>
>
> The dialog framework does not work with JSF 2.0: opening new window shows "___ADF___ cannot be found".
> Problem can be reproduced with trinidad-demo, dialog example (launchDialog.jspx)
> Causation: with JSF 2.0 exactly two types of VDL are supported: JSP and Facelets,
> but dialog framework uses java code for component tree creation (there is no real resource ___ADF___)
> Possible solution: rewrite dialog to javax.faces.view.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.