|

»

»

[jira] Created: (VELTOOLS-117) standard tools keys not overwrittable when running in deprecationSupportMode

View: New views

4 Messages — Rating Filter: Alert me

	[jira] Created: (VELTOOLS-117) standard tools keys not overwrittable when running in deprecationSupportMode by Velocity - Dev mailing list-2 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message standard tools keys not overwrittable when running in deprecationSupportMode ---------------------------------------------------------------------------- Key: VELTOOLS-117 URL: https://issues.apache.org/jira/browse/VELTOOLS-117 Project: Velocity Tools Issue Type: Bug Components: VelocityView Affects Versions: 2.x Reporter: Claude Brisson Priority: Minor Is it intended that standard tools keys not overwrittable when running in deprecationSupportMode? Contrary to the new view.ViewtoolContext, The view.context.ChainedContext does not allow standard tools keys to be overwritten. If I remember correctly, tools keys were not overwrittable in 1.x. So it may be regarded as a normal behaviour not to allow this in deprecationSupportMode, but it is not, since tools keys have changed! Better allow tools keys to be overwrittable, since this hardly breaks compatibility (maybe for broken templates). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@...
	[jira] Commented: (VELTOOLS-117) standard tools keys not overwrittable when running in deprecationSupportMode by Velocity - Dev mailing list-2 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/VELTOOLS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712440#action_12712440 ] Nathan Bubna commented on VELTOOLS-117: --------------------------------------- You're right. We should allow tool keys to be overwritten by default regardless of deprecationSupportMode. Any chance you want to fix this? I don't want to keep doing everything if it is encouraging the rest of you to tune out and miss votes and such. :) > standard tools keys not overwrittable when running in deprecationSupportMode > ---------------------------------------------------------------------------- > > Key: VELTOOLS-117 > URL: https://issues.apache.org/jira/browse/VELTOOLS-117 > Project: Velocity Tools > Issue Type: Bug > Components: VelocityView > Affects Versions: 2.x > Reporter: Claude Brisson > Priority: Minor > > Is it intended that standard tools keys not overwrittable when running in deprecationSupportMode? > Contrary to the new view.ViewtoolContext, The view.context.ChainedContext does not allow standard tools keys to be overwritten. > If I remember correctly, tools keys were not overwrittable in 1.x. So it may be regarded as a normal behaviour not to allow this in deprecationSupportMode, but it is not, since tools keys have changed! Better allow tools keys to be overwrittable, since this hardly breaks compatibility (maybe for broken templates). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@...
	[jira] Resolved: (VELTOOLS-117) standard tools keys not overwrittable when running in deprecationSupportMode by Velocity - Dev mailing list-2 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/VELTOOLS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-117. ------------------------------------- Resolution: Invalid Fix Version/s: 2.x My mistake. I had an old snapshot jar in the classpath. The behaviour is correct since the last ToolsViewContext rewrite. > standard tools keys not overwrittable when running in deprecationSupportMode > ---------------------------------------------------------------------------- > > Key: VELTOOLS-117 > URL: https://issues.apache.org/jira/browse/VELTOOLS-117 > Project: Velocity Tools > Issue Type: Bug > Components: VelocityView > Affects Versions: 2.x > Reporter: Claude Brisson > Priority: Minor > Fix For: 2.x > > > Is it intended that standard tools keys not overwrittable when running in deprecationSupportMode? > Contrary to the new view.ViewtoolContext, The view.context.ChainedContext does not allow standard tools keys to be overwritten. > If I remember correctly, tools keys were not overwrittable in 1.x. So it may be regarded as a normal behaviour not to allow this in deprecationSupportMode, but it is not, since tools keys have changed! Better allow tools keys to be overwrittable, since this hardly breaks compatibility (maybe for broken templates). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@...
	[jira] Closed: (VELTOOLS-117) standard tools keys not overwrittable when running in deprecationSupportMode by Velocity - Dev mailing list-2 :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/VELTOOLS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson closed VELTOOLS-117. ----------------------------------- > standard tools keys not overwrittable when running in deprecationSupportMode > ---------------------------------------------------------------------------- > > Key: VELTOOLS-117 > URL: https://issues.apache.org/jira/browse/VELTOOLS-117 > Project: Velocity Tools > Issue Type: Bug > Components: VelocityView > Affects Versions: 2.x > Reporter: Claude Brisson > Priority: Minor > Fix For: 2.x > > > Is it intended that standard tools keys not overwrittable when running in deprecationSupportMode? > Contrary to the new view.ViewtoolContext, The view.context.ChainedContext does not allow standard tools keys to be overwritten. > If I remember correctly, tools keys were not overwrittable in 1.x. So it may be regarded as a normal behaviour not to allow this in deprecationSupportMode, but it is not, since tools keys have changed! Better allow tools keys to be overwrittable, since this hardly breaks compatibility (maybe for broken templates). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@...