[jira] Created: (WSS-209) NPE in AbstractCrypto.getCryptoProvider()

NPE in AbstractCrypto.getCryptoProvider()
------------------------------------------

                 Key: WSS-209
                 URL: https://issues.apache.org/jira/browse/WSS-209
             Project: WSS4J
          Issue Type: Bug
          Components: WSS4J Core
    Affects Versions: 1.5.8
            Reporter: Matthias Germann
            Assignee: Ruchith Udayanga Fernando


AbstractCrypto.getCryptoProvider() throws a NullPointerException when the constructor of AbstractCrypto(Properties p) was called with null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@...
For additional commands, e-mail: wss4j-dev-help@...

     [ https://issues.apache.org/jira/browse/WSS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Germann updated WSS-209:
---------------------------------

    Attachment: AbstractCrypto.java.patch

Patch

> NPE in AbstractCrypto.getCryptoProvider()
> ------------------------------------------
>
>                 Key: WSS-209
>                 URL: https://issues.apache.org/jira/browse/WSS-209
>             Project: WSS4J
>          Issue Type: Bug
>          Components: WSS4J Core
>    Affects Versions: 1.5.8
>            Reporter: Matthias Germann
>            Assignee: Ruchith Udayanga Fernando
>         Attachments: AbstractCrypto.java.patch
>
>
> AbstractCrypto.getCryptoProvider() throws a NullPointerException when the constructor of AbstractCrypto(Properties p) was called with null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@...
For additional commands, e-mail: wss4j-dev-help@...

     [ https://issues.apache.org/jira/browse/WSS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Germann updated WSS-209:
---------------------------------

    Description: AbstractCrypto.getCryptoProvider() throws a NullPointerException when the constructor AbstractCrypto(Properties p) was called with null.   (was: AbstractCrypto.getCryptoProvider() throws a NullPointerException when the constructor of AbstractCrypto(Properties p) was called with null. )

> NPE in AbstractCrypto.getCryptoProvider()
> ------------------------------------------
>
>                 Key: WSS-209
>                 URL: https://issues.apache.org/jira/browse/WSS-209
>             Project: WSS4J
>          Issue Type: Bug
>          Components: WSS4J Core
>    Affects Versions: 1.5.8
>            Reporter: Matthias Germann
>            Assignee: Ruchith Udayanga Fernando
>         Attachments: AbstractCrypto.java.patch
>
>
> AbstractCrypto.getCryptoProvider() throws a NullPointerException when the constructor AbstractCrypto(Properties p) was called with null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@...
For additional commands, e-mail: wss4j-dev-help@...

    [ https://issues.apache.org/jira/browse/WSS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766571#action_12766571 ]

Colm O hEigeartaigh commented on WSS-209:
-----------------------------------------


Hi Matthias,

What scenario did you run into this problem in?

Colm.

> NPE in AbstractCrypto.getCryptoProvider()
> ------------------------------------------
>
>                 Key: WSS-209
>                 URL: https://issues.apache.org/jira/browse/WSS-209
>             Project: WSS4J
>          Issue Type: Bug
>          Components: WSS4J Core
>    Affects Versions: 1.5.8
>            Reporter: Matthias Germann
>            Assignee: Ruchith Udayanga Fernando
>         Attachments: AbstractCrypto.java.patch
>
>
> AbstractCrypto.getCryptoProvider() throws a NullPointerException when the constructor AbstractCrypto(Properties p) was called with null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@...
For additional commands, e-mail: wss4j-dev-help@...

    [ https://issues.apache.org/jira/browse/WSS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766872#action_12766872 ]

Matthias Germann commented on WSS-209:
--------------------------------------

Hi Colm

I have written a Subclass of AbstractCrypto for a PKCS#11Keystore  (Smartcard) which is loaded in a different way than a JKS or PKCS#12 Keystore (File-based). I can bypass the Keystore initialization in the constructor of  AbstractCrypto by passing a null-value for the Properties object.

As it is legal to pass a null-value for the Properties Object, getCryptoProvider() should do a null-check as getDefaultX509Alias() does.

Regards,
Matthias

> NPE in AbstractCrypto.getCryptoProvider()
> ------------------------------------------
>
>                 Key: WSS-209
>                 URL: https://issues.apache.org/jira/browse/WSS-209
>             Project: WSS4J
>          Issue Type: Bug
>          Components: WSS4J Core
>    Affects Versions: 1.5.8
>            Reporter: Matthias Germann
>            Assignee: Ruchith Udayanga Fernando
>         Attachments: AbstractCrypto.java.patch
>
>
> AbstractCrypto.getCryptoProvider() throws a NullPointerException when the constructor AbstractCrypto(Properties p) was called with null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@...
For additional commands, e-mail: wss4j-dev-help@...

     [ https://issues.apache.org/jira/browse/WSS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colm O hEigeartaigh resolved WSS-209.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6
                   1.5.9
         Assignee: Colm O hEigeartaigh  (was: Ruchith Udayanga Fernando)


Patch applied, thanks.

Colm.

> NPE in AbstractCrypto.getCryptoProvider()
> ------------------------------------------
>
>                 Key: WSS-209
>                 URL: https://issues.apache.org/jira/browse/WSS-209
>             Project: WSS4J
>          Issue Type: Bug
>          Components: WSS4J Core
>    Affects Versions: 1.5.8
>            Reporter: Matthias Germann
>            Assignee: Colm O hEigeartaigh
>             Fix For: 1.5.9, 1.6
>
>         Attachments: AbstractCrypto.java.patch
>
>
> AbstractCrypto.getCryptoProvider() throws a NullPointerException when the constructor AbstractCrypto(Properties p) was called with null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@...
For additional commands, e-mail: wss4j-dev-help@...

     [ https://issues.apache.org/jira/browse/WSS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colm O hEigeartaigh closed WSS-209.
-----------------------------------

> NPE in AbstractCrypto.getCryptoProvider()
> ------------------------------------------
>
>                 Key: WSS-209
>                 URL: https://issues.apache.org/jira/browse/WSS-209
>             Project: WSS4J
>          Issue Type: Bug
>          Components: WSS4J Core
>    Affects Versions: 1.5.8
>            Reporter: Matthias Germann
>            Assignee: Colm O hEigeartaigh
>             Fix For: 1.5.9, 1.6
>
>         Attachments: AbstractCrypto.java.patch
>
>
> AbstractCrypto.getCryptoProvider() throws a NullPointerException when the constructor AbstractCrypto(Properties p) was called with null.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@...
For additional commands, e-mail: wss4j-dev-help@...