[jira] Created: (XBEAN-126) ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'

ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
---------------------------------------------------------------------------------------

                 Key: XBEAN-126
                 URL: https://issues.apache.org/jira/browse/XBEAN-126
             Project: XBean
          Issue Type: Bug
          Components: finder
            Reporter: Kevan Miller
             Fix For: 3.5


Deployment of an opensso.war file is failing in Geronimo with the following:

java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
        at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
        at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
        at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)

webservices-tools.jar contains multiple files of the following form:

  -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
  -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
  -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
  -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
  -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class

'1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang updated XBEAN-126:
------------------------------

    Attachment: xbean-126.patch

This jira is caused by  replacement between  "/" and "."  back and forth. The patch attached keep '.' in path by encoding '.' to another char before replacing all '/' to '.'

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>             Fix For: 3.5
>
>         Attachments: xbean-126.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang updated XBEAN-126:
------------------------------

    Fix Version/s:     (was: 3.5)
                   3.6

Changed fix version  from 3.5 to 3.6

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>            Assignee: Shawn Jiang
>             Fix For: 3.6
>
>         Attachments: xbean-126.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang reassigned XBEAN-126:
---------------------------------

    Assignee: Shawn Jiang

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>            Assignee: Shawn Jiang
>             Fix For: 3.6
>
>         Attachments: xbean-126.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712712#action_12712712 ]

David Jencks commented on XBEAN-126:
------------------------------------

a directory with a "." in it does not contain a class, so I would like to consider just catching and ignoring the exception rather than doing extra string manipulation.

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>            Assignee: Shawn Jiang
>             Fix For: 3.6
>
>         Attachments: xbean-126.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712812#action_12712812 ]

David Blevins commented on XBEAN-126:
-------------------------------------

Great point, David.  Definitely the simpler approach.

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>            Assignee: Shawn Jiang
>             Fix For: 3.6
>
>         Attachments: xbean-126.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712841#action_12712841 ]

Shawn Jiang commented on XBEAN-126:
-----------------------------------

Thanks for your valuable comments, I'll make a new patch to just catch and skip the exception.  Maybe plus a warning log.

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>            Assignee: Shawn Jiang
>             Fix For: 3.6
>
>         Attachments: xbean-126.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang updated XBEAN-126:
------------------------------

    Attachment: xbean-126_updated.patch

This is the new patch to just skip the illegal class in a jar file. Thanks.

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>            Assignee: Shawn Jiang
>             Fix For: 3.6
>
>         Attachments: xbean-126_updated.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang updated XBEAN-126:
------------------------------

    Attachment:     (was: xbean-126.patch)

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>            Assignee: Shawn Jiang
>             Fix For: 3.6
>
>         Attachments: xbean-126_updated.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins reassigned XBEAN-126:
-----------------------------------

    Assignee: David Blevins  (was: Shawn Jiang)

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>            Assignee: David Blevins
>             Fix For: 3.6
>
>         Attachments: xbean-126_updated.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/XBEAN-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins closed XBEAN-126.
-------------------------------

    Resolution: Fixed

Sending        xbean-finder/src/main/java/org/apache/xbean/finder/ClassFinder.java
Transmitting file data .
Committed revision 784990.

Went with a slightly simpler fix.  Also made sure this was fixed for both directory and jar scanning.

> ClassFinder throwing "Could not load exceptions" on "classes" whose path includes a '.'
> ---------------------------------------------------------------------------------------
>
>                 Key: XBEAN-126
>                 URL: https://issues.apache.org/jira/browse/XBEAN-126
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>            Reporter: Kevan Miller
>            Assignee: David Blevins
>             Fix For: 3.6
>
>         Attachments: xbean-126_updated.patch
>
>
> Deployment of an opensso.war file is failing in Geronimo with the following:
> java.lang.Exception: Could not load 1/0/org/apache/xml/resolver/tools/ResolvingXMLReader.class
>         at org.apache.xbean.finder.ClassFinder.readClassDef(ClassFinder.java:726)
>         at org.apache.xbean.finder.ClassFinder.<init>(ClassFinder.java:141)
>         at org.apache.geronimo.jaxws.builder.WARWebServiceFinder.discoverWebServices(WARWebServiceFinder.java:154)
> webservices-tools.jar contains multiple files of the following form:
>   -rw-r--r--       287  28-Mar-2005  12:20:36  1.0/com/sun/codemodel/CodeWriter.class
>   -rw-r--r--       931  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JAnonymousClass.class
>   -rw-r--r--      1939  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArray.class
>   -rw-r--r--       691  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass$1.class
>   -rw-r--r--      2365  28-Mar-2005  12:20:38  1.0/com/sun/codemodel/JArrayClass.class
> '1.0' is being converted to '1/0' and the subsequent load is failing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.