[jira] Created: (XFIRE-857) Resolver resolves classpath resources incorrect

Resolver resolves classpath resources incorrect
-----------------------------------------------

                 Key: XFIRE-857
                 URL: http://jira.codehaus.org/browse/XFIRE-857
             Project: XFire
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.2.4
         Environment: WinXP Java 1.5.09
            Reporter: Philippe Jacot
         Assigned To: Dan Diephouse


When I pass a WSDL URL to the XFireClientFactoryBean of the format "classpath:...../bla.wsdl" I get an error in the method makeClient() as uri.toURL() throws an IllegalArgumentException("URI is not absolute").

The Resolver resolves the file correctly to a String of the form "file:/d:/..../bla.wsdl" but when the URI object is created (in the method tryClasspath(String) of Resolver) with uri = new URI(URLEncoder.encode(decodedURL, "UTF-8")) URI does not find the scheme (I guess this should be file:/) and therefore thinks its a relative URI.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/XFIRE-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182679#action_182679 ]

Nils Eckert commented on XFIRE-857:
-----------------------------------

The problem seems to be the UTF-8 encoding in

{code:title=org.codehaus.xfire.util.Resolver.tryClasspath(String)}
    uri = new URI(URLEncoder.encode(decodedURL, "UTF-8"));
{code}

This leads to the fact, that the URI Constructor can't extract the scheme and the URI is treated as "not absolute".

I can't understand why the urlString has to be encoded before using it for the URI Constructor.

The problem could be solved for me if remove the encoding. I will attach a patch.

Regards
Nils Eckert

> Resolver resolves classpath resources incorrect
> -----------------------------------------------
>
>                 Key: XFIRE-857
>                 URL: http://jira.codehaus.org/browse/XFIRE-857
>             Project: XFire
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.4
>         Environment: WinXP Java 1.5.09
>            Reporter: Philippe Jacot
>            Assignee: Dan Diephouse
>
> When I pass a WSDL URL to the XFireClientFactoryBean of the format "classpath:...../bla.wsdl" I get an error in the method makeClient() as uri.toURL() throws an IllegalArgumentException("URI is not absolute").
> The Resolver resolves the file correctly to a String of the form "file:/d:/..../bla.wsdl" but when the URI object is created (in the method tryClasspath(String) of Resolver) with uri = new URI(URLEncoder.encode(decodedURL, "UTF-8")) URI does not find the scheme (I guess this should be file:/) and therefore thinks its a relative URI.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/XFIRE-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182679#action_182679 ]

Nils Eckert commented on XFIRE-857:
-----------------------------------

The problem seems to be the UTF-8 encoding in

{code:title=org.codehaus.xfire.util.Resolver.tryClasspath(String)}
    uri = new URI(URLEncoder.encode(decodedURL, "UTF-8"));
{code}

This leads to the fact, that the URI Constructor can't extract the scheme and the URI is treated as "not absolute".

I can't understand why the urlString has to be encoded before using it for the URI Constructor.

The problem could be solved for me if remove the encoding. I will attach a patch.

Regards
Nils Eckert

> Resolver resolves classpath resources incorrect
> -----------------------------------------------
>
>                 Key: XFIRE-857
>                 URL: http://jira.codehaus.org/browse/XFIRE-857
>             Project: XFire
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.4
>         Environment: WinXP Java 1.5.09
>            Reporter: Philippe Jacot
>            Assignee: Dan Diephouse
>
> When I pass a WSDL URL to the XFireClientFactoryBean of the format "classpath:...../bla.wsdl" I get an error in the method makeClient() as uri.toURL() throws an IllegalArgumentException("URI is not absolute").
> The Resolver resolves the file correctly to a String of the form "file:/d:/..../bla.wsdl" but when the URI object is created (in the method tryClasspath(String) of Resolver) with uri = new URI(URLEncoder.encode(decodedURL, "UTF-8")) URI does not find the scheme (I guess this should be file:/) and therefore thinks its a relative URI.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/XFIRE-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nils Eckert updated XFIRE-857:
------------------------------

    Attachment: xfire-core-1.2.6-issue857.patch

This patch fixes the issue. Patch against 1.2.6 Tag.

> Resolver resolves classpath resources incorrect
> -----------------------------------------------
>
>                 Key: XFIRE-857
>                 URL: http://jira.codehaus.org/browse/XFIRE-857
>             Project: XFire
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.4
>         Environment: WinXP Java 1.5.09
>            Reporter: Philippe Jacot
>            Assignee: Dan Diephouse
>         Attachments: xfire-core-1.2.6-issue857.patch
>
>
> When I pass a WSDL URL to the XFireClientFactoryBean of the format "classpath:...../bla.wsdl" I get an error in the method makeClient() as uri.toURL() throws an IllegalArgumentException("URI is not absolute").
> The Resolver resolves the file correctly to a String of the form "file:/d:/..../bla.wsdl" but when the URI object is created (in the method tryClasspath(String) of Resolver) with uri = new URI(URLEncoder.encode(decodedURL, "UTF-8")) URI does not find the scheme (I guess this should be file:/) and therefore thinks its a relative URI.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://jira.codehaus.org/browse/XFIRE-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nils Eckert updated XFIRE-857:
------------------------------

    Attachment: xfire-core-1.2.6-issue857.patch

This patch fixes the issue. Patch against 1.2.6 Tag.

> Resolver resolves classpath resources incorrect
> -----------------------------------------------
>
>                 Key: XFIRE-857
>                 URL: http://jira.codehaus.org/browse/XFIRE-857
>             Project: XFire
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.4
>         Environment: WinXP Java 1.5.09
>            Reporter: Philippe Jacot
>            Assignee: Dan Diephouse
>         Attachments: xfire-core-1.2.6-issue857.patch
>
>
> When I pass a WSDL URL to the XFireClientFactoryBean of the format "classpath:...../bla.wsdl" I get an error in the method makeClient() as uri.toURL() throws an IllegalArgumentException("URI is not absolute").
> The Resolver resolves the file correctly to a String of the form "file:/d:/..../bla.wsdl" but when the URI object is created (in the method tryClasspath(String) of Resolver) with uri = new URI(URLEncoder.encode(decodedURL, "UTF-8")) URI does not find the scheme (I guess this should be file:/) and therefore thinks its a relative URI.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email