« Return to Thread: [jira] Created: (LANG-458) Add methods to return boolean from Validate.java instead of throwing IllegalArgumentException

[jira] Updated: (LANG-458) Add methods to return boolean from Validate.java instead of throwing IllegalArgumentException

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View in Thread


     [ https://issues.apache.org/jira/browse/LANG-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viraj Turakhia updated LANG-458:
--------------------------------

    Attachment: test_diff.txt
                code_diff.txt

Attaching diff for Validate.java and ValidateTest.java with all those newly added APIs.
Let me know if anything is missing.

How can I check this in?

> Add methods to return boolean from Validate.java instead of throwing IllegalArgumentException
> ---------------------------------------------------------------------------------------------
>
>                 Key: LANG-458
>                 URL: https://issues.apache.org/jira/browse/LANG-458
>             Project: Commons Lang
>          Issue Type: Improvement
>         Environment: software
>            Reporter: Viraj Turakhia
>            Priority: Minor
>         Attachments: code_diff.txt, test_diff.txt
>
>
> I am using Validate.java since long and find it difficult to use when I just want to validate collections or string.
> With current interface, I go like this:
> while(cnt < list.size()) {
>     List list1 = list.get(cnt);
>     try {
>         Validate.notEmpty(list1);
>     } catch(IllegalArgumentException e) {
>         continue;
>     }
> }
> much better approach is:
> while(cnt < list.size()) {
>     List list1 = list.get(cnt);
>     try {
>     if(! Validate.notEmpty(list1)) {
>         continue;
>     }
> }
> If you all agree with this change, I am willing to submit a patch for this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

 « Return to Thread: [jira] Created: (LANG-458) Add methods to return boolean from Validate.java instead of throwing IllegalArgumentException