[kopete-devel] Cleaning up Kopete's icons?

Hi there,

After the KNotificationIcon commits, I get that "?" icon instead of
Kopete's when I'm online. That prompted me to look at what was wrong
and, while doing that, I found some old icons (the ones with the "ox"
prefix) in the kopete/ directory that don't seem to be used for quite
some time. There are some icons in the icons/ directory that fall into
the same case.

Is there any specific reason they're still there? Can they be deleted?

Still on this matter, the KNotificatonsItem commit references some
icons that simply don't exist, such as "kopete-offline" (previously
the gray icon was generated on the fly on top of the default icon) and
"user-connecting". I was thinking of creating creating that gray icon,
and maybe using it for the connecting status as it used to happen.
Last but not least, in KopeteSystemTray::slotReevaluateAccountStates
it seems to need a call to setIconByName again in the
Kopete::OnlineStatus::Online case, but I suppose it shouldn't.
_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

2009/9/20 Raphael Kubo da Costa <kubito@...>:

> Hi there,
>
> After the KNotificationIcon commits, I get that "?" icon instead of
> Kopete's when I'm online. That prompted me to look at what was wrong
> and, while doing that, I found some old icons (the ones with the "ox"
> prefix) in the kopete/ directory that don't seem to be used for quite
> some time. There are some icons in the icons/ directory that fall into
> the same case.
>
> Is there any specific reason they're still there? Can they be deleted?
>
> Still on this matter, the KNotificatonsItem commit references some
> icons that simply don't exist, such as "kopete-offline" (previously
> the gray icon was generated on the fly on top of the default icon) and
> "user-connecting". I was thinking of creating creating that gray icon,
> and maybe using it for the connecting status as it used to happen.
> Last but not least, in KopeteSystemTray::slotReevaluateAccountStates
> it seems to need a call to setIconByName again in the
> Kopete::OnlineStatus::Online case, but I suppose it shouldn't.
>

Bump?
_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

On Sunday 20 September 2009 16:19:08 Raphael Kubo da Costa wrote:

> Hi there,
>
> After the KNotificationIcon commits, I get that "?" icon instead of
> Kopete's when I'm online. That prompted me to look at what was wrong
> and, while doing that, I found some old icons (the ones with the "ox"
> prefix) in the kopete/ directory that don't seem to be used for quite
> some time. There are some icons in the icons/ directory that fall into
> the same case.
>
> Is there any specific reason they're still there? Can they be deleted?
>
> Still on this matter, the KNotificatonsItem commit references some
> icons that simply don't exist, such as "kopete-offline" (previously
> the gray icon was generated on the fly on top of the default icon) and
> "user-connecting". I was thinking of creating creating that gray icon,
> and maybe using it for the connecting status as it used to happen.
> Last but not least, in KopeteSystemTray::slotReevaluateAccountStates
> it seems to need a call to setIconByName again in the
> Kopete::OnlineStatus::Online case, but I suppose it shouldn't.

go ahead and make the cleanups
--
Matt


_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

On Mon, Sep 28, 2009 at 09:57:52PM -0500, Matt Rogers wrote:

> On Sunday 20 September 2009 16:19:08 Raphael Kubo da Costa wrote:
> > Hi there,
> >
> > After the KNotificationIcon commits, I get that "?" icon instead of
> > Kopete's when I'm online. That prompted me to look at what was wrong
> > and, while doing that, I found some old icons (the ones with the "ox"
> > prefix) in the kopete/ directory that don't seem to be used for quite
> > some time. There are some icons in the icons/ directory that fall into
> > the same case.
> >
> > Is there any specific reason they're still there? Can they be deleted?
> go ahead and make the cleanups

I assume you're talking about this part, right?

As for this:

> > Still on this matter, the KNotificatonsItem commit references some
> > icons that simply don't exist, such as "kopete-offline" (previously
> > the gray icon was generated on the fly on top of the default icon) and
> > "user-connecting". I was thinking of creating creating that gray icon,
> > and maybe using it for the connecting status as it used to happen.
> > Last but not least, in KopeteSystemTray::slotReevaluateAccountStates
> > it seems to need a call to setIconByName again in the
> > Kopete::OnlineStatus::Online case, but I suppose it shouldn't.

I've never done fancy graphics stuff before, and there should probably
be a better way to get the gray icon back than creating it with
different sizes, I guess. Can anyone confirm that?

After that, we can get the code in that slot back to a shape similar to
what it looked like before - the current one looks quite borked.
_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

> On Mon, Sep 28, 2009 at 09:57:52PM -0500, Matt Rogers wrote:
> > On Sunday 20 September 2009 16:19:08 Raphael Kubo da Costa wrote:
> > > Hi there,
> > >
> > > After the KNotificationIcon commits, I get that "?" icon instead of
> > > Kopete's when I'm online. That prompted me to look at what was wrong
> > > and, while doing that, I found some old icons (the ones with the "ox"
> > > prefix) in the kopete/ directory that don't seem to be used for quite
> > > some time. There are some icons in the icons/ directory that fall into
> > > the same case.
> > >
> > > Is there any specific reason they're still there? Can they be deleted?
> > go ahead and make the cleanups
> I assume you're talking about this part, right?

Follow-up: I've finally fixed the "?" problem; the old icons in kopete/ have been removed some time ago. I haven't done anything to the icons in icons/ yet.

>
> As for this:
>
> > > Still on this matter, the KNotificatonsItem commit references some
> > > icons that simply don't exist, such as "kopete-offline" (previously
> > > the gray icon was generated on the fly on top of the default icon) and
> > > "user-connecting". I was thinking of creating creating that gray icon,
> > > and maybe using it for the connecting status as it used to happen.
> > > Last but not least, in KopeteSystemTray::slotReevaluateAccountStates
> > > it seems to need a call to setIconByName again in the
> > > Kopete::OnlineStatus::Online case, but I suppose it shouldn't.
>
> I've never done fancy graphics stuff before, and there should probably
> be a better way to get the gray icon back than creating it with
> different sizes, I guess. Can anyone confirm that?
>
> After that, we can get the code in that slot back to a shape similar to
> what it looked like before - the current one looks quite borked.

I've just committed grayscale versions of the icon for the various needed sizes, including an SVG one. The PNGs were created with "convert -colorspace Grayscale", and the SVG was created using Grayscale from Inkscape. If this isn't the right approach, feel free to correct this.
_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel