[kopete-devel] How to unset an account mood in Kopete 0.70.90

[romainguinot]

Hi,

I've set a mood for myself on a jabber account, but now would like to remove it.
It seems clicking "None" does not work, at least not immediately since other colleagues still see the mood with different clients (Gajim, Pidgin..; all linux laptops).

Should the change be immediate ?

I've seen in protocols/jabber/jabberaccount.cpp (1109-1122) this snippet of code :

void JabberAccount::slotSetMood()
{
    KAction *action = (KAction *)sender();
    Mood::Type type = (Mood::Type)action->data().toInt();
    if(type == Mood::None)
    {
    }
    else
    {
        PubSubItem psi("current", Mood(type).toXml(*client()->client()->rootTask()->doc()));
        JT_PubSubPublish *task = new JT_PubSubPublish(client()->client()->rootTask(), QString("http://jabber.org/protocol/mood"), psi);
        task->go(true);
    }
}


If nothing is done when Mood is None, how is one supposed to reset a mood back to None once one has been chosen ?

Many thanks,
Romain.




--
Romain.

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

[Matt Rogers]

On Wednesday 30 September 2009 07:17:57 Romain wrote:

> Hi,
>
> I've set a mood for myself on a jabber account, but now would like to
>  remove it.
> It seems clicking "None" does not work, at least not immediately since
>  other colleagues still see the mood with different clients (Gajim,
>  Pidgin..; all linux laptops).
>
> Should the change be immediate ?
>
> I've seen in protocols/jabber/jabberaccount.cpp (1109-1122) this snippet of
> code :
>
> void JabberAccount::slotSetMood()
> {
>     KAction *action = (KAction *)sender();
>     Mood::Type type = (Mood::Type)action->data().toInt();
>     if(type == Mood::None)
>     {
>     }
>     else
>     {
>         PubSubItem psi("current",
> Mood(type).toXml(*client()->client()->rootTask()->doc()));
>         JT_PubSubPublish *task = new
> JT_PubSubPublish(client()->client()->rootTask(), QString("
> http://jabber.org/protocol/mood"), psi);
>         task->go(true);
>     }
> }
>
>
> If nothing is done when Mood is None, how is one supposed to reset a mood
> back to None once one has been chosen ?
>
> Many thanks,
> Romain.
>

I think you've found the answer. :) Could you provide a patch to fix this, or
at the very least file a bug (if there isn't one already?)
--
Matt


_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

[romainguinot]

I've added a comment on this existing bug regarding jabber mood : https://bugs.kde.org/show_bug.cgi?id=111329#c3
I think i see the fix as you'll see in my comment but do not have the possibility to test it right now, i'll probably test if for myself in the next few days if you haven't fixed it yet :)

BTW, i'm using KDE 4.3.1 on Fedora 11.
Best regards,
Romain

On Thu, Oct 1, 2009 at 4:07 AM, Matt Rogers <mattr@...> wrote:

On Wednesday 30 September 2009 07:17:57 Romain wrote:
> Hi,
>
> I've set a mood for myself on a jabber account, but now would like to
>  remove it.
> It seems clicking "None" does not work, at least not immediately since
>  other colleagues still see the mood with different clients (Gajim,
>  Pidgin..; all linux laptops).
>
> Should the change be immediate ?
>
> I've seen in protocols/jabber/jabberaccount.cpp (1109-1122) this snippet of
> code :
>
> void JabberAccount::slotSetMood()
> {
>     KAction *action = (KAction *)sender();
>     Mood::Type type = (Mood::Type)action->data().toInt();
>     if(type == Mood::None)
>     {
>     }
>     else
>     {
>         PubSubItem psi("current",
> Mood(type).toXml(*client()->client()->rootTask()->doc()));
>         JT_PubSubPublish *task = new
> JT_PubSubPublish(client()->client()->rootTask(), QString("
> http://jabber.org/protocol/mood"), psi);
>         task->go(true);
>     }
> }
>
>
> If nothing is done when Mood is None, how is one supposed to reset a mood
> back to None once one has been chosen ?
>
> Many thanks,
> Romain.
>

I think you've found the answer. :) Could you provide a patch to fix this, or
at the very least file a bug (if there isn't one already?)
--
Matt

--
Romain.

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

[romainguinot]

Proposed patch added as an attachment to this bug report : https://bugs.kde.org/show_bug.cgi?id=111329#c3

On Thu, Oct 1, 2009 at 11:20 AM, Romain <romainguinot@...> wrote:

I've added a comment on this existing bug regarding jabber mood : https://bugs.kde.org/show_bug.cgi?id=111329#c3
I think i see the fix as you'll see in my comment but do not have the possibility to test it right now, i'll probably test if for myself in the next few days if you haven't fixed it yet :)

BTW, i'm using KDE 4.3.1 on Fedora 11.
Best regards,
Romain

On Thu, Oct 1, 2009 at 4:07 AM, Matt Rogers <mattr@...> wrote:

On Wednesday 30 September 2009 07:17:57 Romain wrote:
> Hi,
>
> I've set a mood for myself on a jabber account, but now would like to
>  remove it.
> It seems clicking "None" does not work, at least not immediately since
>  other colleagues still see the mood with different clients (Gajim,
>  Pidgin..; all linux laptops).
>
> Should the change be immediate ?
>
> I've seen in protocols/jabber/jabberaccount.cpp (1109-1122) this snippet of
> code :
>
> void JabberAccount::slotSetMood()
> {
>     KAction *action = (KAction *)sender();
>     Mood::Type type = (Mood::Type)action->data().toInt();
>     if(type == Mood::None)
>     {
>     }
>     else
>     {
>         PubSubItem psi("current",
> Mood(type).toXml(*client()->client()->rootTask()->doc()));
>         JT_PubSubPublish *task = new
> JT_PubSubPublish(client()->client()->rootTask(), QString("
> http://jabber.org/protocol/mood"), psi);
>         task->go(true);
>     }
> }
>
>
> If nothing is done when Mood is None, how is one supposed to reset a mood
> back to None once one has been chosen ?
>
> Many thanks,
> Romain.
>

I think you've found the answer. :) Could you provide a patch to fix this, or
at the very least file a bug (if there isn't one already?)
--
Matt

--
Romain.

--
Romain.

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel