|

»

[kopete-devel] Review Request: Ability to show individuals contacts even if offline

View: New views

6 Messages — Rating Filter: Alert me

	[kopete-devel] Review Request: Ability to show individuals contacts even if offline by Bugzilla from bigras.bruno@gmail.com :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1619/ ----------------------------------------------------------- Review request for Kopete. Summary ------- Add the possibility to always show a contact even if offline like in Pidgin. It makes sending messages to "always invisible" friends much easier when having many contacts. For now, it adds a "always-visible" tag in contactlist.xml. <meta-contact kabcId="WlmProtocol:my@...:someone@..." contactId="{ef566dff-e12c-41e6-8390-c0a46666319e}" > <display-name></display-name> <always-visible>false</always-visible> This addresses bug 98757. https://bugs.kde.org/show_bug.cgi?id=98757 Diffs ----- /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp 1024049 /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp 1024049 /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitembase.h 1024049 /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetelviprops.h 1024049 /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetelviprops.cpp 1024049 /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetemetalvipropswidget.ui 1024049 /trunk/KDE/kdenetwork/kopete/libkopete/contactlist/xmlcontactstorage.cpp 1024049 /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1024049 /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1024049 /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.h 1024049 /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1024049 /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact_p.h 1024049 Diff: http://reviewboard.kde.org/r/1619/diff Testing ------- Screenshots ----------- http://reviewboard.kde.org/r/1619/s/205/ Thanks, Bruno _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel
	Re: [kopete-devel] Review Request: Ability to show individuals contacts even if offline by Bugzilla from bigras.bruno@gmail.com :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message > On None, Matt Rogers wrote: > > Is this any way that this can be done through the use of a contact property rather than adding API? Kopete 1.0 is coming soon, and so I'm basically treating the API as frozen unless there are critical concerns around it. > > > > Also, there isn't a contact list version bump to go with the added XML tag, which would only be needed if we do not switch to using a contact property. Thanks for the fast response! Do you have any sample of something already using a "contact property"? I don't know much about Kopete's structure, I guess you mean without touching libkopete. - Bruno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1619/#review2379 ----------------------------------------------------------- On 2009-09-16 04:21:32, Bruno Bigras wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1619/ > ----------------------------------------------------------- > > (Updated 2009-09-16 04:21:32) > > > Review request for Kopete. > > > Summary > ------- > > Add the possibility to always show a contact even if offline like in Pidgin. It makes sending messages to "always invisible" friends much easier when having many contacts. > > For now, it adds a "always-visible" tag in contactlist.xml. > > <meta-contact kabcId="WlmProtocol:my@...:someone@..." contactId="{ef566dff-e12c-41e6-8390-c0a46666319e}" > > <display-name></display-name> > <always-visible>false</always-visible> > > > This addresses bug 98757. > https://bugs.kde.org/show_bug.cgi?id=98757 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitembase.h 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetelviprops.h 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetelviprops.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetemetalvipropswidget.ui 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/contactlist/xmlcontactstorage.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.h 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact_p.h 1024049 > > Diff: http://reviewboard.kde.org/r/1619/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1619/s/205/ > > > Thanks, > > Bruno > > _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel
	Re: [kopete-devel] Review Request: Ability to show individuals contacts even if offline by Bugzilla from mattr@kde.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message > On None, Matt Rogers wrote: > > Is this any way that this can be done through the use of a contact property rather than adding API? Kopete 1.0 is coming soon, and so I'm basically treating the API as frozen unless there are critical concerns around it. > > > > Also, there isn't a contact list version bump to go with the added XML tag, which would only be needed if we do not switch to using a contact property. > > Bruno Bigras wrote: > Thanks for the fast response! > > Do you have any sample of something already using a "contact property"? I don't know much about Kopete's structure, I guess you mean without touching libkopete. the api for the properties is setProperty() and property() in Kopete::Contact, at least that's how you would use them. You'd need something like what's in protocols/oscar/oscarprotocol.h and protocols/oscar/oscarprotocol.cpp to declare the new property. I'm not sure exactly where you'd declare the new property at, so that it's available by all, but that's the basics of it. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1619/#review2379 ----------------------------------------------------------- On 2009-09-16 04:21:32, Bruno Bigras wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1619/ > ----------------------------------------------------------- > > (Updated 2009-09-16 04:21:32) > > > Review request for Kopete. > > > Summary > ------- > > Add the possibility to always show a contact even if offline like in Pidgin. It makes sending messages to "always invisible" friends much easier when having many contacts. > > For now, it adds a "always-visible" tag in contactlist.xml. > > <meta-contact kabcId="WlmProtocol:my@...:someone@..." contactId="{ef566dff-e12c-41e6-8390-c0a46666319e}" > > <display-name></display-name> > <always-visible>false</always-visible> > > > This addresses bug 98757. > https://bugs.kde.org/show_bug.cgi?id=98757 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitembase.h 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetelviprops.h 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetelviprops.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetemetalvipropswidget.ui 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/contactlist/xmlcontactstorage.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.h 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1024049 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact_p.h 1024049 > > Diff: http://reviewboard.kde.org/r/1619/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1619/s/205/ > > > Thanks, > > Bruno > > _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel
	Re: [kopete-devel] Review Request: Ability to show individuals contacts even if offline by Bugzilla from bigras.bruno@gmail.com :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1619/ ----------------------------------------------------------- (Updated 2009-10-15 15:23:53.285176) Review request for Kopete. Changes ------- Here's a new diff without using the XML file. I added a kaction in the context menu which use setProperty(). It would have made more sense if the metacontact could be set as "always visible" because I don't think it makes sense that a metacontact can have two contacts which both have this option but it's only show once. But if I'm right metacontact don't have setProperty(). For now the kaction don't have a checkbox because I wanted to be sure I was doing it the right way. When triggering this action the contact list is not refreshed at this time. I am note sure if it's right because I made modification in the libkopete which may be the frozen API you were talking about. Unless you were only talking about the XML part. Summary ------- Add the possibility to always show a contact even if offline like in Pidgin. It makes sending messages to "always invisible" friends much easier when having many contacts. For now, it adds a "always-visible" tag in contactlist.xml. <meta-contact kabcId="WlmProtocol:my@...:someone@..." contactId="{ef566dff-e12c-41e6-8390-c0a46666319e}" > <display-name></display-name> <always-visible>false</always-visible> This addresses bug 98757. https://bugs.kde.org/show_bug.cgi?id=98757 Diffs (updated) ----- /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp 1035504 /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp 1035504 /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitembase.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopeteglobal.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopeteglobal.cpp 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetestdaction.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetestdaction.cpp 1035504 Diff: http://reviewboard.kde.org/r/1619/diff Testing ------- Screenshots ----------- http://reviewboard.kde.org/r/1619/s/205/ Thanks, Bruno _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel
	Re: [kopete-devel] Review Request: Ability to show individuals contacts even if offline by Bugzilla from bigras.bruno@gmail.com :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1619/ ----------------------------------------------------------- (Updated 2009-10-15 15:25:43.697213) Review request for Kopete. Summary (updated) ------- Add the possibility to always show a contact even if offline like in Pidgin. It makes sending messages to "always invisible" friends much easier when having many contacts. This addresses bug 98757. https://bugs.kde.org/show_bug.cgi?id=98757 Diffs ----- /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp 1035504 /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp 1035504 /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitembase.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopeteglobal.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopeteglobal.cpp 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetestdaction.h 1035504 /trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetestdaction.cpp 1035504 Diff: http://reviewboard.kde.org/r/1619/diff Testing ------- Thanks, Bruno _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel
	Re: [kopete-devel] Review Request: Ability to show individuals contacts even if offline by Bugzilla from mattr@kde.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1619/#review2676 ----------------------------------------------------------- Ship it! this looks fine. please commit. - Matt On 2009-10-15 15:25:43, Bruno Bigras wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1619/ > ----------------------------------------------------------- > > (Updated 2009-10-15 15:25:43) > > > Review request for Kopete. > > > Summary > ------- > > Add the possibility to always show a contact even if offline like in Pidgin. It makes sending messages to "always invisible" friends much easier when having many contacts. > > > This addresses bug 98757. > https://bugs.kde.org/show_bug.cgi?id=98757 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp 1035504 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp 1035504 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitembase.h 1035504 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1035504 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1035504 > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteglobal.h 1035504 > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteglobal.cpp 1035504 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.h 1035504 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1035504 > /trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetestdaction.h 1035504 > /trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetestdaction.cpp 1035504 > > Diff: http://reviewboard.kde.org/r/1619/diff > > > Testing > ------- > > > Thanks, > > Bruno > > _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel