[kopete-devel] Review Request: Add option to send signed/encrypted messages via jabber in pgp inline format

[Pali]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1656/
-----------------------------------------------------------

Review request for Kopete.


Summary
-------

This patch add option to send signed or encrypted messages in old pgp inline format.

A lot of jabber clients doesnt support XEP-0027, so users cant receive signed or encrypted messages.
This option doesnt use XEP-0027, so all signed or encrypted messages will be shown in jabber client (and user can run GnuGPG external).

This patch fix also deleting string "-----END PGP MESSAGE-----" at end of jabber message (when inline format is off; with XEP-0027), because it musnt be in jabber encrypted message.


Diffs
-----

  /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1025987
  /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1025987
  /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberchatsession.cpp 1025987
  /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabbereditaccountwidget.ui 1025987
  /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp 1025987

Diff: http://reviewboard.kde.org/r/1656/diff


Testing
-------

This patch works for me fine.
If I chating with someone, who has opened gmail and have gnugpg installed, he can verify or encrypt my messages.
Without this patch, he only see "This message is encrypted." and he doesnt see PGP block data.


Thanks,

Pali

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1656/#review2679
-----------------------------------------------------------

Ship it!


please commit.

- Matt


On 2009-09-20 12:04:17, Pali Rohár wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1656/
> -----------------------------------------------------------
>
> (Updated 2009-09-20 12:04:17)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> This patch add option to send signed or encrypted messages in old pgp inline format.
>
> A lot of jabber clients doesnt support XEP-0027, so users cant receive signed or encrypted messages.
> This option doesnt use XEP-0027, so all signed or encrypted messages will be shown in jabber client (and user can run GnuGPG external).
>
> This patch fix also deleting string "-----END PGP MESSAGE-----" at end of jabber message (when inline format is off; with XEP-0027), because it musnt be in jabber encrypted message.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1025987
>   /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1025987
>   /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberchatsession.cpp 1025987
>   /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabbereditaccountwidget.ui 1025987
>   /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp 1025987
>
> Diff: http://reviewboard.kde.org/r/1656/diff
>
>
> Testing
> -------
>
> This patch works for me fine.
> If I chating with someone, who has opened gmail and have gnugpg installed, he can verify or encrypt my messages.
> Without this patch, he only see "This message is encrypted." and he doesnt see PGP block data.
>
>
> Thanks,
>
> Pali
>
>

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel