-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1873/#review2860-----------------------------------------------------------
Ship it!
add a comment then commit it.
/trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp
<
http://reviewboard.kde.org/r/1873/#comment2238>
are you abusing the onlineStatusChanged signal here? If so, it would be nice to at least add a comment explaining why.
- Matt
On 2009-10-17 21:22:56, Bruno Bigras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
>
http://reviewboard.kde.org/r/1873/> -----------------------------------------------------------
>
> (Updated 2009-10-17 21:22:56)
>
>
> Review request for Kopete and Matt Rogers.
>
>
> Summary
> -------
>
> This is a small update for my last patch.
>
> With this the contact list is refreshed when the property change and I added a checkbox to see the state of the property (could be very handy for people having many contact grouped into on metacontact).
>
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1036347
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1036347
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1036347
>
> Diff:
http://reviewboard.kde.org/r/1873/diff>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruno
>
>
_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel
