[kopete-devel] Review Request: Enable clearsign mode in signed messages (cryptography plugin)

[Pali]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1657/
-----------------------------------------------------------

Review request for Kopete.


Summary
-------

This patch add support to verify signed messages in clearsign mode and setup clearsign mode as default instead normal mode.

If message is signed in normal mode, user who doesnt have gnugpg, he cant read this message. But message in clearsign mode is readable without gpg.


Diffs
-----

  /trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp 1025986

Diff: http://reviewboard.kde.org/r/1657/diff


Testing
-------

It works fine.

Kopete now check signed messages in normal or clearsign mode and encrypted messages.


Thanks,

Pali

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1657/#review2678
-----------------------------------------------------------


what does clearsign mode do exactly and why should we enable it by default?

In theory, the patch looks fine, but I'm not sure I agree with the change in defaults.

- Matt


On 2009-09-20 12:23:02, Pali Rohár wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1657/
> -----------------------------------------------------------
>
> (Updated 2009-09-20 12:23:02)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> This patch add support to verify signed messages in clearsign mode and setup clearsign mode as default instead normal mode.
>
> If message is signed in normal mode, user who doesnt have gnugpg, he cant read this message. But message in clearsign mode is readable without gpg.
>
>
> Diffs
> -----
>
>   /trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp 1025986
>
> Diff: http://reviewboard.kde.org/r/1657/diff
>
>
> Testing
> -------
>
> It works fine.
>
> Kopete now check signed messages in normal or clearsign mode and encrypted messages.
>
>
> Thanks,
>
> Pali
>
>

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

[Pali]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1657/
-----------------------------------------------------------

(Updated 2009-10-17 16:14:07.641037)


Review request for Kopete.


Changes
-------

Added option to use clearsign or normal mode for signing messages


Summary
-------

This patch add support to verify signed messages in clearsign mode and setup clearsign mode as default instead normal mode.

If message is signed in normal mode, user who doesnt have gnugpg, he cant read this message. But message in clearsign mode is readable without gpg.


Diffs (updated)
-----

  /trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp 1036355
  /trunk/extragear/network/kopete-cryptography/cryptographypreferences.h 1036355
  /trunk/extragear/network/kopete-cryptography/cryptographypreferences.cpp 1036355
  /trunk/extragear/network/kopete-cryptography/cryptographysettings.kcfg 1036355

Diff: http://reviewboard.kde.org/r/1657/diff


Testing
-------

It works fine.

Kopete now check signed messages in normal or clearsign mode and encrypted messages.


Thanks,

Pali

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel