[kopete-devel] Review Request: Fix the bug that a contact can't me moved into a group created in Kopete (WLM)

View: New views
2 Messages — Rating Filter:   Alert me  

[kopete-devel] Review Request: Fix the bug that a contact can't me moved into a group created in Kopete (WLM)

by Bugzilla from bigras.bruno@gmail.com :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1917/
-----------------------------------------------------------

Review request for Kopete and Matt Rogers.


Summary
-------

It seems that with WLM, groups are only created when adding a new contact.

When creating a new group and moving a contact into it. It seems to works but when Kopete is restarted, the contact is back into is old group and the group appars in Kopete but not on the MSN server.

It's in two parts because it's seems the group is not created fast enough in WlmContact::sync() just before being affected to the contact.


This addresses bug 190353.
    https://bugs.kde.org/show_bug.cgi?id=190353


Diffs
-----

  /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 1038263
  /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmcontact.cpp 1038263

Diff: http://reviewboard.kde.org/r/1917/diff


Testing
-------


Thanks,

Bruno

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

Re: [kopete-devel] Review Request: Fix the bug that a contact can't me moved into a group created in Kopete (WLM)

by Bugzilla from mattr@kde.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1917/#review2773
-----------------------------------------------------------

Ship it!


looks fine. please commit.

- Matt


On 2009-10-21 03:12:33, Bruno Bigras wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1917/
> -----------------------------------------------------------
>
> (Updated 2009-10-21 03:12:33)
>
>
> Review request for Kopete and Matt Rogers.
>
>
> Summary
> -------
>
> It seems that with WLM, groups are only created when adding a new contact.
>
> When creating a new group and moving a contact into it. It seems to works but when Kopete is restarted, the contact is back into is old group and the group appars in Kopete but not on the MSN server.
>
> It's in two parts because it's seems the group is not created fast enough in WlmContact::sync() just before being affected to the contact.
>
>
> This addresses bug 190353.
>     https://bugs.kde.org/show_bug.cgi?id=190353
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 1038263
>   /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmcontact.cpp 1038263
>
> Diff: http://reviewboard.kde.org/r/1917/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruno
>
>

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel