[kopete-devel] Review Request: Replaced kopete systray with NotificationItem

View: New views
2 Messages — Rating Filter:   Alert me  

[kopete-devel] Review Request: Replaced kopete systray with NotificationItem

by Bugzilla from davide.bettio@kdemail.net :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1635/
-----------------------------------------------------------

Review request for Kopete and Plasma.


Summary
-------

This patch replaces KSysTray with KNotificationItem.


Diffs
-----

  /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1025366
  /trunk/KDE/kdenetwork/kopete/kopete/systemtray.h 1025366
  /trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp 1025366

Diff: http://reviewboard.kde.org/r/1635/diff


Testing
-------

I've been using kopete with this patch for some hours...


Thanks,

Davide

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

Re: [kopete-devel] Review Request: Replaced kopete systray with NotificationItem

by Bugzilla from mattr@kde.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1635/#review2396
-----------------------------------------------------------

Ship it!


looks fine. please commit. thanks for the port!

- Matt


On 2009-09-18 19:50:08, Davide Bettio wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1635/
> -----------------------------------------------------------
>
> (Updated 2009-09-18 19:50:08)
>
>
> Review request for Kopete and Plasma.
>
>
> Summary
> -------
>
> This patch replaces KSysTray with KNotificationItem.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1025366
>   /trunk/KDE/kdenetwork/kopete/kopete/systemtray.h 1025366
>   /trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp 1025366
>
> Diff: http://reviewboard.kde.org/r/1635/diff
>
>
> Testing
> -------
>
> I've been using kopete with this patch for some hours...
>
>
> Thanks,
>
> Davide
>
>

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel