|
»
[kopete-devel] Review Request: Show the contact picture if available in the Participants View
|
View:
New views
8 Messages
—
Rating Filter:
Alert me
|
 |
[kopete-devel] Review Request: Show the contact picture if available in the Participants View
by Aleix Pol-2
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/ ----------------------------------------------------------- Review request for Kopete. Summary ------- I was browsing through the code thinking of some way to improve the chat window. I had 2 problems. I wanted to see the contact's picture in a reasonable format (bigger than in the chat view) and the participants list view looked kind of boring/empty most of the time, so I came up with this patch that adds a delegate that can do that. It could be improved a little bit but here you can see (mostly in the screenshot) what the patch does and does not. Hope you find it useful. Diffs ----- trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp 1014660 trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1014660 trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h PRE-CREATION trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/1394/diff Testing ------- Umm... use it... Screenshots ----------- http://reviewboard.kde.org/r/1394/s/190/ Thanks, Aleix _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel |
|
|
Re: [kopete-devel] Review Request: Show the contact picture if available in the Participants View
by Gustavo Boiko
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/#review2153 ----------------------------------------------------------- I haven't seen the code yet, but here are some thoughts. Looking at the screenshot, it seems to me that the image is kinda lost in the contest. Instead of that, it would probably be a better idea (if seeing the big picture is really desired) to arrange items in icon mode instead of item mode, and then set a bigger icon size to them. Wouldn't it be enough if we just had a tooltip showing all the info including the contact icon? - Gustavo On 2009-08-24 18:56:35, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1394/ > ----------------------------------------------------------- > > (Updated 2009-08-24 18:56:35) > > > Review request for Kopete. > > > Summary > ------- > > I was browsing through the code thinking of some way to improve the chat window. > > I had 2 problems. I wanted to see the contact's picture in a reasonable format (bigger than in the chat view) and the participants list view looked kind of boring/empty most of the time, so I came up with this patch that adds a delegate that can do that. > > It could be improved a little bit but here you can see (mostly in the screenshot) what the patch does and does not. > > Hope you find it useful. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp 1014660 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1014660 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h PRE-CREATION > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1394/diff > > > Testing > ------- > > Umm... use it... > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1394/s/190/ > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel |
|
|
Re: [kopete-devel] Review Request: Show the contact picture if available in the Participants View
by Aleix Pol-2
::
Rate this Message:
> On 2009-08-26 16:20:54, Gustavo Boiko wrote: > > I haven't seen the code yet, but here are some thoughts. > > Looking at the screenshot, it seems to me that the image is kinda lost in the contest. Instead of that, it would probably be a better idea (if seeing the big picture is really desired) to arrange items in icon mode instead of item mode, and then set a bigger icon size to them. > > > > Wouldn't it be enough if we just had a tooltip showing all the info including the contact icon? I don't want tooltips. People wants to be able to see the chatee at anytime. Plus all other clients do that and we have a lot of wasted space there :/. Here we have 2 icons: the state and the picture. Moving to icon would provide a very big status notification. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/#review2153 ----------------------------------------------------------- On 2009-08-24 18:56:35, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1394/ > ----------------------------------------------------------- > > (Updated 2009-08-24 18:56:35) > > > Review request for Kopete. > > > Summary > ------- > > I was browsing through the code thinking of some way to improve the chat window. > > I had 2 problems. I wanted to see the contact's picture in a reasonable format (bigger than in the chat view) and the participants list view looked kind of boring/empty most of the time, so I came up with this patch that adds a delegate that can do that. > > It could be improved a little bit but here you can see (mostly in the screenshot) what the patch does and does not. > > Hope you find it useful. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp 1014660 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1014660 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h PRE-CREATION > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1394/diff > > > Testing > ------- > > Umm... use it... > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1394/s/190/ > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel |
|
|
Re: [kopete-devel] Review Request: Show the contact picture if available in the Participants View
by Bugzilla from mattr@kde.org
::
Rate this Message:
> On 2009-08-26 16:20:54, Gustavo Boiko wrote: > > I haven't seen the code yet, but here are some thoughts. > > Looking at the screenshot, it seems to me that the image is kinda lost in the contest. Instead of that, it would probably be a better idea (if seeing the big picture is really desired) to arrange items in icon mode instead of item mode, and then set a bigger icon size to them. > > > > Wouldn't it be enough if we just had a tooltip showing all the info including the contact icon? > > Aleix Pol wrote: > I don't want tooltips. People wants to be able to see the chatee at anytime. Plus all other clients do that and we have a lot of wasted space there :/. > > Here we have 2 icons: the state and the picture. Moving to icon would provide a very big status notification. I like the idea of adding the picture to the participants list. Regarding the layout, what if we provided a larger picture in the participants list next to each participant? I'm thinking 128x128 at least. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/#review2153 ----------------------------------------------------------- On 2009-08-24 18:56:35, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1394/ > ----------------------------------------------------------- > > (Updated 2009-08-24 18:56:35) > > > Review request for Kopete. > > > Summary > ------- > > I was browsing through the code thinking of some way to improve the chat window. > > I had 2 problems. I wanted to see the contact's picture in a reasonable format (bigger than in the chat view) and the participants list view looked kind of boring/empty most of the time, so I came up with this patch that adds a delegate that can do that. > > It could be improved a little bit but here you can see (mostly in the screenshot) what the patch does and does not. > > Hope you find it useful. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp 1014660 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1014660 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h PRE-CREATION > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1394/diff > > > Testing > ------- > > Umm... use it... > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1394/s/190/ > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel |
|
|
Re: [kopete-devel] Review Request: Show the contact picture if available in the Participants View
by Aleix Pol-2
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/ ----------------------------------------------------------- (Updated 2009-09-12 14:33:25.178120) Review request for Kopete. Changes ------- Fixes positioning issues. Let the model provide the image instead of doing dirty casts. Summary ------- I was browsing through the code thinking of some way to improve the chat window. I had 2 problems. I wanted to see the contact's picture in a reasonable format (bigger than in the chat view) and the participants list view looked kind of boring/empty most of the time, so I came up with this patch that adds a delegate that can do that. It could be improved a little bit but here you can see (mostly in the screenshot) what the patch does and does not. Hope you find it useful. Diffs (updated) ----- trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.h 1022530 trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.cpp 1022530 trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp 1022530 trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1022530 trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h PRE-CREATION trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/1394/diff Testing ------- Umm... use it... Screenshots ----------- http://reviewboard.kde.org/r/1394/s/190/ Thanks, Aleix _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel |
|
|
Re: [kopete-devel] Review Request: Show the contact picture if available in the Participants View
by Aleix Pol-2
::
Rate this Message:
> On 2009-08-26 16:20:54, Gustavo Boiko wrote: > > I haven't seen the code yet, but here are some thoughts. > > Looking at the screenshot, it seems to me that the image is kinda lost in the contest. Instead of that, it would probably be a better idea (if seeing the big picture is really desired) to arrange items in icon mode instead of item mode, and then set a bigger icon size to them. > > > > Wouldn't it be enough if we just had a tooltip showing all the info including the contact icon? > > Aleix Pol wrote: > I don't want tooltips. People wants to be able to see the chatee at anytime. Plus all other clients do that and we have a lot of wasted space there :/. > > Here we have 2 icons: the state and the picture. Moving to icon would provide a very big status notification. > > Matt Rogers wrote: > I like the idea of adding the picture to the participants list. Regarding the layout, what if we provided a larger picture in the participants list next to each participant? I'm thinking 128x128 at least. The size depends on what we get. the metaContact's picture is usually 96x96 in this case. I don't know if we're scaling them ourselves or it's the protocols that don't give us more. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/#review2153 ----------------------------------------------------------- On 2009-09-12 14:33:25, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1394/ > ----------------------------------------------------------- > > (Updated 2009-09-12 14:33:25) > > > Review request for Kopete. > > > Summary > ------- > > I was browsing through the code thinking of some way to improve the chat window. > > I had 2 problems. I wanted to see the contact's picture in a reasonable format (bigger than in the chat view) and the participants list view looked kind of boring/empty most of the time, so I came up with this patch that adds a delegate that can do that. > > It could be improved a little bit but here you can see (mostly in the screenshot) what the patch does and does not. > > Hope you find it useful. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.h 1022530 > trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.cpp 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h PRE-CREATION > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1394/diff > > > Testing > ------- > > Umm... use it... > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1394/s/190/ > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel |
|
|
Re: [kopete-devel] Review Request: Show the contact picture if available in the Participants View
by Bugzilla from mattr@kde.org
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/#review2680 ----------------------------------------------------------- no action to address reviews, marked the review as discarded. Please feel free to resurrect it when there are updates available for the patch. - Matt On 2009-09-12 14:33:25, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1394/ > ----------------------------------------------------------- > > (Updated 2009-09-12 14:33:25) > > > Review request for Kopete. > > > Summary > ------- > > I was browsing through the code thinking of some way to improve the chat window. > > I had 2 problems. I wanted to see the contact's picture in a reasonable format (bigger than in the chat view) and the participants list view looked kind of boring/empty most of the time, so I came up with this patch that adds a delegate that can do that. > > It could be improved a little bit but here you can see (mostly in the screenshot) what the patch does and does not. > > Hope you find it useful. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.h 1022530 > trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.cpp 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h PRE-CREATION > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1394/diff > > > Testing > ------- > > Umm... use it... > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1394/s/190/ > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel |
|
|
Re: [kopete-devel] Review Request: Show the contact picture if available in the Participants View
by Aleix Pol-2
::
Rate this Message:
> On 2009-10-17 02:50:31, Matt Rogers wrote: > > no action to address reviews, marked the review as discarded. Please feel free to resurrect it when there are updates available for the patch. ugh, didn't see that one, I'll post an update soon. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1394/#review2680 ----------------------------------------------------------- On 2009-09-12 14:33:25, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1394/ > ----------------------------------------------------------- > > (Updated 2009-09-12 14:33:25) > > > Review request for Kopete. > > > Summary > ------- > > I was browsing through the code thinking of some way to improve the chat window. > > I had 2 problems. I wanted to see the contact's picture in a reasonable format (bigger than in the chat view) and the participants list view looked kind of boring/empty most of the time, so I came up with this patch that adds a delegate that can do that. > > It could be improved a little bit but here you can see (mostly in the screenshot) what the patch does and does not. > > Hope you find it useful. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.h 1022530 > trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.cpp 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1022530 > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h PRE-CREATION > trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1394/diff > > > Testing > ------- > > Umm... use it... > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1394/s/190/ > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@... https://mail.kde.org/mailman/listinfo/kopete-devel |
| Free embeddable forum powered by Nabble | Forum Help |
