[kopete-devel] Review Request: fix filetransfers in otr chatsessions

View: New views
6 Messages — Rating Filter:   Alert me  

[kopete-devel] Review Request: fix filetransfers in otr chatsessions

by Bugzilla from florian.reinhard@googlemail.com :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1717/
-----------------------------------------------------------

Review request for Kopete.


Summary
-------

When Kopete recieves a filetransfer from a chatsession that uses OTR, it tries to decrypt it and fails, showing [] instead of the download buttons.


This addresses bug 183005.
    https://bugs.kde.org/show_bug.cgi?id=183005


Diffs
-----

  /trunk/KDE/kdenetwork/kopete/plugins/otr/otrplugin.cpp 1028690

Diff: http://reviewboard.kde.org/r/1717/diff


Testing
-------

icq: kopete vs miranda


Thanks,

Florian

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

Re: [kopete-devel] Review Request: fix filetransfers in otr chatsessions

by Bugzilla from florian.reinhard@googlemail.com :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1717/
-----------------------------------------------------------

(Updated 2009-09-28 17:45:51.573063)


Review request for Kopete.


Changes
-------

more testing..


Summary
-------

When Kopete recieves a filetransfer from a chatsession that uses OTR, it tries to decrypt it and fails, showing [] instead of the download buttons.


This addresses bug 183005.
    https://bugs.kde.org/show_bug.cgi?id=183005


Diffs
-----

  /trunk/KDE/kdenetwork/kopete/plugins/otr/otrplugin.cpp 1028690

Diff: http://reviewboard.kde.org/r/1717/diff


Testing (updated)
-------

icq: kopete vs miranda
jabber: kopete vs pidgin


Thanks,

Florian

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

Re: [kopete-devel] Review Request: fix filetransfers in otr chatsessions

by Bugzilla from florian.reinhard@googlemail.com :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1717/
-----------------------------------------------------------

(Updated 2009-09-28 21:43:17.136392)


Review request for Kopete.


Changes
-------

missing ;


Summary
-------

When Kopete recieves a filetransfer from a chatsession that uses OTR, it tries to decrypt it and fails, showing [] instead of the download buttons.


This addresses bug 183005.
    https://bugs.kde.org/show_bug.cgi?id=183005


Diffs (updated)
-----

  trunk/KDE/kdenetwork/kopete/plugins/otr/otrplugin.cpp 1028690

Diff: http://reviewboard.kde.org/r/1717/diff


Testing
-------

icq: kopete vs miranda
jabber: kopete vs pidgin


Thanks,

Florian

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

Re: [kopete-devel] Review Request: fix filetransfers in otr chatsessions

by Bugzilla from michael_zanetti@gmx.net :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1717/#review2499
-----------------------------------------------------------

Ship it!


Although file transfer (through xmpp) works here also without your patch, I think it doesn't harm. Instead it clears the situation with file transfers in the code and makes it cleaner.

Ship it!

Thanks,
Michael

- mzanetti


On 2009-09-28 21:43:17, Florian Reinhard wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1717/
> -----------------------------------------------------------
>
> (Updated 2009-09-28 21:43:17)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> When Kopete recieves a filetransfer from a chatsession that uses OTR, it tries to decrypt it and fails, showing [] instead of the download buttons.
>
>
> This addresses bug 183005.
>     https://bugs.kde.org/show_bug.cgi?id=183005
>
>
> Diffs
> -----
>
>   trunk/KDE/kdenetwork/kopete/plugins/otr/otrplugin.cpp 1028690
>
> Diff: http://reviewboard.kde.org/r/1717/diff
>
>
> Testing
> -------
>
> icq: kopete vs miranda
> jabber: kopete vs pidgin
>
>
> Thanks,
>
> Florian
>
>

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

Re: [kopete-devel] Review Request: fix filetransfers in otr chatsessions

by Bugzilla from florian.reinhard@googlemail.com :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



> On 2009-09-29 09:30:54, mzanetti wrote:
> > Although file transfer (through xmpp) works here also without your patch, I think it doesn't harm. Instead it clears the situation with file transfers in the code and makes it cleaner.
> >
> > Ship it!
> >
> > Thanks,
> > Michael

could you please commit the patch to trunk and backport to the 4.3 branch?


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1717/#review2499
-----------------------------------------------------------


On 2009-09-28 21:43:17, Florian Reinhard wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1717/
> -----------------------------------------------------------
>
> (Updated 2009-09-28 21:43:17)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> When Kopete recieves a filetransfer from a chatsession that uses OTR, it tries to decrypt it and fails, showing [] instead of the download buttons.
>
>
> This addresses bug 183005.
>     https://bugs.kde.org/show_bug.cgi?id=183005
>
>
> Diffs
> -----
>
>   trunk/KDE/kdenetwork/kopete/plugins/otr/otrplugin.cpp 1028690
>
> Diff: http://reviewboard.kde.org/r/1717/diff
>
>
> Testing
> -------
>
> icq: kopete vs miranda
> jabber: kopete vs pidgin
>
>
> Thanks,
>
> Florian
>
>

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel

Re: [kopete-devel] Review Request: fix filetransfers in otr chatsessions

by Bugzilla from michael_zanetti@gmx.net :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



> On 2009-09-29 09:30:54, mzanetti wrote:
> > Although file transfer (through xmpp) works here also without your patch, I think it doesn't harm. Instead it clears the situation with file transfers in the code and makes it cleaner.
> >
> > Ship it!
> >
> > Thanks,
> > Michael
>
> Florian Reinhard wrote:
>     could you please commit the patch to trunk and backport to the 4.3 branch?

done... thx


- mzanetti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1717/#review2499
-----------------------------------------------------------


On 2009-09-28 21:43:17, Florian Reinhard wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1717/
> -----------------------------------------------------------
>
> (Updated 2009-09-28 21:43:17)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> When Kopete recieves a filetransfer from a chatsession that uses OTR, it tries to decrypt it and fails, showing [] instead of the download buttons.
>
>
> This addresses bug 183005.
>     https://bugs.kde.org/show_bug.cgi?id=183005
>
>
> Diffs
> -----
>
>   trunk/KDE/kdenetwork/kopete/plugins/otr/otrplugin.cpp 1028690
>
> Diff: http://reviewboard.kde.org/r/1717/diff
>
>
> Testing
> -------
>
> icq: kopete vs miranda
> jabber: kopete vs pidgin
>
>
> Thanks,
>
> Florian
>
>

_______________________________________________
kopete-devel mailing list
kopete-devel@...
https://mail.kde.org/mailman/listinfo/kopete-devel