[mb-bugs] [MusicBrainz Bug Tracker] #5242: "Merge release groups that would otherwise be empty" option not actually working

View: New views
5 Messages — Rating Filter:   Alert me  

[mb-bugs] [MusicBrainz Bug Tracker] #5242: "Merge release groups that would otherwise be empty" option not actually working

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5242: "Merge release groups that would otherwise be empty" option not actually
working
--------------------------------+-------------------------------------------
 Reporter:  voiceinsideyou      |       Owner:                                    
     Type:  bug                 |      Status:  new                              
 Priority:  normal              |   Milestone:                                    
Component:  MusicBrainz Server  |     Version:  Server 2009-05-24                
 Keywords:                      |     Browser:  Netscape, Firefox, Mozilla (Gecko)
       Os:                      |  
--------------------------------+-------------------------------------------
 I'm not sure if this is in /all/ circumstances (I can't be sure I
 correctly ticked the "merge RGs" option in all of my recent merges due to
 #5193) but I have a repeatable case where it's definitely not working.

 In http://test.musicbrainz.org/show/edit/?editid=10660508 I definitely
 ticked "Merge release groups that would be empty after the releases are
 merged." however the source release's empty group was not merged:
 http://test.musicbrainz.org/release-group/8c31336d-e9db-3cc3-943e-
 dc52edfbe8ab.html

 The same happened to me with three Boney M merges on the live server.

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5242>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5242: "Merge release groups that would otherwise be empty" option not actually working

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5242: "Merge release groups that would otherwise be empty" option not actually
working
-------------------------------------------------+--------------------------
  Reporter:  voiceinsideyou                      |       Owner:  rob              
      Type:  bug                                 |      Status:  new              
  Priority:  normal                              |   Milestone:                  
 Component:  MusicBrainz Server                  |     Version:  Server 2009-05-24
Resolution:                                      |    Keywords:                  
   Browser:  Netscape, Firefox, Mozilla (Gecko)  |          Os:                  
-------------------------------------------------+--------------------------
Changes (by voiceinsideyou):

  * owner:  => rob

Comment:

 Not sure if you've seen this one, but could this be looked into? This bug
 is creating mess and a need for extra edits.

 Assuming the code within the condition is correct; it looks to me that the
 error is at line 148 of
 http://bugs.musicbrainz.org/browser/mb_server/branches/RELEASE_20090524-BRANCH/htdocs/edit/albumbatch/merge.html

 {{{
         if ($ask_for_rg_merging && $merge_attributes == 1) {
 }}}

 should be

 {{{
         if ($ask_for_rg_merging && $merge_groups == 1) {
 }}}

 This looks like a simple typo; and would mean that the workaround (and a
 side effect bug in itself) would be to set "merge_attributes" to "yes" for
 the release.

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5242#comment:1>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5242: "Merge release groups that would otherwise be empty" option not actually working

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5242: "Merge release groups that would otherwise be empty" option not actually
working
-------------------------------------------------+--------------------------
  Reporter:  voiceinsideyou                      |       Owner:  rob              
      Type:  bug                                 |      Status:  assigned        
  Priority:  normal                              |   Milestone:                  
 Component:  MusicBrainz Server                  |     Version:  Server 2009-05-24
Resolution:                                      |    Keywords:                  
   Browser:  Netscape, Firefox, Mozilla (Gecko)  |          Os:                  
-------------------------------------------------+--------------------------
Changes (by rob):

  * status:  new => assigned

Comment:

 It sure looks like a typo. I've fixed it as you suggested on my dev
 server. Could you please test it to make sure?

 http://musicbrainz.homeip.net

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5242#comment:2>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5242: "Merge release groups that would otherwise be empty" option not actually working

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5242: "Merge release groups that would otherwise be empty" option not actually
working
-------------------------------------------------+--------------------------
  Reporter:  voiceinsideyou                      |       Owner:  rob              
      Type:  bug                                 |      Status:  assigned        
  Priority:  normal                              |   Milestone:                  
 Component:  MusicBrainz Server                  |     Version:  Server 2009-05-24
Resolution:                                      |    Keywords:                  
   Browser:  Netscape, Firefox, Mozilla (Gecko)  |          Os:                  
-------------------------------------------------+--------------------------
Comment (by voiceinsideyou):

 I've tested about 8 different use cases (merging 2 releases, merging >2
 releases, merging >2 releases from mixtures of RGs that would be empty and
 ones that wouldn't etc) and all created the correct edits and displayed
 the correct options for the merge. Looks good!

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5242#comment:3>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5242: "Merge release groups that would otherwise be empty" option not actually working

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5242: "Merge release groups that would otherwise be empty" option not actually
working
-------------------------------------------------+--------------------------
  Reporter:  voiceinsideyou                      |       Owner:  rob              
      Type:  bug                                 |      Status:  closed          
  Priority:  normal                              |   Milestone:                  
 Component:  MusicBrainz Server                  |     Version:  Server 2009-05-24
Resolution:  fixed                               |    Keywords:                  
   Browser:  Netscape, Firefox, Mozilla (Gecko)  |          Os:                  
-------------------------------------------------+--------------------------
Changes (by robert):

  * status:  assigned => closed
  * resolution:  => fixed

Comment:

 (In [11795]) Fixes #5242 ""Merge release groups that would otherwise be
 empty" option not actually working"

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5242#comment:4>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs