[mb-bugs] [MusicBrainz Bug Tracker] #5462: Picard hangs if request is pending and net connection is lost

[MusicBrainz Bug Tracker]

#5462: Picard hangs if request is pending and net connection is lost
---------------------------+------------------------------------------------
 Reporter:  BrianFreud     |       Owner:                    
     Type:  bug            |      Status:  new              
 Priority:  normal         |   Milestone:                    
Component:  Picard Tagger  |     Version:  Picard 0.12.0beta2
 Keywords:                 |          Os:                    
  Browser:                 |  
---------------------------+------------------------------------------------
 Using Picard on a rather flaky net connection, such that the net drops out
 for 1-2s every 5 to 10 minutes, loading any kind of data from MB becomes
 quite troublesome.  If Picard is loading album info, performing a PUID
 check with the MIP servers, looking up a PUID at MB, or doing a MB lookup
 - basically anything that involves doing an online request for data - then
 Picard gets "stuck" at the point the net connection is temporarily lost.
 Even when the net connection resumes, the pending request stays open until
 Picard is closed.  Attempting to re-request to data; via refresh on the
 album side, or re-clicking scan, doesn't work to un-stick Picard; the
 either shows nothing at all, or in the log window shows that "other
 requests are still pending, deferring request until those have completed".

 It seems all these issues would be solved by simply adding a timeout to
 any net request; if the data hasn't been received within some
 (configurable?) number of seconds, assume the request has failed for
 whatever reason - including a temporarily dropped net connection - and
 move on to the next request.  Not loading whatever that data was would be
 certainly preferable to Picard losing, from that point on, the ability to
 do any data request of any kind.  At that point, the only thing you can
 really do with Picard is to save; no other data will load, so closing
 Picard (and losing anything unsaved you're in the middle of) becomes the
 only current real option.



 Version: up to date bzr checkout of .12

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5462>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

[MusicBrainz Bug Tracker]

#5462: Picard hangs if request is pending and net connection is lost
----------------------------+-----------------------------------------------
  Reporter:  BrianFreud     |       Owner:                    
      Type:  bug            |      Status:  new              
  Priority:  normal         |   Milestone:                    
 Component:  Picard Tagger  |     Version:  Picard 0.12.0beta2
Resolution:                 |    Keywords:                    
        Os:                 |     Browser:                    
----------------------------+-----------------------------------------------
Comment (by outsidecontext):

 Known problem, wasn't there a ticket already?

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5462#comment:1>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

[MusicBrainz Bug Tracker]

#5462: Picard has no timeoput for network connections
----------------------------+-----------------------------------------------
  Reporter:  BrianFreud     |       Owner:                    
      Type:  bug            |      Status:  new              
  Priority:  normal         |   Milestone:                    
 Component:  Picard Tagger  |     Version:  Picard 0.12.0beta2
Resolution:                 |    Keywords:                    
        Os:                 |     Browser:                    
----------------------------+-----------------------------------------------
Changes (by outsidecontext):

  * summary:  Picard hangs if request is pending and net connection is lost
              => Picard has no timeoput for network
              connections

Comment:

 Ok, found it. This is basicxally what #2825 is about. I'm closing #2825
 since your ticket is more general adn #2825 just a specific incarnation of
 this problem.

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5462#comment:2>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

[MusicBrainz Bug Tracker]

#5462: Picard has no timeout for network connections
----------------------------+-----------------------------------------------
  Reporter:  BrianFreud     |       Owner:                    
      Type:  bug            |      Status:  new              
  Priority:  normal         |   Milestone:                    
 Component:  Picard Tagger  |     Version:  Picard 0.12.0beta2
Resolution:                 |    Keywords:                    
        Os:                 |     Browser:                    
----------------------------+-----------------------------------------------
Changes (by murdos):

  * summary:  Picard has no timeoput for network connections => Picard has
              no timeout for network connections

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5462#comment:3>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

[MusicBrainz Bug Tracker]

#5462: Picard has no timeout for network connections
----------------------------+-----------------------------------------------
  Reporter:  BrianFreud     |       Owner:                    
      Type:  bug            |      Status:  new              
  Priority:  normal         |   Milestone:                    
 Component:  Picard Tagger  |     Version:  Picard 0.12.0beta2
Resolution:                 |    Keywords:                    
        Os:                 |     Browser:                    
----------------------------+-----------------------------------------------
Comment (by BrianFreud):

 Note: This is not a perfect work-around, as the problems still are present
 for lookups and PUID lookups.

 I'm sure this wreaks some sorts of havok I'm not seeing, but this change
 at least made loading releases functional - if the net connection drops,
 once it's back, Picard automatically loads those that would otherwise have
 hung Picard without this change:

 In picard/album.py, changes lines 314 - 316 from

 {{{
         if self._requests:
             self.log.info("Not reloading, some requests are still
 active.")
             return
 }}}

 to

 {{{
         if self._requests:
             self._finalize_loading()
 }}}

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5462#comment:4>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs