[mb-bugs] [MusicBrainz Bug Tracker] #5478: Wrong originaldate with Original Release Date plugin.

View: New views
9 Messages — Rating Filter:   Alert me  

[mb-bugs] [MusicBrainz Bug Tracker] #5478: Wrong originaldate with Original Release Date plugin.

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5478: Wrong originaldate with Original Release Date plugin.
--------------------------------+-------------------------------------------
 Reporter:  elpoohy@...   |        Type:  bug          
   Status:  new                 |    Priority:  normal      
Milestone:                      |   Component:  Picard Tagger
  Version:  Picard 0.12.0beta2  |    Keywords:              
       Os:  Windows 7           |     Browser:              
--------------------------------+-------------------------------------------
 While adding release with more than one disk in release group
 ([http://musicbrainz.org/release-
 group/a106e33b-e440-3ff3-9250-c6408ed73e60.html like this]) in Picard
 0.12, Original Release Date plugin select early date not from the all
 related release? but early date frome the one of the other related
 release.

 In this example, if I select
 [http://musicbrainz.org/release/9d4c2605-2590-4d51-ade4-938382ef2622.html
 original release] originaldate equal "1991-02-22", if I select
 [http://musicbrainz.org/release/f666b896-f182-4c4d-b2af-25c6c1987f26.html
 remastered release] originaldate equal "1976-12-10".

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5478>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5478: use Remaster AR in Original Release Date plugin

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5478: use Remaster AR in Original Release Date plugin
--------------------------------+-------------------------------------------
  Reporter:  elpoohy@...  |       Owner:                    
      Type:  enhancement        |      Status:  new              
  Priority:  normal             |   Milestone:                    
 Component:  Picard Tagger      |     Version:  Picard 0.12.0beta2
Resolution:                     |    Keywords:                    
        Os:  Windows 7          |     Browser:                    
--------------------------------+-------------------------------------------
Changes (by zout):

  * type:  bug => enhancement
  * summary:  Wrong originaldate with Original Release Date plugin. => use
              Remaster AR in Original Release Date plugin

Comment:

 That's because it doesn't use the 'Remaster' Advanced Relationship.

 Changed this to enhancement so maybe someone will add the AR too to this
 plugin.

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5478#comment:1>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5478: use Remaster AR in Original Release Date plugin

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5478: use Remaster AR in Original Release Date plugin
--------------------------------+-------------------------------------------
  Reporter:  elpoohy@...  |       Owner:                    
      Type:  bug                |      Status:  new              
  Priority:  normal             |   Milestone:                    
 Component:  Picard Tagger      |     Version:  Picard 0.12.0beta2
Resolution:                     |    Keywords:                    
        Os:  Windows 7          |     Browser:                    
--------------------------------+-------------------------------------------
Changes (by zout):

  * type:  enhancement => bug

Comment:

 I guess this is a bug, as the code for this plugin tests for 'Remaster'.

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5478#comment:2>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5478: use Remaster AR in Original Release Date plugin

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5478: use Remaster AR in Original Release Date plugin
--------------------------------+-------------------------------------------
  Reporter:  elpoohy@...  |       Owner:  outsidecontext    
      Type:  bug                |      Status:  assigned          
  Priority:  normal             |   Milestone:                    
 Component:  Picard Tagger      |     Version:  Picard 0.12.0beta2
Resolution:                     |    Keywords:                    
        Os:  Windows 7          |     Browser:                    
--------------------------------+-------------------------------------------
Changes (by outsidecontext):

  * owner:  => outsidecontext
  * status:  new => assigned

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5478#comment:3>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5478: use Remaster AR in Original Release Date plugin

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5478: use Remaster AR in Original Release Date plugin
--------------------------------+-------------------------------------------
  Reporter:  elpoohy@...  |       Owner:  outsidecontext
      Type:  bug                |      Status:  assigned      
  Priority:  normal             |   Milestone:                
 Component:  Picard Tagger      |     Version:  Picard 0.12  
Resolution:                     |    Keywords:                
        Os:  Windows 7          |     Browser:                
--------------------------------+-------------------------------------------
Changes (by outsidecontext):

  * version:  Picard 0.12.0beta2 => Picard 0.12

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5478#comment:4>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5478: use Remaster AR in Original Release Date plugin

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5478: use Remaster AR in Original Release Date plugin
--------------------------------+-------------------------------------------
  Reporter:  elpoohy@...  |       Owner:  outsidecontext
      Type:  bug                |      Status:  assigned      
  Priority:  normal             |   Milestone:                
 Component:  Picard Tagger      |     Version:  Picard 0.12  
Resolution:                     |    Keywords:                
        Os:  Windows 7          |     Browser:                
--------------------------------+-------------------------------------------
Comment (by outsidecontext):

 I can't reproduce this. If I load the later release into Picard, "date" is
 set to 1991-02-22 and "originaldate" to 1976-12-10.

 Please note that those are two different tags, date and originaldate. If
 you had expected that the normal date tag gets replaced by the
 originaldate, I must disappoint you. Due to #3913 it is currently not
 possible to set the tag from within a plugin.

 And using some tagger script like $set(date,%originaldate%) unfortunately
 does not work, either, since the tagger script is executed before the
 plugin (and therefor the originaldate is not yet available). Maybe we
 should switch the order of execution.

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5478#comment:5>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5478: use Remaster AR in Original Release Date plugin

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5478: use Remaster AR in Original Release Date plugin
--------------------------------+-------------------------------------------
  Reporter:  elpoohy@...  |       Owner:  outsidecontext
      Type:  bug                |      Status:  assigned      
  Priority:  normal             |   Milestone:                
 Component:  Picard Tagger      |     Version:  Picard 0.12  
Resolution:                     |    Keywords:                
        Os:  Windows 7          |     Browser:                
--------------------------------+-------------------------------------------
Comment (by anonymous):

 Replying to [comment:5 outsidecontext]:
 > I can't reproduce this. If I load the later release into Picard, "date"
 is set to 1991-02-22 and "originaldate" to 1976-12-10.
 Yes, that right. But try to load
 [http://musicbrainz.org/release/9d4c2605-2590-4d51-ade4-938382ef2622.html
 first release] and "originaldate" is set to 1991-02-22 and "date" to
 1976-12-10.

 I understand that it's different tags.

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5478#comment:6>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5478: use Remaster AR in Original Release Date plugin

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5478: use Remaster AR in Original Release Date plugin
--------------------------------+-------------------------------------------
  Reporter:  elpoohy@...  |       Owner:  outsidecontext
      Type:  bug                |      Status:  closed        
  Priority:  normal             |   Milestone:                
 Component:  Picard Tagger      |     Version:  Picard 0.12  
Resolution:  fixed              |    Keywords:                
        Os:  Windows 7          |     Browser:                
--------------------------------+-------------------------------------------
Changes (by outsidecontext):

  * status:  assigned => closed
  * resolution:  => fixed

Comment:

 Fixed, get the updated plugin from
 http://users.musicbrainz.org/~outsidecontext/picard/plugins/originalreleasedate.py

 There were actually two bugs:
  * First the remaster AR was evaluated wrong (the direction in the XML
 returned by the web service is confusing and looks wrong to me)
  * Empty release dates were not excluded (so if there was an empty date in
 one of the events this always was the earliest release date)

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5478#comment:7>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs

Re: [mb-bugs] [MusicBrainz Bug Tracker] #5478: use Remaster AR in Original Release Date plugin

by MusicBrainz Bug Tracker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

#5478: use Remaster AR in Original Release Date plugin
--------------------------------+-------------------------------------------
  Reporter:  elpoohy@...  |       Owner:  outsidecontext
      Type:  bug                |      Status:  closed        
  Priority:  normal             |   Milestone:                
 Component:  Picard Tagger      |     Version:  Picard 0.12  
Resolution:  fixed              |    Keywords:                
        Os:  Windows 7          |     Browser:                
--------------------------------+-------------------------------------------
Comment (by zout):

 Thanks!

--
Ticket URL: <http://bugs.musicbrainz.org/ticket/5478#comment:8>
MusicBrainz Bug Tracker <http://musicbrainz.org>
MusicBrainz -- the music metadatabase
_______________________________________________
Musicbrainz-bugs mailing list
Musicbrainz-bugs@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs