[merge request] News and fdo-menu upgrade

View: New views
4 Messages — Rating Filter:   Alert me  

[merge request] News and fdo-menu upgrade

by Teika Kazura :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi. Please merge my branch.

It contains:
* sawfish.wm.defaults is always read from 1.6. So related news and comments.
* More news polish.
* Minor bug fix for frame font color.
* fdo-menu upgrade:
------------------------------------------------------------------------
Renamed fdo-menu.jl -> apps-menu.jl

New variable `user-apps-menu' is created. User can set their own
version of apps-menu here, and the auto generated apps menu is
appended to this.

Function `update-saw-menu' is split into `generate-apps-menu',
`init-apps-menu', and `update-apps-menu'.

Variables cleanup. Distinguishes local and global options. Most of
global options are given better names. Docstring.

Deleted unnecessary batch-mode check.
------------------------------------------------------------------------
(You may want to see the diff ignoring whitespace:
 git log -p -b --follow lisp/sawfish/wm/ext/apps-menu.jl )

Info, OPTIONS, and news.texi update is yet to be done.

It contains "my-term-string", but it is better to unify it with
"xterm-program" in wm/commands/user.jl, but I'm not sure
how. Terminals don't appear in my apps-menu, and I can't confirm
things. By the 1.6 shipment, more improvements like this are needed.


Chris, in news you recently deleted some linebreaks, but I think
it's better to have them to make headlines; readers can browse over
news, and quickly tell which item interests them.

If you like a break but not separate paragraphs, then you can do it
with "@*". (I tried some, without much confidence.)

"Easy" news items are almost ok. Now I turn to complicated features
which require more pen craft. News rewrite is in fact the review of
new changes. Phew, our developers have written much!

Best regards,
Teika (Teika kazura)


Re: [merge request] News and fdo-menu upgrade

by Flashrider :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

merged.

also did some cleanups after you:

menu.jl: Reload Appsmenu root-menu entry did (now) call wrong command
apps-menu.jl: removed dupped Category entry (Development in Dev-submenu)
apps-menu.jl: added Editors Category entry to Dev-submenu
apps-menu.jl: make use of global xterm-program instead of my-term-string
OPTIONS: updated for Teikas variable renaming

Chris


signature.asc (205 bytes) Download Attachment

Re: [merge request] News and fdo-menu upgrade

by Flashrider :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Am Samstag, den 17.10.2009, 07:32 +0200 schrieb Christopher Roy
Bratusek:

> merged.
>
> also did some cleanups after you:
>
> menu.jl: Reload Appsmenu root-menu entry did (now) call wrong command
> apps-menu.jl: removed dupped Category entry (Development in Dev-submenu)
> apps-menu.jl: added Editors Category entry to Dev-submenu
> apps-menu.jl: make use of global xterm-program instead of my-term-string
> OPTIONS: updated for Teikas variable renaming
>
> Chris
btw: that "Exiles" category should be optional. and the custom menu
should also be optional appendable instead of prependable, don't you
think?

is the bug there alphabetizing does not ignore the first letters case
fixed? (eg aApp ended up beeing after ZApp) don't have such app yet and
I'm to lazy to try. :)

@Matthew how far you got with the display icons in menu feature?
        if you need something in rep-gtk that's not yet in, tell us!

Chris


signature.asc (205 bytes) Download Attachment

Re: [merge request] News and fdo-menu upgrade

by Teika Kazura :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Sat, 17 Oct 2009 07:38:47 +0200, Christopher Roy Bratusek wrote:
> btw: custom menu should also be optional appendable instead of
> prependable.

Yep, but I don't need it, so if someone begs it ;)

Actually, it is quite likely that users want to re-order the apps menu
as they like. In that case, they have to generate the list with
(generate-apps-menu), and set `apps-menu' by hand. So I don't feel
like supporting append.

Teika (Teika kazura)