[mini-patch] make scrolling stop when moving view via API

Hi,

The bug https://bugs.kde.org/show_bug.cgi?id=184273
mentions that KHTMLView will not stop auto scrolling when one presses key
up/down.
This is due to the fact the KHTMLView does not stop it's internal timer when
one calls its scrollBy() Method, which is what kmail does.

I suggest the following patch.
Is this ok for commit ?


Index: khtmlview.cpp
===================================================================
--- khtmlview.cpp       (Revision 1013649)
+++ khtmlview.cpp       (Arbeitskopie)
@@ -746,6 +746,8 @@

 void KHTMLView::scrollBy(int x, int y)
 {
+   if (d->scrollTimerId)
+       d->newScrollTimer(this, 0);
    horizontalScrollBar()->setValue( horizontalScrollBar()->value()+x );
    verticalScrollBar()->setValue( verticalScrollBar()->value()+y );
 }

--
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail
          /\                        - against microsoft attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at

Le dimanche 23 août 2009, Martin Koller a écrit :

> Hi,
>
> The bug https://bugs.kde.org/show_bug.cgi?id=184273
> mentions that KHTMLView will not stop auto scrolling when one presses key
> up/down.
> This is due to the fact the KHTMLView does not stop it's internal timer
> when one calls its scrollBy() Method, which is what kmail does.
>
> I suggest the following patch.
> Is this ok for commit ?
>
>
> Index: khtmlview.cpp
> ===================================================================
> --- khtmlview.cpp       (Revision 1013649)
> +++ khtmlview.cpp       (Arbeitskopie)
> @@ -746,6 +746,8 @@
>
>  void KHTMLView::scrollBy(int x, int y)
>  {
> +   if (d->scrollTimerId)
> +       d->newScrollTimer(this, 0);
>     horizontalScrollBar()->setValue( horizontalScrollBar()->value()+x );
>     verticalScrollBar()->setValue( verticalScrollBar()->value()+y );
>  }

Hi Martin,
the patch looks fine : please commit.

Greetings,
Germain