[mule-jira] Created: (MULE-4590) java.lang.IllegalStateException: Phase 'dispose' has already been executed

java.lang.IllegalStateException: Phase 'dispose' has already been executed
--------------------------------------------------------------------------

                 Key: MULE-4590
                 URL: http://www.mulesource.org/jira/browse/MULE-4590
             Project: Mule
          Issue Type: Bug
          Components: Core: Concurrency / Threading
    Affects Versions: 2.2.2 (EE only)
            Reporter: Francis Upton


I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.

This is a similar problem to that of MULE-4589, but in dispose instead of start.

**********************************************************************
* Mule shut down normally on: 10/31/09 11:35 PM                      *
* Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
**********************************************************************
INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
java.lang.IllegalStateException: Phase 'dispose' has already been executed
        at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
        at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
        at org.mule.MuleServer.shutdown(MuleServer.java:411)
        at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
        at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
        at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
        at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
        at java.security.AccessController.doPrivileged(Native Method)
        at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
        at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
<-- Wrapper Stopped


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32221#action_32221 ]

Francis Upton commented on MULE-4590:
-------------------------------------

And a similar situation, cause by the same synchronization problem:

java.lang.IllegalStateException: Currently executing lifecycle phase: start
        at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:187)
        at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
        at org.mule.tck.AbstractMuleTestCase.disposeManager(AbstractMuleTestCase.java:500)
        at org.mule.tck.AbstractMuleTestCase.tearDown(AbstractMuleTestCase.java:465)
        at org.mule.tck.AbstractMuleTestCase.runBare(AbstractMuleTestCase.java:253)
        at org.mule.tck.AbstractMuleTestCase.run(AbstractMuleTestCase.java:233)

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.2.2 (EE only)
>            Reporter: Francis Upton
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32230#action_32230 ]

Francis Upton commented on MULE-4590:
-------------------------------------

Adding these changes to DefaultMuleContext seems to fix this problem, but I did not run all of the Mule regression tests:

1) Add "synchronized"

2) Add isDisposed() as well.

    // Changed to synchronized to fix MULE-4590
    public synchronized void dispose()
    {        
        // Added isDisposed() to fix MULE-4590 -
        if (isDisposing() || isDisposed())
        {
            return;
        }
             

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.2.2 (EE only)
>            Reporter: Francis Upton
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32231#action_32231 ]

Andrew Perepelytsya commented on MULE-4590:
-------------------------------------------

Francis, could you please submit patches as described here? http://www.mulesoft.org/display/MULE/Getting+Involved

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.2.2 (EE only)
>            Reporter: Francis Upton
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32255#action_32255 ]

Daniel Feist edited comment on MULE-4590 at 11/3/09 1:04 PM:
-------------------------------------------------------------

Francis: From what I see dispose() is already synchronized, also as far as I understand the isDisposing() check although harmless should not be needed if dispose is synchronous.  Can you provide a test case to reproduce this if possible?

      was (Author: dfeist):
    Francis: From what I see dispose() is already synchronized, also as far as I understand the isDisposing() check although harmless should not be needed if dispose is synchronous.
 

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.2.2 (EE only)
>            Reporter: Francis Upton
>            Assignee: Daniel Feist
>             Fix For: ITR25
>
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32255#action_32255 ]

Daniel Feist commented on MULE-4590:
------------------------------------

Francis: From what I see dispose() is already synchronized, also as far as I understand the isDisposing() check although harmless should not be needed if dispose is synchronous.

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.2.2 (EE only)
>            Reporter: Francis Upton
>            Assignee: Daniel Feist
>             Fix For: ITR25
>
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32256#action_32256 ]

Francis Upton commented on MULE-4590:
-------------------------------------

The dispose was not synchronized in 2.1.2 which is the version I was testing with, I also looked at the 2.2 branch and thought I saw that it was not synchronized.  There are two separate problems here:

1) the currently executing phase: start, this is fixed by synchronizing the dispose.

2) the exception 'dispose' has already executed, the synchronize alone will not fix this as another thread could call dispose() while it is being disposed or later.  That's what the isDisposed() check is for.

And I'm sorry, I don't have the bandwidth right now to create a separate test case.  I hit these problems regularly in my product's testing, but those test cases are intertwined with my product's tests.

Andrew - in the future I will submit patches that way.

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.2.2 (EE only)
>            Reporter: Francis Upton
>            Assignee: Daniel Feist
>             Fix For: ITR25
>
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32258#action_32258 ]

Daniel Feist commented on MULE-4590:
------------------------------------

I've checked and it's synchronized in latest version of all current code lines: 2.1.x, 2.2.x and 3.x.

> the synchronize alone will not fix this as another thread could call dispose() while it is being disposed or later
I don't understand this..any other threads will be waiting and by the time the first thread finishes and another thread enters isDisposed with return true.

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.2.2 (EE only)
>            Reporter: Francis Upton
>            Assignee: Daniel Feist
>             Fix For: ITR25
>
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32259#action_32259 ]

Francis Upton commented on MULE-4590:
-------------------------------------

Here is the code from the2.1.2 zip file, the revision on DefaultMuleContext is 12747, so it's possible someone already fixed the code lines.  Note the original code does not have isDisposed() only isDisposing() which does not prevent the problem.


    public void dispose()
    {        
        if (isDisposing())
        {
            return;
        }
             
        ServerNotificationManager notificationManager = getNotificationManager();

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.2.2 (EE only)
>            Reporter: Francis Upton
>            Assignee: Daniel Feist
>             Fix For: ITR25
>
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Feist closed MULE-4590.
------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: ITR25)
                   2.2.2 (EE only)
                   2.1.4 (EE only)

This was fixed in MULE-3727 for 2.1.4 (not yet released), and 2.2.2.

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.1.2
>            Reporter: Francis Upton
>            Assignee: Daniel Feist
>            Priority: Major
>             Fix For: 2.1.4 (EE only), 2.2.2 (EE only)
>
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Feist reopened MULE-4590:
--------------------------------

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.1.2
>            Reporter: Francis Upton
>            Assignee: Daniel Feist
>            Priority: Major
>             Fix For: 2.1.4 (EE only), 2.2.2 (EE only)
>
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

     [ http://www.mulesource.org/jira/browse/MULE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Feist closed MULE-4590.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.3 (EE only)
                   ITR25

> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> --------------------------------------------------------------------------
>
>                 Key: MULE-4590
>                 URL: http://www.mulesource.org/jira/browse/MULE-4590
>             Project: Mule
>          Issue Type: Bug
>          Components: Core: Concurrency / Threading
>    Affects Versions: 2.1.2
>            Reporter: Francis Upton
>            Assignee: Daniel Feist
>            Priority: Major
>             Fix For: 2.1.4 (EE only), ITR25, 2.2.3 (EE only), 2.2.2 (EE only)
>
>
> I am using Mule ESB EE 2.2.2 and testing it using Junit tests with the FunctionalTestCase mechanism (that is my Junit tests all subclass from this). I get this except intermittently when running the tests.
> This is a similar problem to that of MULE-4589, but in dispose instead of start.
> **********************************************************************
> * Mule shut down normally on: 10/31/09 11:35 PM                      *
> * Server was up for: 0 days, 0 hours, 0 mins, 4.55 sec               *
> **********************************************************************
> INFO  2009-10-31 23:35:16,511 [Wrapper-Shutdown-Hook] org.mule.MuleServer: Mule server shutting down due to normal shutdown request
> Error in WrapperListener.stop callback.  java.lang.IllegalStateException: Phase 'dispose' has already been executed
> java.lang.IllegalStateException: Phase 'dispose' has already been executed
> at org.mule.lifecycle.GenericLifecycleManager.checkPhase(GenericLifecycleManager.java:177)
> at org.mule.DefaultMuleContext.dispose(DefaultMuleContext.java:201)
> at org.mule.MuleServer.shutdown(MuleServer.java:411)
> at org.mule.module.boot.MuleServerWrapper.stop(MuleServerWrapper.java:74)
> at org.tanukisoftware.wrapper.WrapperManager.privilegedStopInner(WrapperManager.java:3180)
> at org.tanukisoftware.wrapper.WrapperManager.access$2600(WrapperManager.java:103)
> at org.tanukisoftware.wrapper.WrapperManager$8.run(WrapperManager.java:1995)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.tanukisoftware.wrapper.WrapperManager.stop(WrapperManager.java:1992)
> at org.tanukisoftware.wrapper.WrapperManager$2.run(WrapperManager.java:467)
> <-- Wrapper Stopped

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.mulesource.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email