[obv] comment fix for get_file_size()

View: New views
1 Messages — Rating Filter:   Alert me  

[obv] comment fix for get_file_size()

by Jan Kratochvil-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

There was a change

PATCH: PR binutils/10321: objcopy silently exits with empty input files
http://sourceware.org/ml/binutils/2009-06/msg00457.html
http://sourceware.org/ml/binutils-cvs/2009-06/msg00205.html
ae371689a784ec78f75061e918c5719c6ba0f0a9

@@ -574,1 +574,1 @@ get_file_size (const char * file_name)
-  return 0;
+  return (off_t) -1;

but the function comment was not updated for it.  Fixed the comment as obvious.


Thanks,
Jan


http://sourceware.org/ml/binutils-cvs/2009-11/msg00069.html

--- src/binutils/ChangeLog 2009/11/08 21:36:46 1.1558
+++ src/binutils/ChangeLog 2009/11/08 23:01:57 1.1559
@@ -1,3 +1,7 @@
+2009-11-09  Jan Kratochvil  <jan.kratochvil@...>
+
+ * bucomm.c (get_file_size): Update comment for the error return value.
+
 2009-11-08  John David Anglin  <dave.anglin@...>
 
  * readelf.c (slurp_hppa_unwind_table): Don't relocate address twice.
--- src/binutils/bucomm.c 2009/09/10 13:40:44 1.37
+++ src/binutils/bucomm.c 2009/11/08 23:01:57 1.38
@@ -552,7 +552,7 @@
 
 /* Returns the size of the named file.  If the file does not
    exist, or if it is not a real file, then a suitable non-fatal
-   error message is printed and zero is returned.  */
+   error message is printed and (off_t) -1 is returned.  */
 
 off_t
 get_file_size (const char * file_name)