[openssl.org #2085] [patch] invert util/domd check to work with multiple compilers

[Misha Aizatulin via RT]

> [vapier@... - Mon Oct 26 13:59:37 2009]:
>
> the current util/domd script defaults $MAKEDEPEND to `makedepend` and
> then
> checks the value against "gcc".  this doesnt work if $MAKEDEPEND is
> set to a
> gcc compiler by another name (i686-pc-linux-gcc, cc, etc...).  so
> invert the
> script logic so that it runs the makedepend code when using makedepend
> and
> uses the gcc-compatible syntax for everything else.
>

OpenSSL 1.0.0 instead does:

if expr "$MAKEDEPEND" : '.*gcc$' > /dev/null; then

i.e. check if $MAKEDEPEND ends in "gcc". Would backporting that test
address your concerns?

Steve.
--
Dr Stephen N. Henson. OpenSSL project core developer.
Commercial tech support now available see: http://www.openssl.org

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@...
Automated List Manager                           majordomo@...

[Misha Aizatulin via RT]

On Wednesday 28 October 2009 10:18:10 Stephen Henson via RT wrote:

> > [vapier@... - Mon Oct 26 13:59:37 2009]:
> >
> > the current util/domd script defaults $MAKEDEPEND to `makedepend` and
> > then
> > checks the value against "gcc".  this doesnt work if $MAKEDEPEND is
> > set to a
> > gcc compiler by another name (i686-pc-linux-gcc, cc, etc...).  so
> > invert the
> > script logic so that it runs the makedepend code when using makedepend
> > and
> > uses the gcc-compatible syntax for everything else.
>
> OpenSSL 1.0.0 instead does:
>
> if expr "$MAKEDEPEND" : '.*gcc$' > /dev/null; then
>
> i.e. check if $MAKEDEPEND ends in "gcc". Would backporting that test
> address your concerns?

for all the use cases i care about, it should indeed work fine
-mike

[Mike Frysinger]

On Wednesday 28 October 2009 10:18:10 Stephen Henson via RT wrote:

> > [vapier@... - Mon Oct 26 13:59:37 2009]:
> >
> > the current util/domd script defaults $MAKEDEPEND to `makedepend` and
> > then
> > checks the value against "gcc".  this doesnt work if $MAKEDEPEND is
> > set to a
> > gcc compiler by another name (i686-pc-linux-gcc, cc, etc...).  so
> > invert the
> > script logic so that it runs the makedepend code when using makedepend
> > and
> > uses the gcc-compatible syntax for everything else.
>
> OpenSSL 1.0.0 instead does:
>
> if expr "$MAKEDEPEND" : '.*gcc$' > /dev/null; then
>
> i.e. check if $MAKEDEPEND ends in "gcc". Would backporting that test
> address your concerns?

for all the use cases i care about, it should indeed work fine
-mike