« Return to Thread: [patch #7720] Bug in EEPROM write

[patch #7720] Bug in EEPROM write

by Jimmy Zelinskie :: Rate this Message:

| View in Thread

Follow-up Comment #2, patch #7720 (project avrdude):

If the interface of paged_load/write is outdated, so may be better retire them
and put some write/read_page function at their places.


  int  (*write_page)    (struct programmer_t * pgm, AVRPART * p, AVRMEM * m,
                          unsigned int page_number, unsigned int n_bytes);
  int  (*read_page)     (struct programmer_t * pgm, AVRPART * p, AVRMEM * m,
                           unsigned int page_number, unsigned int n_bytes);


If you always write/read whole pages the n_bytes parameter can be discarded
too.

Main reason to change the names of the functions are the patches in the patch
tracker and and in other places at the web which would all fail to work if
using still the old interface (anybody really cares about the compiler
warnings?). The same problem we had already when paged_load/write changed
their interfaces. Using new names, people get at least a compiler error and
must fix this to be able to use paged functions again.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7720>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/


_______________________________________________
avrdude-dev mailing list
avrdude-dev@...
https://lists.nongnu.org/mailman/listinfo/avrdude-dev

 « Return to Thread: [patch #7720] Bug in EEPROM write