[patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module

[Eugene Grosbein]

>Submitter-Id: current-users
>Originator: Eugene Grosbein
>Organization: Private person
>Confidential: no
>Synopsis: [patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module
>Severity: serious
>Priority: high
>Category: kern
>Class: sw-bug
>Release: FreeBSD 8.0-BETA3 i386
>Environment:

System: FreeBSD grosbein.pp.ru 8.0-BETA3 FreeBSD 8.0-BETA3 #6: Fri Aug 28 22:34:15 KRAST 2009 eugen@...:/usr/local/obj/usr/local/src/sys/DADV i386

>Description:
       
        NanoBSD does not builds:

===> sys/modules/sysvipc/sysvmsg (depend)
machine -> /usr/local/src/sys/i386/include
:> opt_sysvipc.h
@ -> /usr/local/src/sys
rm -f .depend
mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE -I. -I@ -I@/contrib/altq /usr/local/src/sys/modules/sysvipc/sysvmsg/../../../kern/sysv_msg.c
/usr/local/src/sys/modules/sysvipc/sysvmsg/../../../kern/sysv_msg.c:53:24: error: opt_compat.h: No such file or directory
mkdep: compile failed
*** Error code 1

>How-To-Repeat:
        Try to build NanoBSD.

>Fix:

        Apply next patch to /usr/src:

--- sys/modules/sysvipc/sysvmsg/Makefile.orig 2009-08-30 19:12:16.000000000 +0800
+++ sys/modules/sysvipc/sysvmsg/Makefile 2009-08-30 19:14:13.000000000 +0800
@@ -5,4 +5,11 @@
 KMOD= sysvmsg
 SRCS= sysv_msg.c opt_sysvipc.h
 
+.if !defined(KERNBUILDDIR)
+opt_compat.h:
+ echo "#define COMPAT_FREEBSD8 1" > ${.TARGET}
+
+SRCS+= opt_compat.h
+.endif
+
 .include <bsd.kmod.mk>


_______________________________________________
freebsd-qa@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-qa
To unsubscribe, send any mail to "freebsd-qa-unsubscribe@..."

[Marc Fonvieille]

On Sun, Aug 30, 2009 at 07:23:06PM +0800, Eugene Grosbein wrote:

>
> >Number:         138341
> >Category:       kern
> >Synopsis:       [patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module
> >Confidential:   no
> >Severity:       serious
> >Priority:       high
> >Responsible:    freebsd-bugs
> >State:          open
> >Quarter:        
> >Keywords:      
> >Date-Required:
> >Class:          sw-bug
> >Submitter-Id:   current-users
> >Arrival-Date:   Sun Aug 30 11:40:02 UTC 2009
> >Closed-Date:
> >Last-Modified:
> >Originator:     Eugene Grosbein
> >Release:        FreeBSD 8.0-BETA3 i386
> >Organization:
> Private person
> >Environment:
> System: FreeBSD grosbein.pp.ru 8.0-BETA3 FreeBSD 8.0-BETA3 #6: Fri Aug 28 22:34:15 KRAST 2009 eugen@...:/usr/local/obj/usr/local/src/sys/DADV i386
>
> >Description:
>
> NanoBSD does not builds:
>
> ===> sys/modules/sysvipc/sysvmsg (depend)
> machine -> /usr/local/src/sys/i386/include
> :> opt_sysvipc.h
> @ -> /usr/local/src/sys
> rm -f .depend
> mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE -I. -I@ -I@/contrib/altq /usr/local/src/sys/modules/sysvipc/sysvmsg/../../../kern/sysv_msg.c
> /usr/local/src/sys/modules/sysvipc/sysvmsg/../../../kern/sysv_msg.c:53:24: error: opt_compat.h: No such file or directory
> mkdep: compile failed
> *** Error code 1
>
> >How-To-Repeat:
> Try to build NanoBSD.
>
> >Fix:
>
> Apply next patch to /usr/src:
>
> --- sys/modules/sysvipc/sysvmsg/Makefile.orig 2009-08-30 19:12:16.000000000 +0800
> +++ sys/modules/sysvipc/sysvmsg/Makefile 2009-08-30 19:14:13.000000000 +0800
> @@ -5,4 +5,11 @@
>  KMOD= sysvmsg
>  SRCS= sysv_msg.c opt_sysvipc.h
>  
> +.if !defined(KERNBUILDDIR)
> +opt_compat.h:
> + echo "#define COMPAT_FREEBSD8 1" > ${.TARGET}
> +
> +SRCS+= opt_compat.h
> +.endif
> +
>  .include <bsd.kmod.mk>
>
>

I suspect it's the problem I met when I tried to do a

make -DMODULES_WITH_WORLD="YES" buildworld

and many modules were concerned.  See the following patch:

Index: sys/modules/dtrace/lockstat/Makefile
===================================================================
--- sys/modules/dtrace/lockstat/Makefile (revision 196013)
+++ sys/modules/dtrace/lockstat/Makefile (working copy)
@@ -5,7 +5,7 @@
 KMOD= lockstat
 SRCS= lockstat.c
 
-SRCS+= vnode_if.h
+SRCS+= vnode_if.h opt_kdtrace.h
 
 CFLAGS+= -I${.CURDIR}/../../../cddl/compat/opensolaris \
  -I${.CURDIR}/../../../cddl/contrib/opensolaris/uts/common \
Index: sys/modules/sysvipc/sysvsem/Makefile
===================================================================
--- sys/modules/sysvipc/sysvsem/Makefile (revision 196013)
+++ sys/modules/sysvipc/sysvsem/Makefile (working copy)
@@ -3,6 +3,6 @@
 .PATH: ${.CURDIR}/../../../kern
 
 KMOD= sysvsem
-SRCS= sysv_sem.c opt_sysvipc.h
+SRCS= sysv_sem.c opt_sysvipc.h opt_compat.h
 
 .include <bsd.kmod.mk>
Index: sys/modules/sysvipc/sysvmsg/Makefile
===================================================================
--- sys/modules/sysvipc/sysvmsg/Makefile (revision 196013)
+++ sys/modules/sysvipc/sysvmsg/Makefile (working copy)
@@ -3,6 +3,6 @@
 .PATH: ${.CURDIR}/../../../kern
 
 KMOD= sysvmsg
-SRCS= sysv_msg.c opt_sysvipc.h
+SRCS= sysv_msg.c opt_sysvipc.h opt_compat.h
 
 .include <bsd.kmod.mk>

--
Marc
_______________________________________________
freebsd-qa@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-qa
To unsubscribe, send any mail to "freebsd-qa-unsubscribe@..."

[Eugene Grosbein]

On Sun, Aug 30, 2009 at 02:34:08PM +0200, Marc Fonvieille wrote:

> > ===> sys/modules/sysvipc/sysvmsg (depend)
> > machine -> /usr/local/src/sys/i386/include
> > :> opt_sysvipc.h
> > @ -> /usr/local/src/sys
> > rm -f .depend
> > mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE -I. -I@ -I@/contrib/altq /usr/local/src/sys/modules/sysvipc/sysvmsg/../../../kern/sysv_msg.c
> > /usr/local/src/sys/modules/sysvipc/sysvmsg/../../../kern/sysv_msg.c:53:24: error: opt_compat.h: No such file or directory
> > mkdep: compile failed
> > *** Error code 1
> >
> > >How-To-Repeat:
> > Try to build NanoBSD.
> >
> > >Fix:
> >
> > Apply next patch to /usr/src:
> >
> > --- sys/modules/sysvipc/sysvmsg/Makefile.orig 2009-08-30 19:12:16.000000000 +0800
> > +++ sys/modules/sysvipc/sysvmsg/Makefile 2009-08-30 19:14:13.000000000 +0800
> > @@ -5,4 +5,11 @@
> >  KMOD= sysvmsg
> >  SRCS= sysv_msg.c opt_sysvipc.h
> >  
> > +.if !defined(KERNBUILDDIR)
> > +opt_compat.h:
> > + echo "#define COMPAT_FREEBSD8 1" > ${.TARGET}
> > +
> > +SRCS+= opt_compat.h
> > +.endif
> > +
> >  .include <bsd.kmod.mk>
> >
> >
>
> I suspect it's the problem I met when I tried to do a
>
> make -DMODULES_WITH_WORLD="YES" buildworld
>
> and many modules were concerned.  See the following patch:
>
> Index: sys/modules/dtrace/lockstat/Makefile
> ===================================================================
> --- sys/modules/dtrace/lockstat/Makefile (revision 196013)
> +++ sys/modules/dtrace/lockstat/Makefile (working copy)
> @@ -5,7 +5,7 @@
>  KMOD= lockstat
>  SRCS= lockstat.c
>  
> -SRCS+= vnode_if.h
> +SRCS+= vnode_if.h opt_kdtrace.h
>  
>  CFLAGS+= -I${.CURDIR}/../../../cddl/compat/opensolaris \
>   -I${.CURDIR}/../../../cddl/contrib/opensolaris/uts/common \
> Index: sys/modules/sysvipc/sysvsem/Makefile
> ===================================================================
> --- sys/modules/sysvipc/sysvsem/Makefile (revision 196013)
> +++ sys/modules/sysvipc/sysvsem/Makefile (working copy)
> @@ -3,6 +3,6 @@
>  .PATH: ${.CURDIR}/../../../kern
>  
>  KMOD= sysvsem
> -SRCS= sysv_sem.c opt_sysvipc.h
> +SRCS= sysv_sem.c opt_sysvipc.h opt_compat.h
>  
>  .include <bsd.kmod.mk>
> Index: sys/modules/sysvipc/sysvmsg/Makefile
> ===================================================================
> --- sys/modules/sysvipc/sysvmsg/Makefile (revision 196013)
> +++ sys/modules/sysvipc/sysvmsg/Makefile (working copy)
> @@ -3,6 +3,6 @@
>  .PATH: ${.CURDIR}/../../../kern
>  
>  KMOD= sysvmsg
> -SRCS= sysv_msg.c opt_sysvipc.h
> +SRCS= sysv_msg.c opt_sysvipc.h opt_compat.h
>  
>  .include <bsd.kmod.mk>
>

You are right, other modules are concerned and your patch is more complete
and correct. Vote for commit :-)

Eugene Grosbein
_______________________________________________
freebsd-qa@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-qa
To unsubscribe, send any mail to "freebsd-qa-unsubscribe@..."

[Marc Fonvieille]

On Sun, Aug 30, 2009 at 08:40:07PM +0800, Eugene Grosbein wrote:

> >
> > I suspect it's the problem I met when I tried to do a
> >
> > make -DMODULES_WITH_WORLD="YES" buildworld
> >
> > and many modules were concerned.  See the following patch:
> >
> > Index: sys/modules/dtrace/lockstat/Makefile
> > ===================================================================
> > --- sys/modules/dtrace/lockstat/Makefile (revision 196013)
> > +++ sys/modules/dtrace/lockstat/Makefile (working copy)
> > @@ -5,7 +5,7 @@
> >  KMOD= lockstat
> >  SRCS= lockstat.c
> >  
> > -SRCS+= vnode_if.h
> > +SRCS+= vnode_if.h opt_kdtrace.h
> >  
> >  CFLAGS+= -I${.CURDIR}/../../../cddl/compat/opensolaris \
> >   -I${.CURDIR}/../../../cddl/contrib/opensolaris/uts/common \
> > Index: sys/modules/sysvipc/sysvsem/Makefile
> > ===================================================================
> > --- sys/modules/sysvipc/sysvsem/Makefile (revision 196013)
> > +++ sys/modules/sysvipc/sysvsem/Makefile (working copy)
> > @@ -3,6 +3,6 @@
> >  .PATH: ${.CURDIR}/../../../kern
> >  
> >  KMOD= sysvsem
> > -SRCS= sysv_sem.c opt_sysvipc.h
> > +SRCS= sysv_sem.c opt_sysvipc.h opt_compat.h
> >  
> >  .include <bsd.kmod.mk>
> > Index: sys/modules/sysvipc/sysvmsg/Makefile
> > ===================================================================
> > --- sys/modules/sysvipc/sysvmsg/Makefile (revision 196013)
> > +++ sys/modules/sysvipc/sysvmsg/Makefile (working copy)
> > @@ -3,6 +3,6 @@
> >  .PATH: ${.CURDIR}/../../../kern
> >  
> >  KMOD= sysvmsg
> > -SRCS= sysv_msg.c opt_sysvipc.h
> > +SRCS= sysv_msg.c opt_sysvipc.h opt_compat.h
> >  
> >  .include <bsd.kmod.mk>
> >
>
> You are right, other modules are concerned and your patch is more complete
> and correct. Vote for commit :-)
>

For info this unbreak things for most of archs but mips and arm which
need more work in sys/modules/Makefile.  However we can already commit
this patch.

--
Marc
_______________________________________________
freebsd-qa@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-qa
To unsubscribe, send any mail to "freebsd-qa-unsubscribe@..."