[patch] stop kdump from segfaulting with a linuxulator ktrace.out

View: New views
4 Messages — Rating Filter:   Alert me  

[patch] stop kdump from segfaulting with a linuxulator ktrace.out

by Alexander Best :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

could somebody please commit this very simple patch to HEAD which has been
around for almost 2 years, but never got committed (bin/120055).

thanks in advance.
alex

Index: kdump.c
===================================================================
--- kdump.c (revision 199016)
+++ kdump.c (working copy)
@@ -799,7 +799,7 @@
  narg--;
  }
  }
- while (narg) {
+ while (narg > 0) {
  print_number(ip,narg,c);
  }
  (void)putchar(')');

_______________________________________________
freebsd-current@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@..."

Re: [patch] stop kdump from segfaulting with a linuxulator ktrace.out

by Attilio Rao-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

2009/11/7 Alexander Best <alexbestms@...>:
> could somebody please commit this very simple patch to HEAD which has been
> around for almost 2 years, but never got committed (bin/120055).

Can you fill a PR with details and assign to me?

Attilio


--
Peace can only be achieved by understanding - A. Einstein
_______________________________________________
freebsd-current@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@..."

Re: [patch] stop kdump from segfaulting with a linuxulator ktrace.out

by Attilio Rao-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

2009/11/7 Attilio Rao <attilio@...>:
> 2009/11/7 Alexander Best <alexbestms@...>:
>> could somebody please commit this very simple patch to HEAD which has been
>> around for almost 2 years, but never got committed (bin/120055).
>
> Can you fill a PR with details and assign to me?
>

Sorry, I didn't notice we already have 2 PRs on it.
Fix committed as r199024.

Thanks,
Attilio


--
Peace can only be achieved by understanding - A. Einstein
_______________________________________________
freebsd-current@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@..."

Re: [patch] stop kdump from segfaulting with a linuxulator ktrace.out

by Alexander Best :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Attilio Rao schrieb am 2009-11-07:
> 2009/11/7 Attilio Rao <attilio@...>:
> > 2009/11/7 Alexander Best <alexbestms@...>:
> >> could somebody please commit this very simple patch to HEAD which
> >> has been
> >> around for almost 2 years, but never got committed (bin/120055).

> > Can you fill a PR with details and assign to me?


> Sorry, I didn't notice we already have 2 PRs on it.
> Fix committed as r199024.

> Thanks,
> Attilio

thanks a lot for committing this fix. :)

i'll try to find some time and come up with patches for 8-,7- and 6-stable as
well so this can get mfc'ed.

cheers.
alex
_______________________________________________
freebsd-current@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@..."